Skip to content

[ADD] Sales: adding new doc about returns and refunds directly in Sales app #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] Sales: adding new doc about returns and refunds directly in Sales app #1019

wants to merge 1 commit into from

Conversation

@vpk-odoo
Copy link
Contributor

@vpk-odoo vpk-odoo commented Jun 7, 2021

@vpk-odoo vpk-odoo added this to the 14.0 milestone Jun 7, 2021
@vpk-odoo vpk-odoo changed the title [IMP] Sales: adding new doc about returns and refunds directly in Sales app [ADD] Sales: adding new doc about returns and refunds directly in Sales app Jun 7, 2021
@vpk-odoo vpk-odoo force-pushed the 14.0-sales-returns-refunds-vpk branch from a685709 to 2604e85 Compare June 7, 2021 21:52
@vpk-odoo vpk-odoo requested a review from xpl-odoo June 8, 2021 16:43
xpl-odoo
xpl-odoo requested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note: your commit message title shouldn't exceed 72 characters
It could be something simpler like [ADD] Sales: new doc about returns and refunds

@vpk-odoo vpk-odoo force-pushed the 14.0-sales-returns-refunds-vpk branch from 2604e85 to 2779b3f Compare June 14, 2021 18:13
@vpk-odoo vpk-odoo force-pushed the 14.0-sales-returns-refunds-vpk branch 2 times, most recently from f7ad5f1 to 12c62a5 Compare June 23, 2021 17:34
@C3POdoo C3POdoo requested a review from a team December 9, 2021 11:37
@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 12c62a5 to 973faf8 Compare July 6, 2022 17:16
@robodoo
Copy link
Collaborator

robodoo commented Jul 6, 2022

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

@robodoo
Copy link
Collaborator

robodoo commented Jul 6, 2022

Pull request status dashboard.

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch 2 times, most recently from 2b93707 to ad01013 Compare July 11, 2022 19:30
@samueljlieber
Copy link
Contributor

samueljlieber commented Jul 11, 2022

Hello @meng-odoo 👋
I updated this doc to the latest 14.0 updates and it is ready for a content review. Let me know if you have any suggestions for improvement!

@StraubCreative StraubCreative force-pushed the 14.0-sales-returns-refunds-vpk branch 3 times, most recently from 470ca07 to de38f11 Compare July 13, 2022 01:12
@StraubCreative
Copy link
Contributor

StraubCreative commented Jul 13, 2022

Fixed truncated commit message on ad01013 + changed to XPL suggestion

CI checks weren't passing:

  • renamed + pushed reverse-transfer-popup.png (media file started with capital R ≠ what was in RST pathname)
  • rebased to latest 14.0 updates

Commit message fixed + properly formatted and all CI checks pass now ✅

@meng-odoo you're good to go now here.
Please advise any content changes and also indicate if this content is only specific to 14.0 or if it can be forward-ported.

cc: @samueljlieber

@StraubCreative StraubCreative force-pushed the 14.0-sales-returns-refunds-vpk branch from de38f11 to d6a0eb1 Compare July 29, 2022 23:36
meng-odoo
meng-odoo suggested changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samueljlieber :) Here's another set of edits for you. Please let me know if you have any questions. Thanks!

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from d6a0eb1 to 5653714 Compare August 19, 2022 17:21
@samueljlieber
Copy link
Contributor

samueljlieber commented Aug 19, 2022

Hey @meng-odoo 👋, I've updated the RST for this document. Let me know if you have any more edits!

meng-odoo
meng-odoo suggested changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samueljlieber thanks for making those changes! I just have a couple more, plus there are a couple edits from the last round that didn't make it onto this commit. Please let me know if you have any questions :) thanks

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 5653714 to c011e65 Compare August 22, 2022 14:15
@samueljlieber
Copy link
Contributor

samueljlieber commented Aug 22, 2022

Hi @meng-odoo, sorry I missed those edits! The document is now up to date with your latest changes.

@meng-odoo meng-odoo requested a review from mivu-odoo August 25, 2022 17:46
mivu-odoo
mivu-odoo suggested changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @meng-odoo and @samueljlieber! Thank you for your patience on this!

I finished my final review. @meng-odoo Two screenshots, updated-sales-quantities.png and case-2-updated-sales-quantities.png will need to be retaken for better content clarity.

Please let me know when you're ready for a second look. Thank you 😸

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 46298a6 to 387ff31 Compare September 8, 2022 14:26
@samueljlieber
Copy link
Contributor

samueljlieber commented Sep 8, 2022

Hi @mivu-odoo 👋
I made the changes and replaced the two images with the new ones @meng-odoo provided! Ready for a second look!

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 387ff31 to 6c15069 Compare September 8, 2022 14:33
@samueljlieber
Copy link
Contributor

samueljlieber commented Sep 8, 2022

Commit 6c15069 to add a blank line at the end of the document.

mivu-odoo
mivu-odoo approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@mivu-odoo mivu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samueljlieber and @meng-odoo! Thank you for making the requested changes! I just flagged one more image :alt: tag that should be adjusted for consistency with the other images' alt tags.

Once that is tweaked, feel free to go straight to ZST for final technical review. Thank you 😸

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 6c15069 to 793e6b9 Compare September 8, 2022 18:41
@samueljlieber
Copy link
Contributor

samueljlieber commented Sep 8, 2022 •
edited
Loading

Hi @StraubCreative 🙂 this document is ready for a final technical review!

StraubCreative
StraubCreative requested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,
Couple quick changes 👇

  1. Most screenshots are too big, don’t appear to be in HD, and could be cropped further to highlight relevant information without having to click the modal. Please make sure screenshots are around tablet breakpoint size @ ~768px wide and are taken at ~120% zoom. Crop screenshots further as needed to eliminate visual noise.
    • reverse-transfer-popup.png
    • updated-sales-quantities.png
    • case-2-updated-sales-quantities.png
    • credit-note-popup

  2. The two sales-quantities screenshots back to back are basically identical and don’t show unique information between the two. Would remove the second one or replace with something more relevant.
    • updated-sales-quantities.png
    • case-2-updated-sales-quantities.png

  3. nit-pick: image alt titles are vague and could use more context.

Everything else looked good.

@meng-odoo
Copy link
Contributor

meng-odoo commented Nov 9, 2022

Hi @StraubCreative and @samueljlieber! I've attached the updated (compressed) screenshots below, along with more descriptive alt titles for each one. Please let me know if you see anything else I should change :) thanks!

  1. reverse-transfer-popup.png
    reverse-transfer-popup
    (Unfortunately, this one couldn't be reduced to 768px wide without removing relevant info.)
    Alt: The "Reverse Transfer" pop-up window, to make a return before invoicing the customer.

  2. updated-sales-quantities.png
    updated-sales-quantities
    Alt: The updated "Delivered" quantity on the sales order after the reverse transfer.

  3. case-2-updated-sales-quantities.png
    Let's just delete this one from the document.

  4. credit-note-popup.png
    credit-note-popup
    Alt: The "Credit Note" pop-up window, to issue a credit to the customer after invoicing.

@samueljlieber samueljlieber force-pushed the 14.0-sales-returns-refunds-vpk branch from 793e6b9 to 6023c1d Compare November 10, 2022 14:32
@samueljlieber
Copy link
Contributor

samueljlieber commented Nov 10, 2022

Thanks @meng-odoo, the doc was updated with your changes in 6023c1d. @StraubCreative ready for another review 🙂

@StraubCreative StraubCreative force-pushed the 14.0-sales-returns-refunds-vpk branch from 6023c1d to f5be445 Compare November 18, 2022 05:46
StraubCreative
StraubCreative approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@odoo/doc-review you're up :)

@StraubCreative StraubCreative requested a review from a team November 18, 2022 05:47
AntoineVDV
AntoineVDV approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 18, 2022
@vpk-odoo @StraubCreative
[ADD] Sales: new doc about returns and refunds
be0a995 
Task Number: 2514789

closes #1019

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@fw-bot fw-bot mentioned this pull request Nov 18, 2022
Closed
@robodoo robodoo temporarily deployed to merge November 18, 2022 11:25 Inactive
@robodoo robodoo closed this Nov 18, 2022
This was referenced Nov 18, 2022
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Nov 22, 2022

@vpk-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2985

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented Nov 23, 2022

@vpk-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):
#2985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcs-odoo jcs-odoo jcs-odoo left review comments

@xpl-odoo xpl-odoo xpl-odoo requested changes

@StraubCreative StraubCreative StraubCreative approved these changes

@AntoineVDV AntoineVDV AntoineVDV approved these changes

+2 more reviewers

@meng-odoo meng-odoo meng-odoo approved these changes

@mivu-odoo mivu-odoo mivu-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samueljlieber samueljlieber

@meng-odoo meng-odoo

Labels

None yet

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

10 participants

@vpk-odoo @robodoo @samueljlieber @StraubCreative @meng-odoo @fw-bot @AntoineVDV @jcs-odoo @xpl-odoo @mivu-odoo