CSS & Doc Organization Cleanup #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feyensv
reviewed
Jul 5, 2021
AntoineVDV
requested changes
Jul 5, 2021
Collaborator
There was a problem hiding this comment.
It's good to have a short introduction on top-level app pages but it looks quite bad in full-screen, similar to the English version of Wikipedia. See:
Whenever possible, I posted my comments with suggestions so that you can directly commit them to the branch.
EDIT: I see that other people reviewed in parallel. Some of my comments may thus be redundant.
edi-odoo
reviewed
Jul 5, 2021
Contributor
edi-odoo
left a comment
edi-odoo
left a comment
There was a problem hiding this comment.
I don't agree with everything, but it's more a matter of taste. I'll make the necessary changes on the branch and force-push.
AntoineVDV
reviewed
Jul 6, 2021
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
Suggestions to be committed from GitHub.
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
edi-odoo
reviewed
Jul 6, 2021
AntoineVDV
reviewed
Jul 7, 2021
jcs-odoo
reviewed
Jul 7, 2021
AntoineVDV
approved these changes
Jul 7, 2021
Contributor
Author
|
Ok, so let's create a new one as the old one was outdated.
…On Tue, Jul 13, 2021 at 4:06 PM ALE-Odoo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/administration/db_management/db_online.rst
<#1054 (comment)>:
> -.. _db_online:
-
-==========================
-Online Database management
-==========================
I confirm that it's used a lot! I can put people on it to update the
information. DB management for online or on-premise is the kind of question
we have every day at support.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUG6E3D3ZD7BTJMBE5ECKTTXRB4ZANCNFSM47WJKGMA>
.
|
Feyensv
added a commit
that referenced
this pull request
Aug 3, 2021
Feyensv
added a commit
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] Improving documentation navigation and structure
[IMP] CSS cleanup for usability (better TOC, better contrast, ...)
[IMP] Support for :show-toc: to display the TOC on pages having :show-content: