-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] Productivity: Discuss Getting Started rewrite #10580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @kekiss before I review this PR can you squash the two commits? (@Felicious can help if you have any questions). Thanks! |
91a503a to
a19ffb0
Compare
|
@jero-odoo Squashed, should be good to go now! |
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kekiss , great job on this rewrite! I had some edits for formatting and style, but the content is excellent. A few things to note:
On the images, we are trying to get away from using markups on images (the red outlines and arrows), so I would redo the images without those. If you want, you can use the "figure" formatting and add a caption instead, to add a bit of detail.
Also, there were a few lines that were under the 100 character limit (48-55). I would run make review and double check to make sure there are no early line breaks.
Please let me know if you have any questions or want to talk over any feedback. Thanks!
5b84d37 to
fb80c6f
Compare
|
@odoo/us-doc-review ready for final review! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kekiss -- pausing my Final Review at roughly the ~100 line mark. Nice job, but there seem to be a collection of adjustments that need to be made on this one. In addition to my feedback, there seem to be a handful of comments from JERO's Peer Review that were marked as resolved, but weren't implemented. No worries, though. That happens 😄 So, once you address those and my suggestions, tag me again for another look. Thanks!
6b5693e to
b69ca6a
Compare
|
Hey @ksc-odoo, I am taking this over from Kara. I believe I covered all of the changes you suggested and the ones she had previously missed. It should be ready for another look. Let me know if you have any questions. Thanks! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jero-odoo -- just gave this another look. Only have some small adjustments that are incredibly minor, and should just be a collection of "quick fixes." I do, however, have a question about this 'Configuration' menu that's supposed to be present on the 'Discuss' homepage. I was unable to locate this during my review, and any elaboration you could provide about that would be super helpful. Thanks!
3457677 to
7715f51
Compare
|
Hey @ksc-odoo ready for another look. Thanks! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jero-odoo -- just gave this another look. Left some comments that require your attention. Once you implement those, and feel like this is ready for another look, please tag me again. Thanks.
ec1f9ab to
e92d07d
Compare
|
@ksc-odoo this is ready for another look |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jero-odoo -- great work on these additions! awesome job! only a small handful of suggestions left that require your attention, but once those necessary changes are implemented, you can move this on to Tech Review.
8f52b53 to
2e7436c
Compare
|
Thanks KC! |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo! Thank you for picking up where @kekiss left off with this PR! I think these improvements to this doc are a great start. I have a handful of technical changes and suggestions for clarity, please see below!
A note for the future, I think the "Conversation actions" section could be expanded upon more with sub-sections for certain actions (i.e. "Voice Settings" and "Invite People").
I am requesting changes since I have a lot of suggestions, please tag me for one more look once you've had a chance to address these, thank you!
8b279a7 to
ef50117
Compare
|
@samueljlieber ready for another look, thank you |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my suggestions @jero-odoo, approving with one more that was missed. Thank you!
...
@robodoo delegate=jero-odoo
[FIX] Updates to Discuss doc for 17.0 Adding reviewer suggestions Added blank line at end of file Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
ef50117 to
bf5ad72
Compare
|
@robodoo r+ |
[FIX] Updates to Discuss doc for 17.0 Adding reviewer suggestions Added blank line at end of file closes #10580 Signed-off-by: Jessica Rogers (jero) <jero@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
[FIX] Updates to Discuss doc for 17.0 Adding reviewer suggestions Added blank line at end of file closes #10580 Signed-off-by: Jessica Rogers (jero) <jero@odoo.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>

Rewrote the Discuss doc to include more information and update it for 17.0