Skip to content

Conversation

@kekiss
Copy link
Contributor

@kekiss kekiss commented Aug 2, 2024

Rewrote the Discuss doc to include more information and update it for 17.0

@kekiss kekiss requested a review from jero-odoo August 2, 2024 19:09
@kekiss kekiss self-assigned this Aug 2, 2024
@robodoo
Copy link
Collaborator

robodoo commented Aug 2, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team August 2, 2024 19:11
@jero-odoo
Copy link
Contributor

Hi @kekiss before I review this PR can you squash the two commits? (@Felicious can help if you have any questions). Thanks!

@kekiss kekiss force-pushed the 17.0-discuss-update-for-17.0-kaek branch from 91a503a to a19ffb0 Compare August 7, 2024 19:05
@kekiss
Copy link
Contributor Author

kekiss commented Aug 7, 2024

@jero-odoo Squashed, should be good to go now!

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kekiss , great job on this rewrite! I had some edits for formatting and style, but the content is excellent. A few things to note:
On the images, we are trying to get away from using markups on images (the red outlines and arrows), so I would redo the images without those. If you want, you can use the "figure" formatting and add a caption instead, to add a bit of detail.
Also, there were a few lines that were under the 100 character limit (48-55). I would run make review and double check to make sure there are no early line breaks.
Please let me know if you have any questions or want to talk over any feedback. Thanks!

@kekiss kekiss force-pushed the 17.0-discuss-update-for-17.0-kaek branch 2 times, most recently from 5b84d37 to fb80c6f Compare August 19, 2024 23:57
@kekiss kekiss requested a review from a team August 20, 2024 00:17
@kekiss
Copy link
Contributor Author

kekiss commented Aug 20, 2024

@odoo/us-doc-review ready for final review!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kekiss -- pausing my Final Review at roughly the ~100 line mark. Nice job, but there seem to be a collection of adjustments that need to be made on this one. In addition to my feedback, there seem to be a handful of comments from JERO's Peer Review that were marked as resolved, but weren't implemented. No worries, though. That happens 😄 So, once you address those and my suggestions, tag me again for another look. Thanks!

@jero-odoo jero-odoo self-assigned this Oct 31, 2024
@jero-odoo jero-odoo added 17.0 3 2 and removed 3 labels Oct 31, 2024
@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from 6b5693e to b69ca6a Compare October 31, 2024 16:13
@jero-odoo
Copy link
Contributor

Hey @ksc-odoo, I am taking this over from Kara. I believe I covered all of the changes you suggested and the ones she had previously missed. It should be ready for another look. Let me know if you have any questions. Thanks!

@jero-odoo jero-odoo requested a review from ksc-odoo October 31, 2024 16:32
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- just gave this another look. Only have some small adjustments that are incredibly minor, and should just be a collection of "quick fixes." I do, however, have a question about this 'Configuration' menu that's supposed to be present on the 'Discuss' homepage. I was unable to locate this during my review, and any elaboration you could provide about that would be super helpful. Thanks!

@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from 3457677 to 7715f51 Compare November 8, 2024 19:49
@jero-odoo
Copy link
Contributor

Hey @ksc-odoo ready for another look. Thanks!

@jero-odoo jero-odoo requested a review from ksc-odoo November 8, 2024 20:04
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- just gave this another look. Left some comments that require your attention. Once you implement those, and feel like this is ready for another look, please tag me again. Thanks.

@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from ec1f9ab to e92d07d Compare November 15, 2024 21:03
@jero-odoo jero-odoo added 3 and removed 2 labels Nov 15, 2024
@jero-odoo jero-odoo requested a review from ksc-odoo November 15, 2024 21:21
@jero-odoo
Copy link
Contributor

@ksc-odoo this is ready for another look

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jero-odoo -- great work on these additions! awesome job! only a small handful of suggestions left that require your attention, but once those necessary changes are implemented, you can move this on to Tech Review.

@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from 8f52b53 to 2e7436c Compare November 18, 2024 17:19
@jero-odoo
Copy link
Contributor

Thanks KC!
@samueljlieber this is ready for tech review. Thanks!

@jero-odoo jero-odoo requested a review from a team November 18, 2024 17:35
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! Thank you for picking up where @kekiss left off with this PR! I think these improvements to this doc are a great start. I have a handful of technical changes and suggestions for clarity, please see below!

A note for the future, I think the "Conversation actions" section could be expanded upon more with sub-sections for certain actions (i.e. "Voice Settings" and "Invite People").

I am requesting changes since I have a lot of suggestions, please tag me for one more look once you've had a chance to address these, thank you!

@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from 8b279a7 to ef50117 Compare November 18, 2024 20:33
@jero-odoo
Copy link
Contributor

@samueljlieber ready for another look, thank you

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my suggestions @jero-odoo, approving with one more that was missed. Thank you!
...
@robodoo delegate=jero-odoo

[FIX] Updates to Discuss doc for 17.0

Adding reviewer suggestions

Added blank line at end of file

Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>

Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@jero-odoo jero-odoo force-pushed the 17.0-discuss-update-for-17.0-kaek branch from ef50117 to bf5ad72 Compare November 19, 2024 13:46
@jero-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 19, 2024
[FIX] Updates to Discuss doc for 17.0

Adding reviewer suggestions

Added blank line at end of file

closes #10580

Signed-off-by: Jessica Rogers (jero) <jero@odoo.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
robodoo pushed a commit that referenced this pull request Nov 19, 2024
[FIX] Updates to Discuss doc for 17.0

Adding reviewer suggestions

Added blank line at end of file

closes #10580

Signed-off-by: Jessica Rogers (jero) <jero@odoo.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@robodoo robodoo closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants