[FIX] Makefile: fix CSS compilation for multi-version/lang builds #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 547d90a allowed `BUILD_DIR` to be defined from the CLI but didn't update usages of `HTML_BUILD_DIR`. When building the documentation for multiple versions and/or languages, we should rely on `HTML_BUILD_DIR` to point to the appropriate directory.
AntoineVDV
added
the
technical improvement
Collaborator
Collaborator
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 3, 2021
Commit 547d90a allowed `BUILD_DIR` to be defined from the CLI but didn't update usages of `HTML_BUILD_DIR`. When building the documentation for multiple versions and/or languages, we should rely on `HTML_BUILD_DIR` to point to the appropriate directory. closes #1075 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 547d90a allowed
BUILD_DIRto be defined from the CLI but didn'tupdate usages of
HTML_BUILD_DIR. When building the documentation formultiple versions and/or languages, we should rely on
HTML_BUILD_DIRto point to the appropriate directory.