[FW][FIX] Makefile: avoid confusing // in build dir path #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When locally building the doc (aka make), CURRENT_LANG is not defined, which results in HTML_BUILD_DIR = _build/html//, resulting in commands & logs like the following mkdir -p _build/html//_static pysassc extensions/odoo_theme/static/style.scss _build/html//_static/style.css This has no impact on linux builds, but could be unclear/confusing for some non tech users (can it have any impact on other OS's/distros ?) X-original-commit: d8684e8
Collaborator
Collaborator
Author
|
Ping @Feyensv, @AntoineVDV
To merge the full chain, say
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 6, 2021
When locally building the doc (aka make), CURRENT_LANG is not defined, which results in HTML_BUILD_DIR = _build/html//, resulting in commands & logs like the following mkdir -p _build/html//_static pysassc extensions/odoo_theme/static/style.scss _build/html//_static/style.css This has no impact on linux builds, but could be unclear/confusing for some non tech users (can it have any impact on other OS's/distros ?) closes #1096 X-original-commit: d8684e8 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com> Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When locally building the doc (aka make), CURRENT_LANG is not defined,
which results in HTML_BUILD_DIR = _build/html//, resulting in commands
& logs like the following
mkdir -p _build/html//_static
pysassc extensions/odoo_theme/static/style.scss _build/html//_static/style.css
This has no impact on linux builds, but could be unclear/confusing for some non tech
users (can it have any impact on other OS's/distros ?)
Forward-Port-Of: #1093