[IMP] accounting: info about proforma label on invoices #11080
Conversation
|
|
afma-odoo
force-pushed
the
17.0-accounting-proforma-afma
branch
from
e1d917e to
5788496
Compare
|
Hello @afma-odoo ! Let me know if you are waiting for @dade-odoo's review first or if I can go ahead :) |
|
Hi @xpl-odoo ! Sure, you can go ahead! Thanks ;) |
xpl-odoo
requested review from
xpl-odoo
and removed request for
a team and
dade-odoo
dade-odoo
left a comment
dade-odoo
left a comment
There was a problem hiding this comment.
Hey @afma-odoo - great work on this doc. I know it was a big overhaul, and your new version is going to be a huge improvement!! That being said, I had a lot of notes because it's a big topic. Let me know if you have any questions and we can discuss them :)
afma-odoo
force-pushed
the
17.0-accounting-proforma-afma
branch
from
5788496 to
659845c
Compare
|
@dade-odoo Thanks a lot for the review and the advice! Don't hesitate to tell me if there are other things that need to be improved still ;) |
dade-odoo
left a comment
dade-odoo
left a comment
There was a problem hiding this comment.
Hey, thanks for the changes @afma-odoo ! I did make plenty of comments, but I'm going to go ahead and approve it so that you can move this forward while I'm out next week. I trust you to follow up on any changes I suggested or to find a better solution together with Audrey if you disagree with any of them. I'll let you request a final review from her once you think it's ready. Let me know if you have any questions and thanks again! This will be a great improvement :)
afma-odoo
force-pushed
the
17.0-accounting-proforma-afma
branch
from
659845c to
9856d5c
Compare
|
@dade-odoo Thanks for the review and the approval :) |
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Great job @afma-odoo, this is such huge improvement, I love it! Thank you (and thank you @dade-odoo for the review)! I just have a few comments/suggestions but nothing major 🙂
afma-odoo
force-pushed
the
17.0-accounting-proforma-afma
branch
from
9856d5c to
1c1e003
Compare
|
@auva-odoo Thanks for the review and suggestions ;) |
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Just one tiny comment; I could've done it myself but I didn't want to in case you decide to change the note on the Accounting and Invoicing page in this PR 🙂
I'm going to go ahead and approve this PR already and delegate r+ rights. So when you have made the changes and all the checks have passed, you can r+ it yourself 🙂
@robodoo delegate+
task-3938154 task-3416326 task-2466972
afma-odoo
force-pushed
the
17.0-accounting-proforma-afma
branch
from
1c1e003 to
5b0b2c3
Compare
|
@auva-odoo Thanks for the review! We did it 💪🎉 @robodoo r+ |
task-3938154 task-3416326 task-2466972 closes #11080 Signed-off-by: Anne-Françoise Marcq (afma) <afma@odoo.com>
5 participants
task-3938154
task-3416326
task-2466972