[IMP] send_quotations/pdf_quote_builder#11128
Conversation
|
|
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
LGTM off a quick look, @pabr-odoo can you confirm the functional details please so we can merge quickly?
pabr-odoo
left a comment
pabr-odoo
left a comment
There was a problem hiding this comment.
Hi @Demesmaeker I finished reviewing the functional details of this document and it looks great overall! I left a few suggestions for you to review but otherwise everything functions as it should. Thanks!
| .. example:: | ||
| When uploading a header PDF containing the form field :guilabel:`invoice_partner_country`, | ||
| configuring the :guilabel:`path` of the :guilabel:`Form Field Name` to | ||
| :guilabel:`partner_invoice_id.country_id.name` fills the form with the invoice partner country's | ||
| name when the PDF is built. | ||
|
|
||
| Once the upload(s) are complete, click :guilabel:`Save`. | ||
| .. example:: | ||
| When uploading a product PDF containing the form field :guilabel:`invoice_partner_country`, | ||
| configuring the :guilabel:`path` of the :guilabel:`Form Field Name` to | ||
| :guilabel:`order_id.partner_invoice_id.country_id.name` fills the form with the invoice partner | ||
| country's name when the PDF is built. |
There was a problem hiding this comment.
I believe these two examples are duplicates.
There was a problem hiding this comment.
The difference between these two is that one is a header document, whereas the other is a product document. I voluntarily used the same final information to point the different path, as the path is different for product or header/footer document.
I added some formatting to improve the readability/difference between the two.
Demesmaeker
force-pushed
the
18.0-slae_pdf_quote_builder_but_better-edm
branch
from
214eddf to
26a10c5
Compare
pabr-odoo
left a comment
pabr-odoo
left a comment
There was a problem hiding this comment.
Hi @Demesmaeker just gave this another look, and it looks great! I left one formatting suggestion and one UI label correction. After you take a look, feel free to merge this doc. Thanks for the great work!
Demesmaeker
force-pushed
the
18.0-slae_pdf_quote_builder_but_better-edm
branch
from
26a10c5 to
6a8fa1c
Compare
|
Hello @pabr-odoo |
Demesmaeker
force-pushed
the
18.0-slae_pdf_quote_builder_but_better-edm
branch
from
6a8fa1c to
e64128c
Compare
|
@robodoo r+ |
|
@robodoo r- |
Demesmaeker
force-pushed
the
18.0-slae_pdf_quote_builder_but_better-edm
branch
from
e64128c to
721eb51
Compare
|
@robodoo r+ |
Add documentation about the new features and possibilities of the PDF quote builder. Delete obsolote information.
Demesmaeker
force-pushed
the
18.0-slae_pdf_quote_builder_but_better-edm
branch
from
721eb51 to
0787e79
Compare
|
@robodoo r+ |
Add documentation about the new features and possibilities of the PDF quote builder. Delete obsolote information. closes #11128 Signed-off-by: Morgane Demesmaeker <edm@odoo.com>
5 participants
Add documentation about the new features and possibilities of the PDF quote builder. Delete obsolote information.