Skip to content

[FIX] accounting/l10n_mx: Updated Mexican modules list #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
raf-odoo wants to merge 1 commit into from
Closed

[FIX] accounting/l10n_mx: Updated Mexican modules list #1113

raf-odoo wants to merge 1 commit into from

Conversation

@raf-odoo
Copy link
Contributor

@raf-odoo raf-odoo commented Aug 25, 2021

Most of the modules in the optional module list don't exist in V14,
except for l10n_mx_edi_landing. I've opted to remove the entire list
as a result.

@raf-odoo
Copy link
Contributor Author

raf-odoo commented Aug 25, 2021

If you prefer I can keep the l10n_mx_edi_landing reference in.

@raf-odoo raf-odoo requested a review from vbe-odoo August 25, 2021 09:58
@robodoo
Copy link
Collaborator

robodoo commented Aug 25, 2021

Pull request status dashboard.

@raf-odoo raf-odoo mentioned this pull request Aug 25, 2021
Closed
@raf-odoo raf-odoo changed the title [REM] accounting/l10n_mx: Out of date Mexican module list [REM] accounting/l10n_mx: Out of date V14 Mexican module list Aug 25, 2021
vbe-odoo
vbe-odoo reviewed Aug 25, 2021
View reviewed changes
content/applications/finance/accounting/fiscal_localizations/localizations/mexico.rst Outdated
Copy link
Contributor

@vbe-odoo vbe-odoo Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raf-odoo we need to keep with this one.
Plus we need to add one extra module that is brand new, below see title and description:
#. | Odoo Mexican XML Polizas Export (l10n_mx_xml_polizas)
| With this module, you will be able to export your Journal Entries in XML ready to be uploaded to the SAT.

Copy link
Contributor Author

@raf-odoo raf-odoo Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've removed the reference to the customs module in its description.

@vbe-odoo
Copy link
Contributor

vbe-odoo commented Aug 25, 2021 •
edited
Loading

@raf-odoo I left a comment about the optional modules.
Can you also add a small addition to the following main modules (addition in bold):
2. EDI for Mexico (l10n_mx_edi & l10n_mx_edi_extended)
Necessary for electronic transactions, CFDI 3.3, payment complement, and addenda on invoices.
3. Odoo Mexican localization reports (l10n_mx_reports & l10n_mx_reports_closing)
All mandatory reports for electronic accounting. (Requires the accounting application).

Thanks

@raf-odoo
[FIX] accounting/l10n_mx: Updated Mexican modules list
6bcd132 
The list of Mexican accounting modules in the documentation was out of
date, with many of them no longer existing. Several new modules have
been added as well.
@raf-odoo raf-odoo force-pushed the 14.0-remove-nonexistent-mexican-modules-raf branch from 9ce105a to 6bcd132 Compare August 25, 2021 12:53
@raf-odoo raf-odoo changed the title [REM] accounting/l10n_mx: Out of date V14 Mexican module list [FIX] accounting/l10n_mx: Updated Mexican modules list Aug 25, 2021
@raf-odoo
Copy link
Contributor Author

raf-odoo commented Aug 25, 2021

@raf-odoo I left a comment about the optional modules.
Can you also add a small addition to the following main modules (addition in bold):
2. EDI for Mexico (l10n_mx_edi & l10n_mx_edi_extended)
Necessary for electronic transactions, CFDI 3.3, payment complement, and addenda on invoices.
3. Odoo Mexican localization reports (l10n_mx_reports & l10n_mx_reports_closing)
All mandatory reports for electronic accounting. (Requires the accounting application).

Thanks

Ok, I've added both.

vbe-odoo
vbe-odoo approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@vbe-odoo vbe-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raf-odoo Looks good to me. Ready to merge.
Thanks

@raf-odoo
Copy link
Contributor Author

raf-odoo commented Aug 25, 2021

@vbe-odoo Thanks for the feedback! :-). I'll close the issue as well.

@raf-odoo
Copy link
Contributor Author

raf-odoo commented Aug 25, 2021

@vbe-odoo I don't have merge rights, can you press the button, or should I ask somebody from the documentation team for that?

@vbe-odoo
Copy link
Contributor

vbe-odoo commented Aug 25, 2021

@raf-odoo unfortunately I don't have access rights to merge as well.
Can you ask the documentation team for that? thanks!

@raf-odoo
Copy link
Contributor Author

raf-odoo commented Aug 25, 2021

@odoo/doc-review

@AntoineVDV AntoineVDV requested a review from a team August 25, 2021 13:21
AntoineVDV
AntoineVDV approved these changes Aug 25, 2021
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@robodoo robodoo closed this in 5b42479 Aug 25, 2021
@fw-bot fw-bot mentioned this pull request Aug 25, 2021
Closed
@robodoo robodoo temporarily deployed to merge August 25, 2021 13:30 Inactive
@fw-bot fw-bot deleted the 14.0-remove-nonexistent-mexican-modules-raf branch September 8, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@vbe-odoo vbe-odoo vbe-odoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raf-odoo @robodoo @vbe-odoo @AntoineVDV