Skip to content

Conversation

@dama-odoo
Copy link
Contributor

@dama-odoo dama-odoo commented Aug 27, 2021

task-2504306

Enterprise PR: https://github.com/odoo/enterprise/pull/20265

@robodoo
Copy link
Collaborator

robodoo commented Aug 27, 2021

@jcs-odoo jcs-odoo added this to the 14.0 milestone Aug 27, 2021
@jcs-odoo
Copy link
Contributor

@odoo-dama
Oh, I forgot to add:

Change the commit message according to the description in commit_template.txt

For example:
[ADD] sales: eBay account deletion notifications

@dama-odoo dama-odoo changed the title [Connector/eBay] Initiate article How to subscribe to eBay marketplac… [Connector/eBay] Add deletion notifications page Aug 27, 2021
@dama-odoo dama-odoo force-pushed the 14.0-ebay_account_deletion_guideline branch 2 times, most recently from ee5431a to c119b55 Compare August 27, 2021 16:27
@dama-odoo
Copy link
Contributor Author

@jcs-odoo, thanks for the insights, really helpful !
I have followed your advices and applied necessary changes.

@dama-odoo dama-odoo requested a review from jcs-odoo August 30, 2021 06:51
@jcs-odoo jcs-odoo force-pushed the 14.0-ebay_account_deletion_guideline branch from fbe85b4 to 9de759c Compare August 31, 2021 09:33
@jcs-odoo jcs-odoo requested review from a team and Feyensv August 31, 2021 09:37
@jcs-odoo jcs-odoo force-pushed the 14.0-ebay_account_deletion_guideline branch from 1c682a0 to f3ab8c7 Compare September 1, 2021 13:47
@dama-odoo dama-odoo requested a review from AntoineVDV September 2, 2021 08:42
@jcs-odoo
Copy link
Contributor

jcs-odoo commented Sep 3, 2021

@odoo/doc-review
is it good to go? I know @odoo-dama wanted it online asap.
Thanks :)

@AntoineVDV
Copy link
Collaborator

We must wait until Monday to merge the PR.

@AntoineVDV AntoineVDV removed the request for review from Feyensv September 3, 2021 13:47
@AntoineVDV AntoineVDV force-pushed the 14.0-ebay_account_deletion_guideline branch from f3ab8c7 to 0a8a05d Compare September 6, 2021 09:35
@AntoineVDV AntoineVDV changed the base branch from 14.0 to 12.0 September 6, 2021 09:35
@AntoineVDV AntoineVDV modified the milestones: 14.0, 12.0 Sep 6, 2021
@AntoineVDV AntoineVDV changed the title [Connector/eBay] Add deletion notifications page [ADD] ebay: new doc for account deletion notifications Sep 6, 2021
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the enterprise PR to be merged.

@odoo-dama @jcs-odoo FYI I merged the new page into the page setup.rst since the subscription to account deletion notifications is now a mandatory step of the integration setup. I also re-targeted the PR to merge the doc in 12.0 rather than 14.0 since the enterprise PR will land in 12.0 too.

@AntoineVDV AntoineVDV force-pushed the 14.0-ebay_account_deletion_guideline branch from 0a8a05d to 61b786a Compare September 6, 2021 14:39
task-2504306

Co-authored-by: Antoine Vandevenne <anv@odoo.com>
@AntoineVDV AntoineVDV force-pushed the 14.0-ebay_account_deletion_guideline branch from 61b786a to 2390d11 Compare September 6, 2021 14:39
@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Sep 6, 2021

@odoo-dama I just noticed that we didn't mention the module to install. It's now done here.
cc @jcs-odoo At some point we should extract these instructions on a separate page ;)

@AntoineVDV
Copy link
Collaborator

@robodoo r+

robodoo pushed a commit that referenced this pull request Sep 6, 2021
task-2504306

closes #1115

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Co-authored-by: Antoine Vandevenne <anv@odoo.com>
@robodoo robodoo closed this Sep 6, 2021
@robodoo robodoo temporarily deployed to merge September 6, 2021 15:07 Inactive
@fw-bot fw-bot deleted the 14.0-ebay_account_deletion_guideline branch September 20, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants