[ADD] sales: gelato integration #12001

dinakdugar · 2025-02-07T23:40:08Z

WIP: Creating parent documentation for Gelato Integration in Odoo Sales

Task: https://www.odoo.com/odoo/my-tasks/4520482

robodoo · 2025-02-07T23:40:11Z

dinakdugar · 2025-02-08T00:50:21Z

Hi @Felicious this PR is ready for peer review, when you have a chance. Thanks!

Felicious

Thank you for your quick work pushing up with WIP PR Dina!

Since the feature isn't fully ready yet, I did a partial review (:

content/applications/sales/sales/gelato.rst

dinakdugar · 2025-02-10T20:38:48Z

Thanks for the quick turnaround and thoughtful suggestions, @Felicious! I implemented them as well as added a tip admonition under the Configuration section, passing this back to you for another look.

I checked the runbot today and Gelato is still not available as an installable app in Odoo, but once it is available I will run a more thorough check against the flow, as well as continue to build docs under the Gelato integration scope. Thank you!

Felicious

Hi @dikd-odoo

Great job compiling all this information on the integration! This is a pretty technical topic, and you’ve tackled a challenging area to document. I have a few suggestions to add more context, especially to help users understand why they need to configure APIs and webhooks and why setup is needed in both Gelato and Odoo. Expanding on how the integration works—like what happens behind the scenes when they communicate, which system fulfills the orders, and how data flows—could make the doc even clearer for users.

Let me know if you’d like to get clarification or talk through any of the technical details with me! It gets pretty gnarly, especially on the integration side. My DMs are open to support 😊

content/applications/sales/sales/gelato.rst

dinakdugar · 2025-02-13T02:22:45Z

Thanks for the thorough and helpful review, @Felicious! I've implemented the requested changes and suggestions, this PR is ready for another look.

Felicious

Getting close, @dikd-odoo !

I spotted a couple of RST errors and a few missed comments from the last review, so I’ve pointed them out. Let me know when you’ve made the updates, and I’ll be happy to take another look!

content/applications/sales/sales/gelato.rst

dinakdugar · 2025-02-13T18:46:59Z

Thank you for your patience on this doc review @Felicious! I had missed some of the comments you had left and appreciate you bringing them to my attention. Implemented the necessary changes as well as added subheaders to the API and webhook sections for better organization, this PR is ready for another look when you have time. Thanks again!

Felicious

Everything looks great now, @dikd-odoo !

Good job (: Approving with one minor fix

content/applications/sales/sales/gelato.rst

dinakdugar · 2025-02-13T19:17:42Z

Thank you @Felicious!

Hi @StraubCreative this PR is ready for final review, when you have a chance. Thank you!

StraubCreative

Hi @dikd-odoo , good work getting this doc filled out with all of the relevant technical details and within a structural flow that is intuitive. I think the instructions are clear and the supplemental context you've added along the way is both concise and useful. Well done.

My feedback for the PR mostly revolves around clarity. I think at certain times we can be more specific in the instructions. At other times I think changes in wording could be helpful to improve clarity of what is being said. Finally, there are some spots where the formatting struck me as either not being consistent, or there were specific suggestions added based on what's in our style guide(s).

Hope this helps! Once these are addressed, I think we can merge 🤙

content/applications/sales/sales/gelato.rst

dinakdugar · 2025-02-14T18:04:18Z

Hi @StraubCreative thank you for the feedback and super thoughtful review! Your suggestions made a lot of sense and really polished the doc; will also pocket them to keep in mind for future documentation. I've implemented these and your edits, this PR is ready for another look when you have a moment. Thank you again!

StraubCreative

Looks good @dikd-odoo, thanks for knocking out those edits quickly.
@samueljlieber on to you for merge 🤙

content/applications/sales/sales/gelato.rst

samueljlieber

Hi @dikd-odoo! Great work on this brand new documentation! Im excited to see this released :) I am approving with a small handful of technical changes and fixes, please see below. Also please make sure to fix this one too. Thank you for your work on this! 🚀
.....
@robodoo delegate=dikd-odoo

content/applications/sales/sales/gelato.rst

content/applications/sales/sales/gelato/gelato-settings.png

content/applications/sales/sales/gelato/gelato-company.png

content/applications/sales/sales/gelato.rst

edit image sizes edits Apply suggestions from FEKU review Co-authored-by: Felicia Kuan <feku@odoo.com> edits Apply suggestions from FEKU review Co-authored-by: Felicia Kuan <feku@odoo.com> edits Apply suggestions from FEKU review Co-authored-by: Felicia Kuan <feku@odoo.com> edits Update content/applications/sales/sales/gelato.rst Co-authored-by: Felicia Kuan <feku@odoo.com> edits Apply suggestions from ZST review Co-authored-by: Zachary Straub <zst@odoo.com> edits edits sales file Apply suggestions from SALI review Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Apply suggestions from SALI review2 Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> images Edits

dinakdugar · 2025-02-14T22:25:15Z

Thank you @samueljlieber for the super helpful review!

@robodoo r+

edit image sizes edits Apply suggestions from FEKU review edits Apply suggestions from FEKU review edits Apply suggestions from FEKU review edits Update content/applications/sales/sales/gelato.rst edits Apply suggestions from ZST review edits edits sales file Apply suggestions from SALI review Apply suggestions from SALI review2 images Edits closes #12001 Signed-off-by: Dina Klarisse Dugar (dikd) <dikd@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Zachary Straub <zst@odoo.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>

robodoo · 2025-02-15T01:14:28Z

@dikd-odoo staging failed: ci/runbot on fd8c12133749e6bb9366a755fda0781dea812a6c (view more at https://runbot.odoo.com/runbot/build/75104377)

dinakdugar · 2025-02-15T01:25:39Z

@robodoo retry

edit image sizes edits Apply suggestions from FEKU review edits Apply suggestions from FEKU review edits Apply suggestions from FEKU review edits Update content/applications/sales/sales/gelato.rst edits Apply suggestions from ZST review edits edits sales file Apply suggestions from SALI review Apply suggestions from SALI review2 images Edits closes #12001 Signed-off-by: Dina Klarisse Dugar (dikd) <dikd@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Zachary Straub <zst@odoo.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>

robodoo · 2025-02-15T01:55:05Z

@dikd-odoo staging failed: ci/runbot on 89854ba561c75bcfa38862864cd420e1a3382f63 (view more at https://runbot.odoo.com/runbot/build/75104583)

StraubCreative · 2025-02-15T02:00:28Z

@robodoo retry

AntoineVDV

Hello there 👋

The doc is looking good; just a few minor adjustments to make. See comments below 🙂

content/applications/sales/sales/gelato.rst

C3POdoo requested a review from a team February 7, 2025 23:40

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch 2 times, most recently from a279b3b to f96d00b Compare February 8, 2025 00:33

dinakdugar self-assigned this Feb 8, 2025

dinakdugar added 5 18.0 labels Feb 8, 2025

dinakdugar requested a review from Felicious February 8, 2025 00:50

Felicious reviewed Feb 8, 2025

View reviewed changes

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from 5f0ac69 to eda29e7 Compare February 10, 2025 19:38

Felicious requested changes Feb 12, 2025

View reviewed changes

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from 466262f to 9fc1d85 Compare February 13, 2025 02:06

dinakdugar requested a review from Felicious February 13, 2025 02:22

Felicious requested changes Feb 13, 2025

View reviewed changes

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from 5878e4b to 402174d Compare February 13, 2025 18:33

dinakdugar requested a review from Felicious February 13, 2025 18:47

Felicious approved these changes Feb 13, 2025

View reviewed changes

content/applications/sales/sales/gelato.rst Outdated Show resolved Hide resolved

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from e315655 to aed97b4 Compare February 13, 2025 19:17

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from aed97b4 to 5ce7e1a Compare February 14, 2025 00:31

StraubCreative self-requested a review February 14, 2025 01:51

StraubCreative requested changes Feb 14, 2025

View reviewed changes

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch 2 times, most recently from f973205 to eb2f43a Compare February 14, 2025 18:00

dinakdugar requested a review from StraubCreative February 14, 2025 18:04

StraubCreative approved these changes Feb 14, 2025

View reviewed changes

content/applications/sales/sales/gelato.rst Outdated Show resolved Hide resolved

StraubCreative requested a review from samueljlieber February 14, 2025 19:26

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from eb2f43a to 3be25e4 Compare February 14, 2025 20:12

samueljlieber approved these changes Feb 14, 2025

View reviewed changes

dinakdugar force-pushed the 18.0-sales-gelato-integration-dikd branch from bde7d5b to 3aae69c Compare February 14, 2025 22:11

robodoo closed this in c0dd6b7 Feb 15, 2025

robodoo temporarily deployed to merge February 15, 2025 03:22 Inactive

This was referenced Feb 15, 2025

[FW][ADD] sales: gelato integration #12089

Closed

[FW][ADD] sales: gelato integration #12090

Closed

[FW][ADD] sales: gelato integration #12095

Closed

AntoineVDV reviewed Feb 18, 2025

View reviewed changes

content/applications/sales/sales/gelato.rst Show resolved Hide resolved

content/applications/sales/sales/gelato.rst Show resolved Hide resolved

content/applications/sales/sales/gelato.rst Show resolved Hide resolved

content/applications/sales/sales/gelato.rst Show resolved Hide resolved

dinakdugar mentioned this pull request Feb 19, 2025

[IMP] sales: gelato feedback #12114

Closed

This was referenced Feb 20, 2025

[FW][IMP] sales: gelato feedback #12120

Closed

[FW][IMP] sales: gelato feedback #12122

Closed

[FW][IMP] sales: gelato feedback #12123

Closed

[ADD] sales: gelato integration #12001

[ADD] sales: gelato integration #12001

Uh oh!

Conversation

dinakdugar commented Feb 7, 2025

Uh oh!

robodoo commented Feb 7, 2025

Uh oh!

dinakdugar commented Feb 8, 2025

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dinakdugar commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dinakdugar commented Feb 13, 2025

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dinakdugar commented Feb 13, 2025

Uh oh!

Felicious left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dinakdugar commented Feb 13, 2025

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dinakdugar commented Feb 14, 2025

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

dinakdugar commented Feb 10, 2025 •

edited

Loading