[IMP] sales: gelato feedback #12114
Closed
[IMP] sales: gelato feedback #12114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dinakdugar
force-pushed
the
18.0-sales-gelato-dikd
branch
from
0c5ce5e to
cccdc8e
Compare
|
Hi @jero-odoo this PR is ready for peer review, when you have time. Thank you! |
jero-odoo
approved these changes
Feb 19, 2025
Apply suggestions from JERO review Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com> edits
dinakdugar
force-pushed
the
18.0-sales-gelato-dikd
branch
from
aa1b76c to
5fbbf4e
Compare
|
Thank you @jero-odoo for the super quick turnaround and helpful review! Hi @Felicious this is ready for final review, when you have time. Thank you! |
StraubCreative
requested review from
a team
and removed request for
Felicious
StraubCreative
approved these changes
Feb 19, 2025
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2025
Apply suggestions from JERO review edits closes #12114 Signed-off-by: Zachary Straub (zst) <zst@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2025
Apply suggestions from JERO review edits closes #12114 Signed-off-by: Zachary Straub (zst) <zst@odoo.com> Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing feedback from SME: #12001 (review)
Target: 18.0+
Task: https://www.odoo.com/odoo/project/3835/tasks/4590847