Skip to content

Conversation

@Demesmaeker
Copy link
Contributor

@Demesmaeker Demesmaeker commented Oct 27, 2021

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Oct 27, 2021

@Demesmaeker Demesmaeker changed the base branch from 15.0 to master October 27, 2021 09:47
@Demesmaeker Demesmaeker force-pushed the master-payment-webhooks-edm branch from 40d903f to 5c602e0 Compare October 27, 2021 10:00
@Demesmaeker Demesmaeker changed the base branch from master to 15.0 October 27, 2021 10:00
@chevalierv chevalierv changed the base branch from 15.0 to master October 27, 2021 10:04
@chevalierv chevalierv changed the base branch from master to 15.0 October 27, 2021 10:04
@Demesmaeker Demesmaeker force-pushed the master-payment-webhooks-edm branch from 5c602e0 to 76df27a Compare October 27, 2021 10:21
@Demesmaeker Demesmaeker changed the base branch from 15.0 to master October 27, 2021 10:22
@Demesmaeker Demesmaeker force-pushed the master-payment-webhooks-edm branch from 76df27a to 5d727a8 Compare October 27, 2021 10:27
@Demesmaeker Demesmaeker changed the base branch from master to 15.0 October 27, 2021 10:27
@AntoineVDV AntoineVDV marked this pull request as ready for review November 4, 2021 11:34
@AntoineVDV AntoineVDV force-pushed the master-payment-webhooks-edm branch from 5d727a8 to ef408e7 Compare November 4, 2021 12:21
@AntoineVDV AntoineVDV changed the title [add] payment_acquirers: add webhooks information [IMP] general/payment_acquirers: rename and swap some headings Nov 4, 2021
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV AntoineVDV force-pushed the master-payment-webhooks-edm branch from ef408e7 to b0379d8 Compare November 4, 2021 12:25
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Demesmaeker !

Thanks for the PR. We (the documentation training group) have a suggestion to improve your content.

Feel free to take it or leave it.


@AntoineVDV it seems that the r+ didn't work.

Comment on lines +46 to +48
From an accounting perspective, we can distinguish two types of payment acquirers: the payment
acquirers that are third-party services and require you to follow another accounting workflow, and
the payments that go directly on the bank account and follow the usual reconciliation workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure to understand but are you distinguishing payments acquirers such as PayPal that have their own "bank accounts" and you need to generate PayPal payslips, and direct payments?
The first one implies a movement between multiple accounts, and the other sends the money directly to the business' bank account.

Suggested change
From an accounting perspective, we can distinguish two types of payment acquirers: the payment
acquirers that are third-party services and require you to follow another accounting workflow, and
the payments that go directly on the bank account and follow the usual reconciliation workflow.
From an accounting perspective, we can distinguish two types of payment acquirers:
- **Direct payment methods:** the payments go directly on your accounts and follow the usual
reconciliation workflow (e.g., wire transfers and cash).
- **Third-party services:** the payments go to the provider until you transfer them to your bank
account (e.g., PayPal and Adyen).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's about it but it's really not clear as it is now. We should make another PR to clarify all of this soon. In the meanwhile, I'm merging this one because it only swaps content without modifying it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV
I beg to differ. My suggestion isn't the same.
previously "another accounting workflow" seemed a bit blurry, whereas "the payments go to the provider until you transfer them to your bank account" informs a lot more, imo.

@AntoineVDV
Copy link
Collaborator

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants