Skip to content

[IMP] general/payment_acquirers: rename and swap some headings #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[IMP] general/payment_acquirers: rename and swap some headings #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions content/applications/general/payment_acquirers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,31 +38,18 @@ trust.
or Odoo databases hosted elsewhere. Instead, Odoo apps use a unique reference number to the data
stored safely in the payment acquirers' systems.

.. _payment_acquirers/acquirers:
.. _payment_acquirers/supported_acquirers:

Payment acquirers
=================
Supported payment acquirers
===========================

From an accounting perspective, we can distinguish two types of payment acquirers: the payments that
go directly on the bank account and follow the usual reconciliation workflow, and the payment
acquirers that are third-party services and require you to follow another accounting workflow.
From an accounting perspective, we can distinguish two types of payment acquirers: the payment
acquirers that are third-party services and require you to follow another accounting workflow, and
the payments that go directly on the bank account and follow the usual reconciliation workflow.
Comment on lines +46 to +48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure to understand but are you distinguishing payments acquirers such as PayPal that have their own "bank accounts" and you need to generate PayPal payslips, and direct payments?
The first one implies a movement between multiple accounts, and the other sends the money directly to the business' bank account.

Suggested change
From an accounting perspective, we can distinguish two types of payment acquirers: the payment
acquirers that are third-party services and require you to follow another accounting workflow, and
the payments that go directly on the bank account and follow the usual reconciliation workflow.
From an accounting perspective, we can distinguish two types of payment acquirers:
- **Direct payment methods:** the payments go directly on your accounts and follow the usual
reconciliation workflow (e.g., wire transfers and cash).
- **Third-party services:** the payments go to the provider until you transfer them to your bank
account (e.g., PayPal and Adyen).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's about it but it's really not clear as it is now. We should make another PR to clarify all of this soon. In the meanwhile, I'm merging this one because it only swaps content without modifying it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV
I beg to differ. My suggestion isn't the same.
previously "another accounting workflow" seemed a bit blurry, whereas "the payments go to the provider until you transfer them to your bank account" informs a lot more, imo.


.. _payment_acquirers/bank_payments:

Bank payments
-------------

- | :doc:`Wire Transfer <payment_acquirers/wire_transfer>`
| When selected, Odoo displays your payment information with a payment reference. You have to
approve the payment manually once you have received it on your bank account.
- | SEPA Direct Debit
| Your customers can sign a SEPA Direct Debit mandate online and get their bank account charged
directly. :doc:`Click here <../finance/accounting/receivables/customer_payments/batch_sdd>` for
more information about this payment method.

.. _payment_acquirers/online_providers:
.. _payment_acquirers/online_acquirers:

Online payment providers
Online payment acquirers
------------------------

+-------------------------------+----------------------+------------+-----------------+-----------+
Expand Down Expand Up @@ -112,13 +99,27 @@ Online payment providers
added and configured on your Accounting app to do a bank reconciliation, which is an accounting
control process.

.. _payment_acquirers/bank_payments:

Bank payments
-------------

- | :doc:`Wire Transfer <payment_acquirers/wire_transfer>`
| When selected, Odoo displays your payment information with a payment reference. You have to
approve the payment manually once you have received it on your bank account.
- | SEPA Direct Debit
| Your customers can sign a SEPA Direct Debit mandate online and get their bank account charged
directly. :doc:`Click here <../finance/accounting/receivables/customer_payments/batch_sdd>` for
more information about this payment method.

.. _payment_acquirers/configuration:

Configuration
=============

Some of the features described in this section are available only with some payment acquirers. Refer
to :ref:`the table above <payment_acquirers/online_providers>` for more details.
.. note::
Each acquirer has its specific configuration flow, depending on :ref:`which feature is available
<payment_acquirers/online_acquirers>`.

.. _payment_acquirers/add_new:

Expand Down
2 changes: 1 addition & 1 deletion content/applications/general/payment_acquirers/ogone.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Checks for e-Commerce & Alias Gateway`, and retrieve **SHA Key IN**.
SHA Key OUT
~~~~~~~~~~~

In order to retrieve the API Key and the Client Key, log into your ogone account, go to
In order to retrieve the SHA Key OUT, log into your ogone account, go to
:menuselection:`Configuration --> Technical Information --> Transaction feedback --> All transaction
submission modes`, and get or generate your **API Key** and **Client Key**. Be careful to copy your
API key as you'll not be allowed to get it later without generating a new one.
Expand Down