Skip to content

Conversation

@StraubCreative
Copy link
Contributor

Overview
This PR updates the Spanish(ES) content inside legal/terms.

Files updated

  • enterprise_es.rst
  • partnership_es

New file

  • terms_of_sale_es.rst

Misc
Updated formatting for consistent line length in RST files.
Removed trailing white spaces between line breaks.

@StraubCreative StraubCreative added new content request Request for a new content translations Anything related to the translations of the documentation content improvement labels Jan 6, 2022
@robodoo
Copy link
Collaborator

robodoo commented Jan 6, 2022

@C3POdoo C3POdoo requested a review from a team January 6, 2022 21:18
@jcs-odoo
Copy link
Contributor

Hello @StraubCreative .

I believe this PR has the same purpose as this old PR #939 .
Cécile Collart asked me to keep that version as it was triple-quadruple checked already from a legal pov.

cc @odony

@jubodoo
Copy link
Contributor

jubodoo commented Jan 27, 2022

Hello @StraubCreative .

I believe this PR has the same purpose as this old PR #939 . Cécile Collart asked me to keep that version as it was triple-quadruple checked already from a legal pov.

cc @odony

The same purpose but it's been better updated (in theory). There's just a small issue about the company name I asked Zach to fix (translators put MX company name) I think this should be the correct one. The other one I think wasn't pushed because there were mistakes IIRC.

@jubodoo
Copy link
Contributor

jubodoo commented Jan 27, 2022

Oh and @jcs-odoo This one has also more content (term of sales & partnership) so we either need to add that separately or do something about it. & we need to forward port them to 15.

@jcs-odoo
Copy link
Contributor

IIRC

Hello @jubodoo and @StraubCreative !
Sorry, I didn't look into it in detail. Indeed, it also translates the partnership agreement and terms of sales :)

I see that #939 (with the Odoo Enterprise Agreement) has been merged, now. Olivier was simply too busy to review it before, as he told me last month. Nothing to do with the content itself, it seems.

If I understood correctly, these changes are version-related so it's already targeting 15.0 and not the versions before (which is correct).

So you'll have to rebase your branch and fix the conflicts first to be able to merge this pr and add the partnership agreement and the tos. (but probably not the enterprise agreement anymore, then)

Content-wise, I leave that to the legal and translation teams.
But maybe check with @odoo/legal and (cco) first? I'm afraid I can't help much more.

Cheers :)

@StraubCreative
Copy link
Contributor Author

StraubCreative commented Jan 27, 2022

So you'll have to rebase your branch and fix the conflicts first to be able to merge this pr and add the partnership agreement and the tos. (but probably not the enterprise agreement anymore, then)

Sweet 👍

Next steps when I rebase the branch, so I understand:

This way we backpack #939 into a fully updated version with all 3 legal docs for Spanish.

Will get on it as soon as I can. Thank you for your help @jcs-odoo ! 😎

cc: @jubodoo

@jubodoo
Copy link
Contributor

jubodoo commented Jan 27, 2022

Cheers :)

So we'll just rebase & use this for the 2 other ones I guess? (let's keep in mind these doc have no legal values but still the translators checked with the MX office lawyers, so I would assume they are correctly translated)

@StraubCreative
Copy link
Contributor Author

Closing this since it's been open for so long without resolution and we would need to edit more updated content instead of what's on the feature branch.

Can create new PR if necessary please advise if that's the case @jubodoo

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2022

I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands.

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new content request Request for a new content translations Anything related to the translations of the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants