Skip to content

Conversation

@erjer-odoo
Copy link
Contributor

Making the "Units of measure" doc current with version 19.0, as requested: https://www.odoo.com/odoo/project.task/5159803

@erjer-odoo erjer-odoo self-assigned this Oct 27, 2025
@robodoo
Copy link
Collaborator

robodoo commented Oct 27, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 27, 2025 16:26
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a strong first PR, @erjer-odoo !

The content is accurate and you've successfully created a PR by yourself, and I'm so proud! 😊

The comments I left in this review are honestly optional, kinda detailed, and subjective. They're coming from a place of worry that the newer users who are unfamiliar with terms like reference UoM and purchase UoM wouldn't really know what they mean. We can discuss in person or over discord what you think is the best way to make small tweaks in presentation so this doc is beginner-friendly (:

@erjer-odoo erjer-odoo force-pushed the 19.0-Inventory-bring-uom-current-erjer branch from cbb55a7 to 244b626 Compare October 27, 2025 23:23
@erjer-odoo
Copy link
Contributor Author

Updated the documentation with some of these comments; I ultimately decided against a list of definitions, because we clarify using the more specific wording @Felicious outlined above.

@erjer-odoo erjer-odoo requested a review from Felicious October 27, 2025 23:46
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big-picture content review (: Will do a detailed one tomorrow (:

After clicking :guilabel:`Replenish`, a replenish assistant box pops up. The purchase unit of
After clicking :guilabel:`Replenish`, a Product Replenish box pops up. The purchase unit of
measure can be manually edited in the :guilabel:`Quantity` field, if needed. Then, click
:guilabel:`Confirm` to create the |RFQ|.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but the quantity field adds another layer of complexity + use cases that is covered in this certification question

Image Image

@erjer-odoo erjer-odoo force-pushed the 19.0-Inventory-bring-uom-current-erjer branch from 244b626 to effd1b5 Compare October 30, 2025 22:25
@erjer-odoo
Copy link
Contributor Author

Updated document according to comments here and discussions in-person. Screenshots have been updated to all use the same product (Blue Fabric, inventoried in yards but purchased in meters) and make it more cohesive...felt like using batteries and then suddenly switching to a fabric example was a bit jarring.

@erjer-odoo erjer-odoo requested a review from Felicious October 30, 2025 22:28
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements from the previous iteration, @erjer-odoo !

I'm satisfied with the creating uom section, and I can tell that you've been gaining a much better understanding of UoMs :D

I think there's still more clarification we can do about where we can set inventory, sales, and purchase units of measure, so take a look at my inline comments (:

After learning more about the workflow, it's my opinion that customers need that sales workflow of assigning the uom on a quote more than previous versions, because it's more confusing to set up now in version 19 😢

Also, with how much these instructions need to be completely overhauled, let's increase the scope of this PR from 2 to 5. Be sure to update the label accordingly!

let me know if you have any questions about my comments through Discord! I'll help 😊

@erjer-odoo erjer-odoo force-pushed the 19.0-Inventory-bring-uom-current-erjer branch from effd1b5 to 1d6f330 Compare November 3, 2025 20:06
@erjer-odoo
Copy link
Contributor Author

Updated documentation with comments from @Felicious. Hopefully it's clearer now.

@erjer-odoo erjer-odoo added the 5 label Nov 3, 2025
@erjer-odoo erjer-odoo requested a review from Felicious November 3, 2025 20:07
@erjer-odoo erjer-odoo force-pushed the 19.0-Inventory-bring-uom-current-erjer branch from 1d6f330 to 5591fef Compare November 3, 2025 21:30
@erjer-odoo
Copy link
Contributor Author

Also updated with a couple of screenshots and line break fixes, as discussed in-person with @Felicious.

@erjer-odoo erjer-odoo requested a review from Felicious November 3, 2025 21:31
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate=erjer-odoo

@erjer-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants