-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IMP] Inventory: bring units of measure current #15039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a strong first PR, @erjer-odoo !
The content is accurate and you've successfully created a PR by yourself, and I'm so proud! 😊
The comments I left in this review are honestly optional, kinda detailed, and subjective. They're coming from a place of worry that the newer users who are unfamiliar with terms like reference UoM and purchase UoM wouldn't really know what they mean. We can discuss in person or over discord what you think is the best way to make small tweaks in presentation so this doc is beginner-friendly (:
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
cbb55a7 to
244b626
Compare
|
Updated the documentation with some of these comments; I ultimately decided against a list of definitions, because we clarify using the more specific wording @Felicious outlined above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big-picture content review (: Will do a detailed one tomorrow (:
content/applications/inventory_and_mrp/inventory/product_management/configure/uom/cost-uom.png
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Show resolved
Hide resolved
| After clicking :guilabel:`Replenish`, a replenish assistant box pops up. The purchase unit of | ||
| After clicking :guilabel:`Replenish`, a Product Replenish box pops up. The purchase unit of | ||
| measure can be manually edited in the :guilabel:`Quantity` field, if needed. Then, click | ||
| :guilabel:`Confirm` to create the |RFQ|. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
244b626 to
effd1b5
Compare
|
Updated document according to comments here and discussions in-person. Screenshots have been updated to all use the same product (Blue Fabric, inventoried in yards but purchased in meters) and make it more cohesive...felt like using batteries and then suddenly switching to a fabric example was a bit jarring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements from the previous iteration, @erjer-odoo !
I'm satisfied with the creating uom section, and I can tell that you've been gaining a much better understanding of UoMs :D
I think there's still more clarification we can do about where we can set inventory, sales, and purchase units of measure, so take a look at my inline comments (:
After learning more about the workflow, it's my opinion that customers need that sales workflow of assigning the uom on a quote more than previous versions, because it's more confusing to set up now in version 19 😢
Also, with how much these instructions need to be completely overhauled, let's increase the scope of this PR from 2 to 5. Be sure to update the label accordingly!
let me know if you have any questions about my comments through Discord! I'll help 😊
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
effd1b5 to
1d6f330
Compare
|
Updated documentation with comments from @Felicious. Hopefully it's clearer now. |
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/uom.rst
Outdated
Show resolved
Hide resolved
1d6f330 to
5591fef
Compare
|
Also updated with a couple of screenshots and line break fixes, as discussed in-person with @Felicious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate=erjer-odoo
|
@robodoo r+ |



Making the "Units of measure" doc current with version 19.0, as requested: https://www.odoo.com/odoo/project.task/5159803