-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] Inventory: Remove visibility days #15056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Felicious this is ready for review. Thanks! |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jero-odoo ! Thanks for removing the visibility days parts as instructed (:
However, since Visibility Days was removed in version 19 but its use case is now handled through the Horizon Days feature, please recreate the previous Visibility Days examples using Horizon Days instead, so readers still understand how to achieve the same result with the updated functionality!
After you're done writing that, I'd like to share your draft with the inventory PO so she can verify the behavior matches the workflow she designed (:
72fdd4d to
705cbd0
Compare
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right direction @jero-odoo ! But seems incomplete with some misalignment on our goal with this task -- to clarify:
- Visibility days ONLY looked ahead when there was a need to fulfill within the forecasted date. How about Horizon days? Can you verify it behave the same way?
- If so, can we update the images in the examples, as the POs found those helpful
In general, let's try to make sure images are also updated instead of removed unless there's a strong reason to since they're useful to readers. With screenshots also included it gives us both more confidence that we have the feature correctly documented
705cbd0 to
f80f343
Compare
|
@Felicious I believe I understand the issue, I was trying to directly replicate the example from visibility days with horizon days when in reality it is not the same. Instead, I tried to show how changing the horizon window impacts manual replenishment/reordering rules. Let me know if this is more what you had in mind. Thanks! |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @jero-odoo !
I aligned with the product expert and have been proven wrong that horizon days is not a 1:1 replacement of visibility days. I apologize for the confusion and unnecessary back and forth. I will, however, request that you replace the twenty and thirty day screenshots of the UI with a graphic depicting how the timeline is affected by deadlines and horizon dates. I believe it will be helpful for users to envision how horizon days affects deadlines.
Thank you for your patience!
@robodoo delegate+
...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst
Outdated
Show resolved
Hide resolved
...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst
Show resolved
Hide resolved
...plications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.rst
Show resolved
Hide resolved
f80f343 to
d744416
Compare
|
@robodoo r+ |

docs task: https://www.odoo.com/mail/view?model=project.task&res_id=5209555&access_token=ff359e2a-98f4-400f-9887-2050cae97183
"Visibility Days" were removed from 19. Removed references to the feature from the following docs:
https://www.odoo.com/documentation/19.0/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment/reordering_rules.html
https://www.odoo.com/documentation/19.0/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment/report.html
https://www.odoo.com/documentation/19.0/applications/inventory_and_mrp/inventory/warehouses_storage/replenishment/just_in_time.html