[IMP] rental: Updated for request signature GUI changes #15067
Conversation
meval1006
commented
Oct 30, 2025
meval1006
commented
- Updated Rental page to remove outdated information
- Included the recent removal of the Sign Document button to the Action icon menu option of Request signature
- Major changes to the Customer Signature section
- Global document change of Can be rented to Rental
- Updated screenshots
- Updated icon style and naming
- Minor changes to the Reservations section
|
|
There was a problem hiding this comment.
Almost there, @meval1006! There was a lot of content to go through, so I appreciate that you resisted fixing the small style issues and stayed focused on updating the document for the signature workflow!
I just had a few clarification questions about the signature workflow itself and I can see that you've had a much better grasp on the style compared to your first PR! Great improvements in less than a week 😊
After those quick fixes, this PR is ready for another review!
|
|
||
| In the :guilabel:`Rental` section, there are options to configure :guilabel:`Default Delay Costs` | ||
| and :guilabel:`Default Padding Time`. There is also the option to activate :guilabel:`Rental | ||
| Transfers` and :guilabel:`Digital Documents`. |
There was a problem hiding this comment.
Out of curiosity, do you know what happened to this Digital Documents button? Did they remove all support of digital documents, or does it happen automatically somehow? It's probably not important, but asking in case it is, and making sure there isn't a strange roundabout way to digitize documents 🤔
There was a problem hiding this comment.
The Digital Documents setting option is now automatic and doesn't need to be enabled. However, the user does need the Sign app installed.
| Odoo guides the customer through the signing process with clear, clickable indicators, and allows | ||
| them to create electronic signatures to quickly complete the form. |
There was a problem hiding this comment.
I feel like we can be more specific here, even if we're just really direct and short with it. Click the signature, then the :guilabel:Preview button .... and link to the Sign doc. I know their doc might already cover it, so we don't need to provide much context or images, but it's better to document the whole workflow from end-to-end, which includes the part that crosses over to another app!
meval1006
force-pushed
the
19.0-rental-request-signature-meval
branch
from
f3ccc87 to
c0342bb
Compare
There was a problem hiding this comment.
Everything looks good functionally, @meval1006 ! Great work on another PR 😊 😍
I found some really minor formatting and "line-too-long" things in this review, so after you fix those, this PR is ready!
P.S.: run both make fast and make review before your final push+merge so we catch everything!
@robodoo delegate+
| ============== | ||
|
|
||
| To adjust the rental pricing on a product, go to the :guilabel:`Products` page in the *Rental* app, | ||
| To adjust the rental pricing on a product, go to the :guilabel:`Products` page in the **Rental** app, |
| customer takes to return a rental. | ||
|
|
||
| There is also the option to set a :guilabel:`Security Time`, expressed in hours, to make the rental | ||
| Also, there is the option to set the :guilabel:`Reserve product` time, expressed in hours, to make the rental |
| Once the document has been signed and completed, click the :guilabel:`Validate & Send Completed | ||
| Document` button at the bottom of the document. | ||
|
|
||
| .. image:: rental/validate-send-doc-button.png |
There was a problem hiding this comment.
reminder that we no longer do the red markup, but it looks like it was added in before (: I don't think it's really urgent to trouble you to re-upload the pic! Just a gentle reminder for next time (:
meval1006
force-pushed
the
19.0-rental-request-signature-meval
branch
3 times, most recently
from
5f1f7ad to
7181556
Compare
meval1006
force-pushed
the
19.0-rental-request-signature-meval
branch
from
7181556 to
41096b0
Compare
|
@robodoo r+ |
