-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IMP] Inventory: bring packaging current #15068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your efforts so far, @erjer-odoo, but this PR doesn't seem like it's comprehensive yet
I liked the structure you used in the UoM doc, where sales and purchase packagings were covered in separate sections. Let’s apply that same structure in this PR too
Also, the current "Create packagings" heading doesn’t quite match the content. The section focuses on assigning an existing packaging, but doesn’t explain how to fill out the "Create Packagings" pop-up (from the product form) or the "New" packaging page (from the Units & Packagings menu).
I suggest splitting this into two sections:
- Creating a packaging, showing one method (either from the product form or the Units & Packagings page).
- Assigning a packaging: walk through linking an existing packaging to a product.
This will make the structure clearer and ensure both workflows are fully covered!
Also, can you confirm whether barcodes can still be assigned to packagings? It seems like you've removed a section defining it, but the Barcode smart button appears on the New packaging form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart to only include the screenshot of the order lines instead of the whole SO 🧠
content/applications/inventory_and_mrp/inventory/product_management/configure/packaging.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/packaging.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/packaging.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/product_management/configure/packaging.rst
Show resolved
Hide resolved
aa652e5 to
1b122dc
Compare
|
Updated with comments from @Felicious. Re-documented the Create Packagings box to help users understand the fields they need to complete. Barcode is in fact still supported for packagings, as verified in both runbot and a test db. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @erjer-odoo !
I had such a smol edit that's honestly optional! After you fix the broken links, this PR is ready to merge
@robodoo delegate+
| - :guilabel:`Quantity` (required): amount of product in the packaging. | ||
| - :guilabel:`Reference Unit` (required): measurement unit for quantifying the product. | ||
| - :guilabel:`Package Type`: package type used to set custom dimensions and limits. See | ||
| :ref:`package type <inventory/warehouses_storage/package-type>` to learn more about package types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :ref:`package type <inventory/warehouses_storage/package-type>` to learn more about package types. | |
| :ref:`package type <inventory/warehouses_storage/package-type>` to learn more. |

Bringing packaging current with version 19.0, according to this task: https://www.odoo.com/odoo/my-tasks/5159803
Obliterated section on routing for packaging, as this is done in a roundabout way now in 19.0. Everything else should be updated, though.