-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[ADD] Barcode: Add documentation around retrieving EPC codes #15433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @larm-odoo ! This PR is ready for review when you have a moment! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc @erjer-odoo - short and sweet! I just tried to expand it and make it a little more "beefier", so take what you want from my review and disregard the rest. Ping me when you're done and I'll take another quick look!
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Show resolved
Hide resolved
fc0e976 to
3bd6d74
Compare
|
Hi @larm-odoo ! I've made some of the changes you've requested, and the unresolved comments above contain a couple of minor objections I had to a couple of your suggestions. Happy to hear what you think when you've got time in the morning to look this over again! Feel free to ping me if you want to talk about it more -- I'm more than happy to hear anything you have to say! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Only one question - I assume the green arrows in the image is from the GS1 website/an image you found? Only mentioned since we typically do not use mark-ups (when we did, it was those red boxes/lines). I love the things you added - makes it more dynamic/beefier. And as for the style things- it's always OK to push back on things like that, we all have our own ways of doing things, so as l long as it follows the style guide (which it does) it's totally ok =) Lots of us add 'optional' things ot change, and if you want to ignore those optional things, feel free to. Approving!
content/applications/inventory_and_mrp/barcode/operations/retrieve_epcs.rst
Show resolved
Hide resolved
|
Hi @StraubCreative ! This PR has been reviewed and approved by @larm-odoo ...when you have a moment, could you please help me merge? Thanks! |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depending on how you want to handle the version-specific edits to micro-versions going up to master, either:
- 1 PR = 1 version
OR
- 1 PR = full FWP chain
- just run
[at]robodoo r+and make your edits on each FWP that opens + tag for another quick tech review. - Example of this. It's easier + faster imo but up to you or TL.
- just run
Lmk if you have any questions, delegating to you:
@robodoo delegate+
|
@erjer-odoo branch 'saas-18.1' is disabled, it can't be used as a forward port target. For your own safety I've ignored everything in your comment. |
|
@robodoo r+ |
closes #15433 Signed-off-by: Erin Jerison (erjer) <erjer@odoo.com>


Adding documentation around retrieving EPC codes.
This 18.0 PR can be FWP up to 18.1; will need to make changes to 18.1 branch for 18.1-specific documentation, then 18.2 and forward branches need to be updated to remove specific references to 18.1.