Skip to content

Conversation

@erjer-odoo
Copy link
Contributor

Adding documentation around retrieving EPC codes.

This 18.0 PR can be FWP up to 18.1; will need to make changes to 18.1 branch for 18.1-specific documentation, then 18.2 and forward branches need to be updated to remove specific references to 18.1.

@erjer-odoo erjer-odoo requested a review from larm-odoo November 24, 2025 17:29
@erjer-odoo erjer-odoo self-assigned this Nov 24, 2025
@erjer-odoo erjer-odoo added the 5 label Nov 24, 2025
@robodoo
Copy link
Collaborator

robodoo commented Nov 24, 2025

Pull request status dashboard

@erjer-odoo
Copy link
Contributor Author

Hey @larm-odoo ! This PR is ready for review when you have a moment!

@C3POdoo C3POdoo requested a review from a team November 24, 2025 17:32
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc @erjer-odoo - short and sweet! I just tried to expand it and make it a little more "beefier", so take what you want from my review and disregard the rest. Ping me when you're done and I'll take another quick look!

@erjer-odoo erjer-odoo force-pushed the 18.0-barcode-retrieve-epcs-erjer branch from fc0e976 to 3bd6d74 Compare November 24, 2025 23:57
@erjer-odoo erjer-odoo requested a review from larm-odoo November 24, 2025 23:57
@erjer-odoo
Copy link
Contributor Author

Hi @larm-odoo ! I've made some of the changes you've requested, and the unresolved comments above contain a couple of minor objections I had to a couple of your suggestions. Happy to hear what you think when you've got time in the morning to look this over again! Feel free to ping me if you want to talk about it more -- I'm more than happy to hear anything you have to say!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Only one question - I assume the green arrows in the image is from the GS1 website/an image you found? Only mentioned since we typically do not use mark-ups (when we did, it was those red boxes/lines). I love the things you added - makes it more dynamic/beefier. And as for the style things- it's always OK to push back on things like that, we all have our own ways of doing things, so as l long as it follows the style guide (which it does) it's totally ok =) Lots of us add 'optional' things ot change, and if you want to ignore those optional things, feel free to. Approving!

@erjer-odoo
Copy link
Contributor Author

Hi @StraubCreative ! This PR has been reviewed and approved by @larm-odoo ...when you have a moment, could you please help me merge? Thanks!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Depending on how you want to handle the version-specific edits to micro-versions going up to master, either:

  • 1 PR = 1 version
    • Do [at]robodoo up to branch-name
    • Then underneath that line do [at]robodoo r+, like this:
    • Image
    • And after merge, open another PR for the next micro-version (e.g. targeting saas-18.2)

OR

  • 1 PR = full FWP chain
    • just run [at]robodoo r+ and make your edits on each FWP that opens + tag for another quick tech review.
    • Example of this. It's easier + faster imo but up to you or TL.

Lmk if you have any questions, delegating to you:
@robodoo delegate+

@erjer-odoo
Copy link
Contributor Author

@robodoo up to saas-18.1
@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Nov 26, 2025

@erjer-odoo branch 'saas-18.1' is disabled, it can't be used as a forward port target.

For your own safety I've ignored everything in your comment.

@erjer-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants