-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[IMP] Inventory: Updating Landed Costs to be current with 19.0 #15453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @jero-odoo ! This PR is ready for review when you have a moment. Thank you! |
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @erjer-odoo , looks good! Just a few quick notes, otherwise this is ready for the next round
content/applications/inventory_and_mrp/inventory/inventory_valuation/landed_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/inventory_valuation/landed_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/inventory_valuation/landed_costs.rst
Outdated
Show resolved
Hide resolved
2b4bc23 to
35ccfd7
Compare
|
Hi @StraubCreative ! Jess has approved this PR. Could you help me merge when you get a moment? Thank you! |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Please minimally fix the early line break and merge when you're ready and the checks pass.
..
@robodoo delegate+
content/applications/inventory_and_mrp/inventory/inventory_valuation/landed_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/inventory_valuation/landed_costs.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com> Co-authored-by: Zachary Straub <5496809+StraubCreative@users.noreply.github.com>
532d6f3 to
6fab452
Compare
|
@robodoo r+ |

Updating "Landed Costs" documentation to be current with 19.0. There are some minor changes with 19.0 that were discovered when working on the Landed Costs tutorial, and I wanted to make sure this documentation is current.
This 19.0 PR can be FWP up to master.