Skip to content

Conversation

@meval1006
Copy link
Contributor

  • Updated the downloadable quotations template for the Import one2many relationships section of the Export and import data page.
  • Did a few line break edits.

Project task: https://www.odoo.com/odoo/action-4043/4269068

This 16.0 PR can be FWP up to master.

@meval1006 meval1006 requested a review from larm-odoo November 25, 2025 22:00
@meval1006 meval1006 self-assigned this Nov 25, 2025
@robodoo
Copy link
Collaborator

robodoo commented Nov 25, 2025

Pull request status dashboard

@meval1006
Copy link
Contributor Author

@larm-odoo This PR is ready to review. Thank you.

@C3POdoo C3POdoo requested a review from a team November 25, 2025 22:02
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006 - I haven't checked a 16 doc in FOREVER! =) Since we had a different style guide at the time, i didn't want to markup all the hcanges that would be required for our current docs. BUT if you wanted, I do see that there are a lot of icons that are just cut and pasted icons instead of our new "icon"fa-.....' :guilabel:(icon name)` format. You could do those if you want, but again, this is an old doc, so unneccessary. Everything I suggested is optional so feel free to pass this on after you take a look! And great job ^_^ Also, just a small note - since the [IMP] is at the beginning, you don't have to aslo write "Updated" in the heading/title, since that's implied (Just like you don't need to add 'New..
in an [ADD] doc. So it could be shortened to "[IMP] Export: Quotations template for order lines".

@meval1006 meval1006 force-pushed the 16.0-essentials-export-template-meval branch from a0d5dae to 4a59ee1 Compare November 26, 2025 18:09
@meval1006
Copy link
Contributor Author

@StraubCreative Hi Zac, this is ready to merge. Thank you.

@meval1006 meval1006 added 2 3 and removed 2 labels Nov 26, 2025
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006
A few questions for you, and an icon isn't rendering correctly.
Can you take a look? 🙏

@meval1006 meval1006 force-pushed the 16.0-essentials-export-template-meval branch 2 times, most recently from cbc42be to d53f7dc Compare December 1, 2025 19:31
@meval1006
Copy link
Contributor Author

Hi @StraubCreative, this is ready to merge now. I have verified the columns for the quotation template.

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006

Please minimally fix the early line-break on line 376, and then you can merge when you're ready (as long as the CI checks pass ✅ ).

I have a note for your consideration regarding UI icons and their fallback labels as well.

Thank you for updating this doc and the diligence around the contents of the csv files.
...
@robodoo delegate+

@meval1006 meval1006 force-pushed the 16.0-essentials-export-template-meval branch from 9a680c3 to 5c9836f Compare December 1, 2025 21:37
@meval1006
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants