-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[IMP] Export: Updated quotations template for order lines #15458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@larm-odoo This PR is ready to review. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @meval1006 - I haven't checked a 16 doc in FOREVER! =) Since we had a different style guide at the time, i didn't want to markup all the hcanges that would be required for our current docs. BUT if you wanted, I do see that there are a lot of icons that are just cut and pasted icons instead of our new "icon"fa-.....' :guilabel:(icon name)` format. You could do those if you want, but again, this is an old doc, so unneccessary. Everything I suggested is optional so feel free to pass this on after you take a look! And great job ^_^ Also, just a small note - since the [IMP] is at the beginning, you don't have to aslo write "Updated" in the heading/title, since that's implied (Just like you don't need to add 'New..
in an [ADD] doc. So it could be shortened to "[IMP] Export: Quotations template for order lines".
a0d5dae to
4a59ee1
Compare
|
@StraubCreative Hi Zac, this is ready to merge. Thank you. |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @meval1006
A few questions for you, and an icon isn't rendering correctly.
Can you take a look? 🙏
content/applications/essentials/export_import_data/o2m_quotations_order_lines.csv
Outdated
Show resolved
Hide resolved
cbc42be to
d53f7dc
Compare
|
Hi @StraubCreative, this is ready to merge now. I have verified the columns for the quotation template. |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @meval1006
Please minimally fix the early line-break on line 376, and then you can merge when you're ready (as long as the CI checks pass ✅ ).
I have a note for your consideration regarding UI icons and their fallback labels as well.
Thank you for updating this doc and the diligence around the contents of the csv files.
...
@robodoo delegate+
9a680c3 to
5c9836f
Compare
|
@robodoo r+ |
closes #15458 Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com>

Project task: https://www.odoo.com/odoo/action-4043/4269068
This 16.0 PR can be FWP up to master.