Skip to content

Conversation

@meval1006
Copy link
Contributor

Added a new page under the Rental app documentation.

  • Added the service products page
  • How to create a service product
  • Standard workflow for a rental order with a service product

@meval1006 meval1006 self-assigned this Dec 3, 2025
@meval1006 meval1006 added the 5 label Dec 3, 2025
@robodoo
Copy link
Collaborator

robodoo commented Dec 3, 2025

Pull request status dashboard

@meval1006 meval1006 force-pushed the 19.0-rental-service-products-meval branch 3 times, most recently from 433fb9d to c36ec27 Compare December 5, 2025 17:58
@meval1006 meval1006 marked this pull request as ready for review December 5, 2025 17:59
@meval1006 meval1006 requested a review from jero-odoo December 5, 2025 17:59
@C3POdoo C3POdoo requested a review from a team December 5, 2025 18:01
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006, nice work on this one! This was a big doc to pull together with all the apps it integrates, very impressive! Also, nice job with the use case 👍
I left some comments, let me know if you have any questions, and let me know when you want me to take another look. Thanks!

@meval1006 meval1006 force-pushed the 19.0-rental-service-products-meval branch from c0d3943 to a681287 Compare December 5, 2025 23:58
@meval1006 meval1006 requested a review from jero-odoo December 5, 2025 23:58
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006 ! Nice work on these updates! Still had a few things to change (mostly small).
Also, when you are committing the changes, are you adding them to a batch or committing them individually? Both will work, but if you add them to a batch, you only have to do a single commit, which makes it easier when you are squashing.
(It looks like you didn't have an issues squashing the changes this time so if that works for you by all means! Just wanted to make sure you knew this was an option. Let me know if you want to do a screen share to go over it!)
image

@meval1006 meval1006 force-pushed the 19.0-rental-service-products-meval branch from 1cc8279 to 3e084fa Compare December 8, 2025 22:46
@meval1006 meval1006 requested a review from jero-odoo December 8, 2025 23:38
@meval1006
Copy link
Contributor Author

@jero-odoo Hopefully final review for approval. Thank you for catching all my typos. It's embarrassing how many there are without the linter to help me identify them.

Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006 just the one note (and this is my fault for not catching it last time! sorry about that!)
Great work! And I understand, personally I think the courier font in VS code makes it harder to find typos :)
This is ready for final/tech review!

@meval1006 meval1006 force-pushed the 19.0-rental-service-products-meval branch from cd5707c to 7eca92c Compare December 9, 2025 17:53
@meval1006 meval1006 requested a review from Felicious December 9, 2025 17:53
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work with this PR, @meval1006 !

You took a previously undocumented workflow and built clear, end-to-end guidance for integrating four apps. I especially liked how you called out the key steps in Sign and Pickup & Returns—service products follow a different path than physical goods, and your emphasis makes that distinction easy to follow. This doc is going to be genuinely helpful for customers. 😊

In my review, I’ve included a few style suggestions. Some are purely optional and reflect personal preference rather than the team style guide, so feel free to ignore those if they don’t match your vision. I’ve labeled which ones are optional.

Thanks as well for being so thorough in validating details with the SME. That level of accuracy makes the doc stronger and lets me focus my feedback on readability and beginner-friendliness.

@robodoo delegate+

@meval1006 meval1006 force-pushed the 19.0-rental-service-products-meval branch from cd29fec to 4e6f7f3 Compare December 10, 2025 22:21
@meval1006
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants