[IMP] Sales: Optional product page rewrite #15588
Open
+44
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Contributor
Author
|
jk, @erjer-odoo can you actually review this ahead of @Felicious? I've heard that we're starting the round-robin peer review process at this time. Thank you! |
erjer-odoo
approved these changes
Dec 8, 2025
Contributor
erjer-odoo
left a comment
erjer-odoo
left a comment
There was a problem hiding this comment.
Hi @theRealThagomizer ! This looks great! I did notice one typo, but this is otherwise good to go, I think! Approving, and after you fix the typo and checks pass, you should be able to pass this along to merge.
| Additional products can also be added to a core product by clicking :guilabel:`Search more...`. This | ||
| opens the :guilabel:`Search: Optional Products` form, which displays all products in the catalog and | ||
| includes the :guilabel:`New` button to create a new product. Multiple products may be selected as | ||
| optional prodcuts at once when using this form by clicking their checkboxes and then clicking |
Contributor
There was a problem hiding this comment.
Suggested change
| optional prodcuts at once when using this form by clicking their checkboxes and then clicking | |
| optional products at once when using this form by clicking their checkboxes and then clicking |
Co-authored-by: Erin Jerison <erjer@odoo.com>
theRealThagomizer
force-pushed
the
19.0-sales-optional-products-update-thjud
branch
from
9398189 to
814c96e
Compare
Contributor
Author
|
Thanks, @erjer-odoo! @Felicious, this is ready for your review to see if it's ready to be merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Felicia! This PR was created to resolve this task: https://www.odoo.com/odoo/action-4043/5226235. The original lift was simply to update the document from 18.0 -> 19.0, but after review, I decided the functionality had changed enough that the document needed to be wholly rewritten. I also replaced all of the photos with the modern UI and some screenshots of the quotations and eCommerce experiences so that readers can see what Optional Products actually look like on the customer's end.
This 19.0 PR can be FWP up to master.