-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] Contacts: Update address types #15595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
@larm-odoo this is ready for review. Thanks! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo - great updates, just a few notes. First, I saw a bunch of app references not in bold (from the original version) so I would update all of those. The other thing is, I noticed a lot of different/additional fields on a few different runbots. I assume this is due ot localizatoin packages- fiscal and just selecting the country for the database. I would recommend explaining/calling out all the truly universal fields (unrelated to localizations) and have an admonition mentioning additional fields will be visible depending on the localiation - then you can link ot the fiscal localizaiton section. This way, this doc explains all the default fields, and none of the specific ones. This only caught my attention when the Tax ID field and 1099 field were mentioned- which didn't appear in my runbot field, and then I realized those are US related fields. That's the only major issue I saw. Approving now because I know you got this!
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
793ec85 to
6ad4019
Compare
|
@Felicious this is ready for review. Thanks! |

Docs task:https://www.odoo.com/odoo/project.task/5347418
Updating Contacts doc to reflect 18 UI changes and content guidelines
Specifically, section on address types and create new contact form