-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] Inventory: Bringing least packages current #15753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: saas-18.3
Are you sure you want to change the base?
Conversation
|
Hi @larm-odoo ! I'm finishing up work on the removal strategies docs. This update brings it current, as well as consistent with the other removal strategies docs that I worked on last week. When you get a moment, can you review and let me know what you think? Thank you! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erjer-odoo - great explanation for this. Most of my suggestions are just that, suggestions, so take what you want and toss the rest. My only concern was the last part, in the image with the flour, I can't see how the user would know that the 100kg bag was used. So I would add something else to show how that is verified. Tag me again for a quick look when you're done!
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Show resolved
Hide resolved
e42019a to
bcbbd7c
Compare
|
Hi @larm-odoo -- I've updated with your comments. Would you be willing to take another look for me? Thank you! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME job on the edits, @erjer-odoo! I just eft optional comments- nothing major, so I am approving. i did leave a comment ON an image instead of in the file, so just be sure to take a look there. Nicely done!
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Outdated
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Show resolved
Hide resolved
...cations/inventory_and_mrp/inventory/shipping_receiving/removal_strategies/least_packages.rst
Show resolved
Hide resolved
...nd_mrp/inventory/shipping_receiving/removal_strategies/least_packages/on-hand-quantities.png
Show resolved
Hide resolved
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
f3f8a2f to
e1df946
Compare
|
Hi @Felicious -- I've addressed the concerns raised by @larm-odoo, and she's approved what's there. When you have a moment, could you take a look? If you also approve, could you help me merge? Thank you! |

While working on the removal strategies overview script, I realized that the documentation for "Least packages removal" was out of date. In this PR, I did the following:
All of this work makes the last of the removal strategies docs consistent with the other removal strategies docs.
This saas-18.3 PR can be FWP up to master.