-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[IMP] update Mercado Pago 19.0 #16003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1dbc38e to
2028dfb
Compare
|
Hello @auva-odoo, Here are the resources I used for this PR:
Thanks beforehand for your review 😄 |
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this doc @emmi-odoo, it already looks much better! 🤗 In addition to the comments and questions in my review, here are some more general comments:
-
Could you please change the anchors to pos/mercado_pago/[anchor-name]? (so it has the same format as the anchors in our other files). Sorry for bothering you with this!
-
I know we've talked about a similar case in the past and decided against it, but in this case, I would consider splitting the big numbered list into two sub-sections: one for connecting your Mercado Pago account to the terminal and your store and another one about creating the Point Smart application and generating/getting the credentials
Thank you and don't hesitate if you have any questions!
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
| #. Click :guilabel:`Soy responsable del negocio` to get a pairing QR code. | ||
| #. Use a mobile device connected to your Mercado Pago account to scan the QR code and complete the | ||
| connection. | ||
| #. Ensure the terminal is correctly linked to your store in the Mercado Pago app: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand "where" we are now? and what do you mean by app here exactly? (this is even more confusing to me since you use application on line 52, which I know is the name used in the Mercado Pago dashboard)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you scan the QR code, it takes you to the Mercado Pago website (and you should already be logged in). In this case, the Mercado Pago App is the website. But I'm not convinced of the updated sentence, let me know 😄
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
2028dfb to
90ae2c7
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @emmi-odoo! I added a few more comments/suggestions 🙂
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/point_of_sale/payment_methods/terminals/mercado_pago.rst
Outdated
Show resolved
Hide resolved
90ae2c7 to
02cb152
Compare
task-3950528
02cb152 to
7407e53
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @emmi-odoo for the changes and sorry again for the misunderstanding! You can r+ once the checked have passed 🙂
@robodoo delegate+
|
@robodoo r+ |

task-3950528