[FIX] saudi_arabia: add warning about company name length #16218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Collaborator
Author
|
@viso-odoo @auva-odoo cherrypicking of pull request #16196 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
viso-odoo
force-pushed
the
19.0-17.0-enforce-company-name-length-zatca-viso-495257-fw
branch
2 times, most recently
from
496dc7e to
d96092a
Compare
We have had lots of tickets recently about failed ZATCA onboarding. One of the most common reasons is that the company or branch name is too long compared to the strict limits imposed by zatca. As for the limits, they are technical, imposed by the QR code generated for every invoice. The limit itself is 127 bytes, which depending on the exact arabic characters used can range from 42 to 63 arabic characters. 63 is in the best-case scenario where we can encode all characters on 2 bytes. 42 characters is the worst-case scenario where special characters requiring 3 bytes are used. In an effort to keep our documentation concise and clear, we chose to stick to the best-case scenario of 63 characters, assuming that would be the most common scenario. Pull requests have been made in the main codebase to make the error messages clearer upon failed onboarding, which should cover the "42 characters edge cases". X-original-commit: 44040b9
viso-odoo
force-pushed
the
19.0-17.0-enforce-company-name-length-zatca-viso-495257-fw
branch
from
d96092a to
467e1f9
Compare
Contributor
|
@auva-odoo since the doc page changed, i had to adapt a bit the modif. Could you check if it makes sense or not before i merge? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had lots of tickets recently about failed ZATCA onboarding. One of the most common reasons is that the company or branch name is too long compared to the strict limits imposed by zatca.
As for the limits, they are technical, imposed by the QR code generated for every invoice.
The limit itself is 127 bytes, which depending on the exact arabic characters used can range from 42 to 63 arabic characters. 63 is in the best-case scenario where we can encode all characters on 2 bytes.
42 characters is the worst-case scenario where special characters requiring 3 bytes are used.
In an effort to keep our documentation concise and clear, we chose to stick to the best-case scenario of 63 characters, assuming that would be the most common scenario.
Pull requests have been made in the main codebase to make the error messages clearer upon failed onboarding, which should cover the "42 characters edge cases".
Forward-Port-Of: #16196