[IMP] spreadsheet: global filters - two new types + general update

[mcsi-odoo]

task-5881742

[robodoo]

[xpl-odoo]

Thanks for the update to add the new filter types and the clear explanation about a not-so-clear mechanism (since they don't work like your typical filter) :)

[xpl-odoo]

Maybe explain what are the different operators in a tip?
I think the "is in" is especially confusing 😅

[mcsi-odoo]

Indeed, is in and is not in are not really self-explanatory!

I understand your point about explaining the different operators, but I have some questions:

• would it make more sense to have such explanations on this page about custom filters?
• from what I can tell, these are all the operators you can have when applying global filters (different ones available depending on field type)

Is in
Is not in
Contains
Does not contain
Is set
Is not set
Starts with
Is equal to
Is not equal to
Greater than
Lower than
Between

... and then in custom filters, these are available for dates:

Before
After

Many of these are self-explanatory ... so I'm not sure how I'd tackle explaning them all.

Would be good to discuss this with you.

[mcsi-odoo]

Thanks for your review, Xavier!

I've replied to some comments here, and started to update the PR ... but I'd appreciate discussing some points in more detail (like using a gif, how to illustrate the various types of global filter, explaining conditional operators, etc.) before going further. I'll check in with you after your time off to set up a short meeting.

[mcsi-odoo]

Indeed, is in and is not in are not really self-explanatory!

I understand your point about explaining the different operators, but I have some questions:

• would it make more sense to have such explanations on this page about custom filters?
• from what I can tell, these are all the operators you can have when applying global filters (different ones available depending on field type)

Is in
Is not in
Contains
Does not contain
Is set
Is not set
Starts with
Is equal to
Is not equal to
Greater than
Lower than
Between

... and then in custom filters, these are available for dates:

Before
After

Many of these are self-explanatory ... so I'm not sure how I'd tackle explaning them all.

Would be good to discuss this with you.

[mcsi-odoo]

Hi @xpl-odoo, the main changes in this version are:

• use of a gif in the intro section
• 'matches with' changed to 'matches against', which I feel is more commonly used
• some wording changes in the examples of each type of global filter
• better consistency in use of literal, italics, guilabel, etc. ... I hope!

[xpl-odoo]

Thanks for addressing my suggestions! The GIF works really well, it's worth having it. You can r+ whenever :)

@robodoo delegate+

[mcsi-odoo]

@robodoo r+