Skip to content

Conversation

@ray-odoo
Copy link
Contributor

User tripped up due to the creation of a second warehouse enabling Storage Locations and changing the workflow.

https://www.odoo.com/forum/help-1/inventory-receipt-in-second-warehouse-199962

User tripped up due to the creation of a second warehouse enabling Storage Locations and changing the workflow.

https://www.odoo.com/forum/help-1/inventory-receipt-in-second-warehouse-199962
@robodoo
Copy link
Collaborator

robodoo commented Feb 25, 2022

@C3POdoo C3POdoo requested a review from a team February 25, 2022 21:53
@ray-odoo ray-odoo requested a review from jcs-odoo March 9, 2022 22:36
@ray-odoo
Copy link
Contributor Author

ray-odoo commented Mar 9, 2022

@jcs-odoo what's the process here to get this reviewed? Do I just add you as a reviewer? Someone else? zst told me he wasn't supposed to be in the Inventory Doc Review group and he was the only member when that group was added as a reviewer.

Also, how are you? Taking care of things at the farms?

Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ray!

I'm doing well, thanks! What about you?

Usually, people who aren't in the team of reviewers anymore should 1) add the new responsible 2) leave the team. We can't edit teams in which we are not, so I can't update it for everyone.
I'll see with Martin, who has more access rights, if he can update these teams just once to have a fresh start, and I'll send an email to all writers to explain the process :)

Anyway, bookmark this doc that maps each app with its responsible (content is in the last column). Here you see that @sdr-odoo and jorc (I can't find his GitHub account... meaning I can't ask Martin to update the team either) should be the reviewers.

Once the reviewer approves the changes, they ping the team odoo/doc-review so they can merge the content safely.

It's a small PR, so here is my review :)

  • I believe this PR should have targeted 13.0 instead of 15.0 since the doc is the same in all versions, and I believe your addition is valid for all versions.
    • in general, please check back to which version your changes can be applied.
    • We can't retarget the PR directly (or it pings all teams of reviewers). You have then to create a new PR, close this one, and mention the new one in it.
  • about the note, see the comment directly in the text.

If you agree with my suggestion, then I or @sdr-odoo can do the new PR for you this time :)

Have a good one!

Jonathan

@jcs-odoo
Copy link
Contributor

Oh and I forgot something:
The title of the commit (and the PR) should be something like this:

[IMP] inventory: add note about detailed operations in one_step.rst

@robodoo
Copy link
Collaborator

robodoo commented Mar 30, 2022

Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it.

@robodoo
Copy link
Collaborator

robodoo commented Mar 30, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants