Skip to content

[IMP] Contributing: list table customization parameters#16409

Closed
ghost wants to merge 1 commit into17.0from
17.0-contributing-rst-cheatsheet-striped-table-magou
Closed

[IMP] Contributing: list table customization parameters#16409
ghost wants to merge 1 commit into17.0from
17.0-contributing-rst-cheatsheet-striped-table-magou

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 13, 2026

Custom parameters for list tables

for V17.0 +

@ghost ghost requested review from Felicious and auva-odoo February 13, 2026 21:02
@ghost ghost self-assigned this Feb 13, 2026
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Feb 13, 2026

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 13, 2026 21:04
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 13, 2026

The sticky-table parameter has not yet been merged from Niki's PR, but it is approved (had to be redirected to 17.0 instead of 19.0)

*************The above original comment is incorrect. Please follow thread for more accurate info.

@AntoineVDV
Copy link
Copy Markdown
Collaborator

AntoineVDV commented Feb 16, 2026

@auva-odoo for context, here is the PR to introduce the feature: #16384. It's actually not approved yet, so I suggest you wait until it reaches a final status (merged or closed) before reviewing this one.

Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MCG357 !

I'll let @auva-odoo make the final call since she owns the documentation standards. From my perspective, this section goes into more implementation detail than necessary for our contributor guidelines.

Table usage is relatively limited in our workflow-focused documentation, and we aim to optimize doc style for LLM readability, and as per AWS RAG guidelines, tables are generally discouraged.

Given that, it may be sufficient to provide brief guidance here and link to the official Sphinx documentation for full directive options, unless there is a need and clear confusion among our documentation contributors that table formatting is something they struggle with.

Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
@ghost ghost force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from 1392204 to f7dff16 Compare February 17, 2026 19:49
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 17, 2026

@Felicious Thank you for the feedback. I adjusted the formatting, added the suggested Sphinx directives link, made, and reviewed.

Copy link
Copy Markdown
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @MCG357 🤗 I agree with @Felicious 100%, thank you for making that change already! I added a few minor comments 🙂

Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
Comment thread content/contributing/documentation/rst_guidelines.rst
Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
@ghost ghost force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from f7dff16 to 9f23339 Compare February 23, 2026 16:25
@ghost ghost requested review from Felicious and auva-odoo February 23, 2026 16:26
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 23, 2026

Thank you @auva-odoo and @Felicious for the feedback! I have updated per suggestions. Niki's sticky-header PR is not yet approved (I apologize for misspeaking earlier in the thread). Thank you! : )

Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
@ghost ghost force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from 9f23339 to 0b5e525 Compare February 24, 2026 19:00
@ghost ghost requested a review from auva-odoo February 24, 2026 19:01
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 24, 2026

All suggestions implemented. Thank you! @Felicious and @auva-odoo : )

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 24, 2026

Sticky-header PR merged per Niki : )

Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
- ``:widths:``: define column proportions (avoid using ``auto``), e.g., ``:widths: 25 25 50``.

.. seealso::
`Docutils documentation on reStructuredText tables <https://docutils.sourceforge.io/docs/ref/rst/directives.html#tables>`_
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line exceeds 100 characters.

have you installed the writer setup tool yet? this would automatically run make review and catch lines that exceed 100 characters before you commit (:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Felicious I do! I noticed this document had many cases of the character limit being exceeded and so was under the impression this document was an exception.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ensure the lines you've touched in this update align with content and style guidelines of the team

Copy link
Copy Markdown
Author

@ghost ghost Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do you want me to update the pre-existing make review flags or just my own in this case? Thanks! @Felicious

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the lines I was responsible for. Thank you!

@Felicious Felicious added the 2 label Feb 26, 2026
@ghost ghost requested a review from Felicious March 3, 2026 18:40
Copy link
Copy Markdown
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this already and let @Felicious check this one last time and r+ it. thank you very much for taking care of this @MCG357!

@ghost ghost force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from 0b5e525 to ac85836 Compare March 6, 2026 17:36
@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 6, 2026

Pre-existing make review results:
content/contributing/documentation/rst_guidelines.rst:363: consider moving "item" to line 363 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:369: consider moving "item" to line 369 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:391: consider moving "with" to line 391 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:397: consider moving "with" to line 397 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:452: consider moving "```label" to line 452 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:456: consider moving "another" to line 456 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:507: consider moving "or" to line 507 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:524: consider moving "::" to line 524 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:609: consider moving "about" to line 609 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:616: consider moving "-------------------" to line 616 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:621: consider moving "~~~~~~~" to line 621 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:624: consider moving "about" to line 624 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:938: consider moving "print("Hello" to line 938 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1224: consider moving "std::cout" to line 1224 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1225: consider moving "return" to line 1225 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1226: consider moving "}" to line 1226 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1290: consider moving "It" to line 1290 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1372: consider moving "->" to line 1372 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1387: consider moving "**line" to line 1387 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1392: consider moving "an" to line 1392 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:1394: consider moving "``[UNKNOWN" to line 1394 (early-line-breaks)
content/contributing/documentation/rst_guidelines.rst:28: Line too long (101/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:492: Line too long (101/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:493: Line too long (101/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:573: Line too long (104/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:643: Line too long (123/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:701: Line too long (137/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:718: Line too long (112/100) (line-too-long)
content/contributing/documentation/rst_guidelines.rst:799: Line too long (118/100) (line-too-long)
make: *** [Makefile:101: review] Error 1

Make review line fixed (my contribution):
content/contributing/documentation/rst_guidelines.rst:887: Line too long (125/100) (line-too-long)

Thank you!

@ghost ghost requested a review from Felicious March 6, 2026 17:37
Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MCG357,

Left some comments for sentence flow and consistency with the rest of the doc

After you implement those, we can merge

Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
Comment thread content/contributing/documentation/rst_guidelines.rst Outdated
@Felicious Felicious force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from ac85836 to 6d6a559 Compare March 26, 2026 19:54
Co-authored-by: Felicia Kuan <feku@odoo.com>
@Felicious Felicious force-pushed the 17.0-contributing-rst-cheatsheet-striped-table-magou branch from 6d6a559 to e73bd01 Compare March 26, 2026 21:43
Copy link
Copy Markdown
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants