[IMP] Contributing: list table customization parameters#16409
[IMP] Contributing: list table customization parameters#16409
Conversation
|
The sticky-table parameter has not yet been merged from Niki's PR, but it is approved (had to be redirected to 17.0 instead of 19.0) *************The above original comment is incorrect. Please follow thread for more accurate info. |
|
@auva-odoo for context, here is the PR to introduce the feature: #16384. It's actually not approved yet, so I suggest you wait until it reaches a final status (merged or closed) before reviewing this one. |
Felicious
left a comment
There was a problem hiding this comment.
Hi @MCG357 !
I'll let @auva-odoo make the final call since she owns the documentation standards. From my perspective, this section goes into more implementation detail than necessary for our contributor guidelines.
Table usage is relatively limited in our workflow-focused documentation, and we aim to optimize doc style for LLM readability, and as per AWS RAG guidelines, tables are generally discouraged.
Given that, it may be sufficient to provide brief guidance here and link to the official Sphinx documentation for full directive options, unless there is a need and clear confusion among our documentation contributors that table formatting is something they struggle with.
1392204 to
f7dff16
Compare
|
@Felicious Thank you for the feedback. I adjusted the formatting, added the suggested Sphinx directives link, made, and reviewed. |
auva-odoo
left a comment
There was a problem hiding this comment.
Thank you for this update @MCG357 🤗 I agree with @Felicious 100%, thank you for making that change already! I added a few minor comments 🙂
f7dff16 to
9f23339
Compare
|
Thank you @auva-odoo and @Felicious for the feedback! I have updated per suggestions. Niki's sticky-header PR is not yet approved (I apologize for misspeaking earlier in the thread). Thank you! : ) |
9f23339 to
0b5e525
Compare
|
All suggestions implemented. Thank you! @Felicious and @auva-odoo : ) |
|
Sticky-header PR merged per Niki : ) |
| - ``:widths:``: define column proportions (avoid using ``auto``), e.g., ``:widths: 25 25 50``. | ||
|
|
||
| .. seealso:: | ||
| `Docutils documentation on reStructuredText tables <https://docutils.sourceforge.io/docs/ref/rst/directives.html#tables>`_ |
There was a problem hiding this comment.
line exceeds 100 characters.
have you installed the writer setup tool yet? this would automatically run make review and catch lines that exceed 100 characters before you commit (:
There was a problem hiding this comment.
@Felicious I do! I noticed this document had many cases of the character limit being exceeded and so was under the impression this document was an exception.
There was a problem hiding this comment.
Let's ensure the lines you've touched in this update align with content and style guidelines of the team
There was a problem hiding this comment.
Ok, do you want me to update the pre-existing make review flags or just my own in this case? Thanks! @Felicious
There was a problem hiding this comment.
I fixed the lines I was responsible for. Thank you!
There was a problem hiding this comment.
I'll go ahead and approve this already and let @Felicious check this one last time and r+ it. thank you very much for taking care of this @MCG357!
0b5e525 to
ac85836
Compare
|
Pre-existing make review results: Make review line fixed (my contribution): Thank you! |
Felicious
left a comment
There was a problem hiding this comment.
Hi @MCG357,
Left some comments for sentence flow and consistency with the rest of the doc
After you implement those, we can merge
ac85836 to
6d6a559
Compare
Co-authored-by: Felicia Kuan <feku@odoo.com>
6d6a559 to
e73bd01
Compare
closes #16409 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com>

Custom parameters for list tables
for V17.0 +