[IMP] Sales: Aligning 'Optional products' page#16686
[IMP] Sales: Aligning 'Optional products' page#16686theRealThagomizer wants to merge 1 commit into17.0from
Conversation
|
|
larm-odoo
left a comment
larm-odoo
left a comment
There was a problem hiding this comment.
Hi @theRealThagomizer - great job! Most of these are optional, and I wrote down any reasons for my suggestions just to give you some context. If you have any questions, please let me know. Tag me agian for a quick peek when you're done, and I promise to review it again ASAP - I apologize for the delay with this one.
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
theRealThagomizer
force-pushed
the
17.0-sales-optional-products-update-thjud
branch
from
e415888 to
335fb4b
Compare
|
Hiya, @larm-odoo! I think I implemented all of the changes you indicated; I went through resolving things as I went just to try and keep things straight, but I believe I responded to/addressed everything. Please let me know if you have more feedback or if there's anything I missed. Thanks! |
|
Hiya, @larm-odoo! Just wanted to resurface this ahead of you being OoO next week. Thanks! |
|
Hiya, @Felicious! This is the PR I mentioned in stand-up this morning that could use another set of eyes on it. Thanks! |
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
LGTM @theRealThagomizer
@robodoo delegate+
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
theRealThagomizer
force-pushed
the
17.0-sales-optional-products-update-thjud
branch
from
a9c90c4 to
b117433
Compare
|
@robodoo r+ |
closes #16686 Signed-off-by: Thomas Jude Cavazos (thjud) <thjud@odoo.com> Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
4 participants
Hiya, @larm-odoo! This file is a 17.0 update of the optional products page (remember that big rework I did back in December?) This redoes the images to match current standards, reorganizes the information to flow more logically, and tweaks some of the details so they more accurately capture what the user experiences when they actually try to use optional products with quotations and quotation templates. Thank you!
This 17.0 PR can be FWP up to saas-18.4.