Skip to content

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 10, 2022

The 'sphinx-tabs' extension is better in every aspect:

  • Synchronize selected tabs (group tabs feature).
  • No need for extra code-block directive (code tabs feature).
  • Better looking.
  • No custom Python, JS, or CSS.

While doing so, the chance is also taken to document code tabs
and rework the page "External API" to use the example directive
and content tabs.

task-2787415

Forward-Port-Of: #1667

@robodoo
Copy link
Collaborator

robodoo commented Mar 10, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 10, 2022

Ping @AntoineVDV cherrypicking of pull request #1667 failed.

stderr:

18:13:32.085589 git.c:344               trace: built-in: git cherry-pick 543c37abaddc237fd808d6043f51f1ea1b79202a
error: Cherry-picking is not possible because you have unmerged files.
hint: Fix them up in the work tree, and then use 'git add/rm <file>'
hint: as appropriate to mark resolution and make a commit.
fatal: cherry-pick failed
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

The 'sphinx-tabs' extension is better in every aspect:
- Synchronize selected tabs (group tabs feature).
- No need for extra `code-block` directive (code tabs feature).
- Better looking.
- No custom Python, JS, or CSS.

task-2787415
@AntoineVDV AntoineVDV force-pushed the 14.0-13.0-drop_switcher_extension-anv-mM58-fw branch from 806980d to 70b5dd6 Compare March 11, 2022 14:09
@C3POdoo C3POdoo requested review from a team March 11, 2022 14:11
@AntoineVDV AntoineVDV removed request for a team March 11, 2022 14:13
@AntoineVDV
Copy link
Collaborator

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 11, 2022
robodoo pushed a commit that referenced this pull request Mar 11, 2022
The 'sphinx-tabs' extension is better in every aspect:
- Synchronize selected tabs (group tabs feature).
- No need for extra `code-block` directive (code tabs feature).
- Better looking.
- No custom Python, JS, or CSS.

task-2787415

Part-of: #1688
robodoo pushed a commit that referenced this pull request Mar 11, 2022
robodoo pushed a commit that referenced this pull request Mar 11, 2022
task-2787415

closes #1688

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo closed this Mar 11, 2022
@robodoo robodoo temporarily deployed to merge March 11, 2022 14:17 Inactive
@fw-bot fw-bot deleted the 14.0-13.0-drop_switcher_extension-anv-mM58-fw branch March 25, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants