Skip to content

Conversation

@AntoineVDV
Copy link
Collaborator

The 'sphinx-tabs' extension is better in every aspect:

  • Synchronize selected tabs (group tabs feature).
  • No need for extra code-block directive (code tabs feature).
  • Better looking.
  • No custom Python, JS, or CSS.

While doing so, the chance is also taken to document code tabs
and rework the page "External API" to use the example directive
and content tabs.

task-2787415

@robodoo
Copy link
Collaborator

robodoo commented Mar 8, 2022

@AntoineVDV AntoineVDV requested a review from jcs-odoo March 8, 2022 13:11
@C3POdoo C3POdoo requested review from a team March 8, 2022 13:11
@AntoineVDV AntoineVDV force-pushed the 13.0-drop_switcher_extension-anv branch 3 times, most recently from ac093ec to f42b6d3 Compare March 8, 2022 16:19
@AntoineVDV AntoineVDV force-pushed the 13.0-drop_switcher_extension-anv branch from f42b6d3 to ac8ef30 Compare March 10, 2022 14:11
The 'sphinx-tabs' extension is better in every aspect:
- Synchronize selected tabs (group tabs feature).
- No need for extra `code-block` directive (code tabs feature).
- Better looking.
- No custom Python, JS, or CSS.

task-2787415
@AntoineVDV AntoineVDV force-pushed the 13.0-drop_switcher_extension-anv branch from ac8ef30 to 543c37a Compare March 10, 2022 14:19
@AntoineVDV
Copy link
Collaborator Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Mar 10, 2022

Because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@AntoineVDV
Copy link
Collaborator Author

@robodoo rebase-ff

@robodoo
Copy link
Collaborator

robodoo commented Mar 10, 2022

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Mar 10, 2022
robodoo pushed a commit that referenced this pull request Mar 10, 2022
The 'sphinx-tabs' extension is better in every aspect:
- Synchronize selected tabs (group tabs feature).
- No need for extra `code-block` directive (code tabs feature).
- Better looking.
- No custom Python, JS, or CSS.

task-2787415

Part-of: #1667
robodoo pushed a commit that referenced this pull request Mar 10, 2022
task-2787415

closes #1667

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo closed this Mar 10, 2022
@robodoo robodoo temporarily deployed to merge March 10, 2022 17:14 Inactive
@fw-bot fw-bot deleted the 13.0-drop_switcher_extension-anv branch March 24, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants