[ADD] accounting: add extra fields section to peppol doc#16983
[ADD] accounting: add extra fields section to peppol doc#16983
Conversation
|
|
dade-odoo
force-pushed
the
18.0-peppol-fields-dade
branch
from
15561e6 to
92d7912
Compare
dade-odoo
requested review from
a team and
guhec-Odoo
and removed request for
a team and
guhec-Odoo
There was a problem hiding this comment.
Hi Dallas, you're the lucky recipient of my first team doc review 🙈
I've gone into a fair bit of detail in my individual comments, but to summarise a bit:
- I think we can make this section more concise by introducing and presenting the table data a bit differently, and by renaming the section and removing the sub-headings
- we also need to clear up any confusion over the Peppol technical field name vs the Odoo technical field name, and I think we can handle the point about the label being used to generate the Odoo technical name mainly as a note (which will also draw more attention to that important point!).
Edited to add: I added this in a comment too, as I knew I'd forget here ... but I just wanted to check if there was a reason you didn't target 17.0 with this change, since I see we already have a comprehensive Peppol section in that version.
Go through my comments in your own time ... see if you can make sense of them ... and then we can discuss in more detail if you like.
dade-odoo
force-pushed
the
18.0-peppol-fields-dade
branch
from
92d7912 to
a92fc96
Compare
mcsi-odoo
left a comment
mcsi-odoo
left a comment
There was a problem hiding this comment.
Hi @dade-odoo , thanks for all the work to integrate my suggestions :)
I think it's going to be worth waiting for my Studio PR to be merged (hopefully r+ing on Monday), so you don't have to duplicate the info about editing a field's technical name (which, after more testing by Audrey, for my own PR, turned out to be lacking some crucial steps).
I'm also still not convinced how we need to formulate that last note / what we need to say about the format of the studio field ... let's discuss that more?
dade-odoo
force-pushed
the
18.0-peppol-fields-dade
branch
2 times, most recently
from
22bee31 to
1171249
Compare
mcsi-odoo
left a comment
mcsi-odoo
left a comment
There was a problem hiding this comment.
Looks good to me, @dade-odoo !
@xpl-odoo , could you take a last look for me please?
xpl-odoo
left a comment
xpl-odoo
left a comment
There was a problem hiding this comment.
Great work @dade-odoo as usual! And excellent first review @mcsi-odoo
Very minor comments, I'll let you r+ this one @mcsi-odoo to check if you indeed have r+ rights now!
dade-odoo
force-pushed
the
18.0-peppol-fields-dade
branch
from
1171249 to
52a9593
Compare
|
Looking good, @dade-odoo ! @robodoo r+ |
|
@mcsi-odoo you can't review+. |
|
@robodoo r+ |
task-6018915 closes #16983 Signed-off-by: Siobhan McGonigle (mcsi) <mcsi@odoo.com>
5 participants
task-6018915