[FIX] Sales: Removed version specific reference#17305
Closed
theRealThagomizer wants to merge 1 commit into19.0from
Closed
[FIX] Sales: Removed version specific reference#17305theRealThagomizer wants to merge 1 commit into19.0from
theRealThagomizer wants to merge 1 commit into19.0from
Conversation
Collaborator
|
|
Contributor
Author
|
Hiya, @Felicious! Got a super minor fix for you to review. This removes the version-specific admonition block you mentioned yesterday and also an outdated image file. There are no other changes. Thank you! |
Contributor
|
Hi Thomas! It looks like this PR only targets 19.0 and up. I'd like that call out removed for 17 and 18 as well (: |
Contributor
Author
|
@Felicious Gotcha. I'm going to just close this PR out then and open a new 17.0 one, because I don't trust myself to rename everything correctly. |
Felicious
added
cancelled
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix to the Sales documentation. It removes a version-specific callout in a note admonition, which was against our style guidelines. It also removes the file for an image that no longer appears in the documentation.
This 19.0 PR can be FWP up to master.