[IMP] Subscriptions: eCommerce update#17367
Closed
theRealThagomizer wants to merge 1 commit into19.0from
Closed
Conversation
Collaborator
|
|
Contributor
Author
|
@Felicious Got a real quick review for you! |
Felicious
requested changes
Apr 14, 2026
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
@theRealThagomizer
super small nitpick about the links! once you get it working, I'll just r+
| sales product. To start selling the subscription in the eCommerce shop, click the :guilabel:`Go to | ||
| Website` smart button to navigate to the product page. | ||
| To begin selling subscription products in an *eCommerce* shop, first :doc:`configure the product | ||
| </applications/sales/subscriptions>` as a regular recurring sales product. After configuration is |
Contributor
There was a problem hiding this comment.
super small nitpick but we use relative file paths when they're shorter than the absolute one.
In this case, I believe it'll be :doc:configure the product <../> ? (Actually im not sure if that works)
Comment on lines
+21
to
+22
| - :doc:`Configure subscription products </applications/sales/subscriptions>` | ||
| - :doc:`Product variants </applications/sales/sales/products_prices/products/variants>` |
Contributor
There was a problem hiding this comment.
let's use relative paths!
theRealThagomizer
force-pushed
the
19.0-subscription-ecommerce-update-thjud
branch
from
e3c470b to
70308af
Compare
Contributor
Author
|
@Felicious Links fixed! (I'm reasonably certain.) This should be ready for merging! |
Felicious
approved these changes
Apr 14, 2026
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
LGTM @theRealThagomizer
Found an early line break! Thanks for figuring out the relative paths!!
@robodoo delegate+
Comment on lines
8
to
11
| <../subscriptions>` as a regular recurring sales product. After configuration is | ||
| complete, click the :guilabel:`Go to Website` smart button on the product's form to navigate to the | ||
| product's **eCommerce** page. | ||
|
|
Contributor
There was a problem hiding this comment.
early line break D:
Suggested change
| <../subscriptions>` as a regular recurring sales product. After configuration is | |
| complete, click the :guilabel:`Go to Website` smart button on the product's form to navigate to the | |
| product's **eCommerce** page. | |
| <../subscriptions>` as a regular recurring sales product. After configuration is complete, click the | |
| :guilabel:`Go to Website` smart button on the product's form to navigate to the product's | |
| **eCommerce** page. | |
Co-authored-by: Felicious <feku@odoo.com>
theRealThagomizer
force-pushed
the
19.0-subscription-ecommerce-update-thjud
branch
from
70308af to
e6d17b4
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 24, 2026
closes #17367 Signed-off-by: Thomas Jude Cavazos (thjud) <thjud@odoo.com> Co-authored-by: Felicious <feku@odoo.com>
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This 19.0 PR makes minor changes to the Subscriptions ecommerce page to bring it in line with current style guidelines. I'm going through the Subscriptions app updating everything that hasn't been updated within the past twelve months, so there will be more to come.
This 19.0 PR can be FWP to master.