Skip to content

[FIX] account: change foldable to foldability#17463

Closed
seifgneedy wants to merge 1 commit intomasterfrom
master-poc-groupby-agg-segn
Closed

[FIX] account: change foldable to foldability#17463
seifgneedy wants to merge 1 commit intomasterfrom
master-poc-groupby-agg-segn

Conversation

@seifgneedy
Copy link
Copy Markdown
Contributor

task-5891053

@seifgneedy seifgneedy requested a review from oco-odoo April 20, 2026 15:29
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 20, 2026

Pull request status dashboard

Copy link
Copy Markdown
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 20, 2026

@oco-odoo you can't review+.

@C3POdoo C3POdoo requested a review from a team April 20, 2026 15:31
@qdp-odoo
Copy link
Copy Markdown

@robodoo r+

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 20, 2026

@qdp-odoo you can't review+.

@qdp-odoo
Copy link
Copy Markdown

@odoo/doc-review pliiiiiiiz relax some r+ rights

Copy link
Copy Markdown
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV
Copy link
Copy Markdown
Collaborator

@robodoo delegate+ delegate=oco-odoo

robodoo pushed a commit that referenced this pull request Apr 20, 2026
task-5891053

closes #17463

Related: odoo/odoo#257280
Related: odoo/enterprise#112849
Related: odoo/upgrade#9835
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
robodoo pushed a commit to odoo/odoo that referenced this pull request Apr 20, 2026
* After the groupby on the report^1 was added and support of groupby on
aggregation being added, we don't want to have the groupby being applied
by default on the aggregation lines otherwise the report will be
unreadable.
Therefore, changing the foldable boolean to a computed stored selection
field, allowing for default behaviour to be as intended while enabling
the user to change them on the line if needed.

* In upgrade_code: removing the unnecessary foldable field in reports data files if they
will be correctly computed.

* For inconsistencies reported by script, manually set the foldability values
on the reports.

^1 : 05f1d84

task-5891053

Part-of: #257280
Related: odoo/enterprise#112849
Related: odoo/documentation#17463
Related: odoo/upgrade#9835
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
robodoo pushed a commit to odoo/odoo that referenced this pull request Apr 20, 2026
Added no_cross_report_expansion to _expand_aggregations for collecting
them to be computed alone when expanded from an aggregation line has
groupby on it.

task-5891053

closes #257280

Related: odoo/enterprise#112849
Related: odoo/documentation#17463
Related: odoo/upgrade#9835
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
@robodoo robodoo added the 19.3 label Apr 20, 2026
@robodoo robodoo closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants