Skip to content

[ADD] rental: new create rental order page#17702

Open
meval1006 wants to merge 1 commit intosaas-19.1from
saas-19.1-rental-new-rental-order-page-meval
Open

[ADD] rental: new create rental order page#17702
meval1006 wants to merge 1 commit intosaas-19.1from
saas-19.1-rental-new-rental-order-page-meval

Conversation

@meval1006
Copy link
Copy Markdown
Contributor

Added a new page for creating a rental order flow. I removed the " Create a rental order" sections from the Physical product and Service product pages.

Added new sections:

Manage employee shifts for rental services
Managing the project created from the rental order
Entering time for a rental service task
Tracking delivered time on a rental order
Task:https://www.odoo.com/odoo/my-tasks/6133961

This saas-19.1 PR should be FWP to master.

@meval1006 meval1006 self-assigned this May 2, 2026
@meval1006 meval1006 added the 5 label May 2, 2026
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 2, 2026

Pull request status dashboard

@meval1006 meval1006 force-pushed the saas-19.1-rental-new-rental-order-page-meval branch 3 times, most recently from cc13559 to 3ccf824 Compare May 7, 2026 18:15
@meval1006 meval1006 requested a review from larm-odoo May 7, 2026 18:15
@meval1006 meval1006 marked this pull request as ready for review May 7, 2026 18:16
@meval1006
Copy link
Copy Markdown
Contributor Author

Hi @larm-odoo, this PR is read for review. This is a continuation of a new page I create, but needed edits for the saas-19.1 to master versions. This is in prep for version saas-19.3.

@C3POdoo C3POdoo requested a review from a team May 7, 2026 18:17
@meval1006 meval1006 force-pushed the saas-19.1-rental-new-rental-order-page-meval branch from 3ccf824 to 6dc7dc9 Compare May 7, 2026 21:51
Copy link
Copy Markdown
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meval1006 - this was a TON of work, and I like the reorganization! I just left some general comments for you, nothing major. I do want to remind you that the max width you can use for an image is actually 933 - some of them really need that extra width (one in particular). Also, I'd recommend that before adding images, you think about whether it is necessary, as in, "would the customer understand this without this image?" A lot of the images I felt were extra and unneeded- they are basic things people should understand from the text. If the text is confusing, or there's a whole form to fill out - those are helpful to show, but generic things like the cog menu, buttons, etc - those can usually be eliminated.

Approved - this was such a beast, so amazing job!

Comment on lines +5 to +6
In Odoo **Rental**, quotations can be created and sent to customers. Similar to **Sales**
quotations, once a quotation is confirmed, it becomes a *rental order* and can be invoiced and paid
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In Odoo **Rental**, quotations can be created and sent to customers. Similar to **Sales**
quotations, once a quotation is confirmed, it becomes a *rental order* and can be invoiced and paid
In Odoo **Rental**, quotations are created and sent to customers, similar to **Sales**
quotations. Once a quotation is confirmed, it becomes a *rental order* and can be invoiced and paid

"are" sounds more proactive, and I wanted to link the first 2 sentences.

Comment on lines +9 to +11
.. important::
To configure quotation settings, the **Sales** app **must** be installed. Refer to the
:ref:`sales/quotation-settings` for detailed instructions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest either "Refer to the (title) dod", or "Refer to (title)"

Comment on lines +16 to +17
To create a rental order in the **Rental** app, navigate to :menuselection:`Rental app --> Orders
--> Orders`, and click :guilabel:`New`. Doing so reveals a blank rental order form.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To create a rental order in the **Rental** app, navigate to :menuselection:`Rental app --> Orders
--> Orders`, and click :guilabel:`New`. Doing so reveals a blank rental order form.
To create a rental quote, navigate to :menuselection:`Rental app --> Orders
--> Orders`, and click :guilabel:`New`. Doing so reveals a blank rental order form.

I'd rmeove 'Rental' app since it's implied, and we see a bold "Rental" word a couple words away. Also, wouldnt you cretae the quote? The title is creating a quote, so I am wondering why we say order instead (I know they become orders). So I recommend either saying 'quote' or adding the idea in the firts sentence - "To create a rental order, first a quotation must be created and ocnfirmed" or osmething liek that.

:alt: Sample of a filled out rental order available in the Odoo Rental application.

Start by adding a :guilabel:`Customer`, then set the desired rental duration in the
:guilabel:`Rental period` field. To adjust the rental duration, click the first date in the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:guilabel:`Rental period` field. To adjust the rental duration, click the first date in the
:guilabel:`Rental period` fields. To adjust the rental duration, click the first date in the

Just becuse there's 2 fields to enter

There can only be one rental period per rental order. Multiple rental product orders with
different rental periods require a rental order for each rental period.

.. image:: create_rental_order/rental-period-field-popup.png
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a self-explanatory image and is not necessary

---------------------------------------------------------

For physical service products, such as hotel rooms, workstations, and conference rooms, a final
adjustment to the time (usually a Nightly rental period) may be needed on the invoice.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
adjustment to the time (usually a Nightly rental period) may be needed on the invoice.
adjustment to the time may be needed on the invoice.

Is it? Or would it also be "Daily" or however they configure it? Might be more clear to not reference it at all?

Enter the amount in the :guilabel:`Quantity` column. If new charges were accrued during the rental
period, click :guilabel:`Add a line` to include them in the invoice draft.

.. image:: create_rental_order/draft-invoice-for-hotel-room.png
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove- self explanatory, and readers see/undrstand the 'add a line' part well enough.

Comment on lines +200 to +201
If all the details are correct on the invoice draft, click :guilabel:`Confirm` and click
:guilabel:`Send` to email the invoice to the customer, or :guilabel:`Print` and then click
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If all the details are correct on the invoice draft, click :guilabel:`Confirm` and click
:guilabel:`Send` to email the invoice to the customer, or :guilabel:`Print` and then click
If all the details are correct on the invoice draft, either click :guilabel:`Confirm` and click
:guilabel:`Send` to email the invoice to the customer, or click :guilabel:`Print` and then click

Click the :guilabel:`Payments` smart button that appears at the top of the rental order. Click
:guilabel:`Validate` on the Payment page.

.. image:: create_rental_order/payment-page-validate.png
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed- basic concept/don't need the illustration

:guilabel:`Pay` if the customer is in person. In the :guilabel:`Pay` pop-up window, select a
:guilabel:`Journal` and click :guilabel:`Create Payment`.

.. image:: create_rental_order/pay-page.png
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants