Master accurate remaining days 6175442 jucop#17998
Open
jucop-odoo wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
jucop-odoo
force-pushed
the
master-accurate-remaining-days-6175442-jucop
branch
from
65396f7 to
922f876
Compare
Luxon is not very accurate when the field is close to today: If today is Apr 30, so a deadline set to May 1 will be displayed as "Next month". In practice, it is not wrong, but it is not very accurate. The widget name 'RemainingDaysField' was misleading as it implies a focus on future countdowns, whereas the widget is also used for past dates. task-6175442
jucop-odoo
force-pushed
the
master-accurate-remaining-days-6175442-jucop
branch
from
922f876 to
0468665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luxon is not very accurate when the field is close to today: If today is Apr 30, so a deadline set to May 1 will be displayed as "Next month". In practice, it is not wrong, but it is not very accurate.
The widget name 'RemainingDaysField' was misleading as it implies a focus on future countdowns, whereas the widget is also used for past dates.
task-6175442