-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[ADD] sms marketing: added essentials/getting started docs #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mivu-odoo I added some basic, "essential," documentation to the SMS Marketing doc. Once I get your approval/review, I'll pass it along to Zac. Thanks! |
432e64e to
d542657
Compare
|
Hi @ksc-odoo! This PR wasn't passing the As of commit d542657
Despite all these changes, the PR still won't pass the code check b/c there's one error I haven't quite figured out how to crack. When I run |
d542657 to
6e978b7
Compare
|
Hi @mivu-odoo and @ksc-odoo 👋 I fixed what was causing the build error here! It was due to an incorrect referenced doc path on line 140 of The path was: The referenced doc path needs to be relative to the document you are linking from, so the correct path looks like this: |
|
@StraubCreative Ready for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksc-odoo
These docs need another round of proofreading and revisions.
Lots of 2nd-person you/your language, some screenshots are too big, unnecessary, or not named properly, etc...the usual suspects 😉
Please submit updated content to @samueljlieber he'll handle the git flow for you.
6e978b7 to
b4acc53
Compare
|
Hi @ksc-odoo, in b4acc53 I implemented your changes per @StraubCreative suggestions:
I think your changes to these docs look really good 👍 I made a few small RST adjustments, @ksc-odoo can you please confirm these changes with a review before I pass to @StraubCreative? 🙏 |
Hey @samueljlieber - Feel free to pass it along to @StraubCreative 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ksc-odoo
Nice work. I like the depth of explanation and walk-through on these 👍
My CRs below are mostly around small things and fine tuning since the content already hits the mark. See below where I made comments just on the sms_essentials.rst doc, which apply to all docs in this PR, as well.
Overview:
- formatting of sentences, mainly parenthesis use. I see what you're doing in most cases, using parenthesis as tiny aside comments in sentences, however, I don't think they're needed in most cases. Most of what I see comes off as redundant or could easily be included into the sentence with a comma.
- line breaks. Just a few spots to fix.
- headings. Two headings are duplicates and we don't need
How to...prefixes. - images. Most images are too large, not in HD, and could use red markup to illustrate cause > effect. As well, some screenshots would benefit from showcasing more information or a more complete use case to illustrate the depth of the product.
Can you take a look and apply to every doc on the PR? Can work with @samueljlieber to push up the next batch of changes.
Thank you both!
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Outdated
Show resolved
Hide resolved
content/applications/marketing/sms_marketing/essentials/sms_essentials.rst
Show resolved
Hide resolved
b4acc53 to
ac8b150
Compare
36bb56f to
01d323d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. toctree:: | ||
| :titlesonly: | ||
|
|
||
| sms_marketing/essentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we wanted to remove the pricing FAQ here and just make essentials the top-level directory for SMS, right?
If so, we'll need to follow up in another PR to clean that up, which could be a good opportunity to wipe out all mid-level directories that aren't needed for all US scopes.
| Odoo's :guilabel:`SMS Marketing` application can also help boost conversion rates around valuable | ||
| actions, such as event registrations, free trials, purchases, etc., since :abbr:`SMS (Short Message | ||
| Service)` text and mobile-based channels typically have high open-rates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove guilabel here + slight wording changes.
| Odoo's :guilabel:`SMS Marketing` application can also help boost conversion rates around valuable | |
| actions, such as event registrations, free trials, purchases, etc., since :abbr:`SMS (Short Message | |
| Service)` text and mobile-based channels typically have high open-rates. | |
| Odoo's *SMS Marketing* application can also help boost conversion rates around valuable actions, | |
| such as event registrations, free trials, purchases, etc., since text and mobile-based marketing | |
| channels typically yield higher :abbr:`CTOR (click-to-open rate)` and :abbr:`CTR (click-through | |
| rate)` outcomes. |
| An :abbr:`SMS (Short Message Service)` can have one of the following statuses: :guilabel:`Draft`, | ||
| :guilabel:`In Queue`, :guilabel:`Sending`, or :guilabel:`Sent`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specificity
| An :abbr:`SMS (Short Message Service)` can have one of the following statuses: :guilabel:`Draft`, | |
| :guilabel:`In Queue`, :guilabel:`Sending`, or :guilabel:`Sent`. | |
| An :abbr:`SMS (Short Message Service)` mailing can have one of the following statuses: | |
| :guilabel:`Draft`, :guilabel:`In Queue`, :guilabel:`Sending`, or :guilabel:`Sent`. |
| =================== | ||
|
|
||
| To start, click :guilabel:`Create` on the main :guilabel:`SMS Marketing` dashboard, and Odoo reveals | ||
| a blank SMS template, which can be configured in a number of different ways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specificity
| a blank SMS template, which can be configured in a number of different ways. | |
| a blank SMS template form, which can be configured in a number of different ways. |
| the choices Odoo makes avaialble. | ||
|
|
||
| When another field (other than :guilabel:`Mailing List`) is selected, the option to specify that | ||
| chosen field even further becomes available - either with a default recipient filter equation that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would use an em (long) dash here.
| chosen field even further becomes available - either with a default recipient filter equation that | |
| chosen field even further becomes available — either with a default recipient filter equation that |
| To see a complete collection of blacklisted numbers, navigate to the :guilabel:`SMS Marketing` app, | ||
| and go to :menuselection:`Configuration --> Blacklisted Phone Numbers`. Doing so, reveals a separate | ||
| page containing every blacklisted phone number in the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording/formatting.
| To see a complete collection of blacklisted numbers, navigate to the :guilabel:`SMS Marketing` app, | |
| and go to :menuselection:`Configuration --> Blacklisted Phone Numbers`. Doing so, reveals a separate | |
| page containing every blacklisted phone number in the database. | |
| To see a complete collection of blacklisted numbers, navigate to the :menuselection:`SMS Marketing | |
| app --> Configuration --> Blacklisted Phone Numbers` to reveal a dashboard containing every | |
| blacklisted phone number in the database. |
| To manually add a number, click the :guilabel:`Create` button in the upper-left. When clicked, Odoo | ||
| reveals a separate page, in which the phone number to be blacklisted is entered. There's also a | ||
| checkbox to indicate whether that particular phone numnber is :guilabel:`Active` (or not). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Odoo reveals a separate page" phrase is too wordy. Just say what's happening in clear terms 😉
| To manually add a number, click the :guilabel:`Create` button in the upper-left. When clicked, Odoo | |
| reveals a separate page, in which the phone number to be blacklisted is entered. There's also a | |
| checkbox to indicate whether that particular phone numnber is :guilabel:`Active` (or not). | |
| To manually add a number to a blacklist, click the :guilabel:`Create` button in the upper-left | |
| corner of the dashboard and enter the phone number on the next page's form. There's also a |
| Once the form is completed, click :guilabel:`Save` to add it to the :guilabel:`Blacklist`. To | ||
| remove any number from the :guilabel:`Blacklist`, select the desired number, and click | ||
| :guilabel:`Unblacklist`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blacklisted Phone Numbers gets a guilabel because it's a menu item and the name of a dashboard, while blacklist does not. Added some more specificity here too.
| Once the form is completed, click :guilabel:`Save` to add it to the :guilabel:`Blacklist`. To | |
| remove any number from the :guilabel:`Blacklist`, select the desired number, and click | |
| :guilabel:`Unblacklist`. | |
| Once the form is completed, click :guilabel:`Save` to add it to the :guilabel:`Blacklisted Phone | |
| Numbers` list. To remove any number from the blacklist, select the desired number on the dashboard, | |
| and then, on the phone number's form, click :guilabel:`Unblacklist`. |
| -------------------- | ||
|
|
||
| During a software/platform migration, it is possible to import an already existing blacklist of | ||
| contacts. This would include customers, who have already asked to be :guilabel:`Blacklisted` on SMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| contacts. This would include customers, who have already asked to be :guilabel:`Blacklisted` on SMS | |
| contacts. This would include customers, who have already asked to be blacklisted` on :abbr:`SMS | |
| (Short Message Service)` mailings. |
| To do that, navigate to the :guilabel:`SMS Marketing` app, and go to :menuselection:`Configuration | ||
| --> Blacklisted Phone Numbers`. Then, select the :guilabel:`Favorites` drop-down (beneath | ||
| the search bar), and click :guilabel:`Import records`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| To do that, navigate to the :guilabel:`SMS Marketing` app, and go to :menuselection:`Configuration | |
| --> Blacklisted Phone Numbers`. Then, select the :guilabel:`Favorites` drop-down (beneath | |
| the search bar), and click :guilabel:`Import records`. | |
| To do that, navigate to :menuselection:`SMS Marketing app --> Configuration --> Blacklisted Phone | |
| Numbers`, and then select the :guilabel:`Favorites` drop-down menu (beneath the search bar), and | |
| click :guilabel:`Import records`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: see review notes above. GH bugged out and submitted the review twice 😓
Hey @StraubCreative I agree with ALL these suggested changes - feel free to squash/merge at your earliest convenience. Thanks! |
01d323d to
10ecd29
Compare
|
@robodoo r+ |
closes #2553 Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
Task ID: 2942125