-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] inventory: thd batch updates #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db2e5f2 to
f3d1959
Compare
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing content in wave_transfers.rst, will need to come back another time to review content in the other changed RST files.
For wave_transfers.rst, I fixed the wording to remove use of familiar second-person "you", added transition words and phrases to improve readability, fixed spelling and grammar issues, took new screenshots because the current images are wider than tablet breakpoint size, and left comments for which images can be removed.
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/misc/wave_transfers.rst
Outdated
Show resolved
Hide resolved
f3d1959 to
3b37ae8
Compare
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished review for count_products.rst
Lots of images were too wide, so I took new screenshots and linked them in my comments. I also think some images aren't necessary and should be deleted, because they are redundant or they show very simple and basic things that are easy to find.
I also fixed wording. There were some spelling errors and some sentences did not make sense. I also added transition words to help the flow of the doc and show chronological order.
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Outdated
Show resolved
Hide resolved
...applications/inventory_and_mrp/inventory/management/inventory_adjustments/count_products.rst
Show resolved
Hide resolved
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished review on cycle_counts.rst
A short and sweet one. Rewrote some sentences for better flow and clarity. Replaced one image inventory-frequency.png that was way too wide.
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/inventory_adjustments/cycle_counts.rst
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished review of strategies.rst
This was a hefty one with a lot of spelling errors.
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/strategies.rst
Outdated
Show resolved
Hide resolved
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing uom.rst
I found a lot of images were not needed b/c they were redundant and showed very obvious things that should be clear from the text. Other than that, I also fixed headers to be in sentence case and removed uses of familiar second-person pronouns like you, your, etc.
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/uom.rst
Outdated
Show resolved
Hide resolved
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed wording, formatting, and grammar issues. Some images for units of measure aren't needed. It's overkill when we could just link to the uom.rst in a See Also section at the end.
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing integrating_landed_costs.rst, had to remove uses of second-person pronouns and rewrite sections for better flow. One question for @thomasdeleval on where to view the landed cost accounting journal entry: #2556 (comment). The sentence is unclear.
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
...t/applications/inventory_and_mrp/inventory/management/reporting/integrating_landed_costs.rst
Outdated
Show resolved
Hide resolved
mivu-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing resupply_warehouses.rst. Had to rewrite some sections for better flow and to remove uses of first and second-person pronouns.
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/warehouses/resupply_warehouses.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/management/products/usage.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/routes/concepts/use-routes.rst
Outdated
Show resolved
Hide resolved
3b37ae8 to
095a938
Compare
|
Hi @mivu-odoo Latest changes on 095a938, content revisions for:
Also rebased to latest commit e21dbd0 and solved merge conflict for At this point, @samueljlieber is going to jump in and help implement the next batch of content changes. @samueljlieber, I already cleaned up the RST, and @mivu-odoo did a strong pass on most of the content. What's needed now is to implement what MIVU change requests so far, however, we still have a couple docs left to review. Also if you catch anything I missed feel free to fix as well ;) You can get started here at this comment, and then work your way down, through each file, as far as you can. When complete, please notify us here on progress, ty! 🙏 @everyone if/once the feature branch is on your computer, friendly reminder to do |
0ef803e to
f7c003b
Compare
|
@AntoineVDV Thank you for the suggestions! They have been implemented in f7c003b. |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
closes #2556 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556 closes #119824 Related: odoo/enterprise#40372 Signed-off-by: Raphael Collet <rco@odoo.com>
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556 closes #120149 Related: odoo/enterprise#40548 Signed-off-by: Raphael Collet <rco@odoo.com>
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556 closes #120300 Related: odoo/enterprise#40600 Signed-off-by: Raphael Collet <rco@odoo.com> Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556
This commit updates the documentation URLs to the current URLs, although there are already redirect rules in place as fallback. Related odoo/documentation pull requests: Calendar: odoo/documentation#4032 task-3217827 POS odoo/documentation#4226 task-3284514 Inventory odoo/documentation#2556 closes #120345 Related: odoo/enterprise#40623 Signed-off-by: Raphael Collet <rco@odoo.com> Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
Overview
This is a batch cherry pick of PR’s #2002, #1984, #1900, #1876, #1870, #1854, and #1824
I took the changes originally proposed in these PR’s and stacked them here on a fresh 15.0 base since they were all merge requests into 15.0.
Formatting updates
On top of the original changes proposed by @thomasdeleval, I went ahead and updated technicals for each affected RST file + associated images. Those changes are as follows in order to bring each doc up to standards:
usage_01.png—>uom-handling-vs-purchase.png), and updated RST links accordingly.Follow up items for review
I did not change any of the content other than what what the PRs originally suggested, however I think there are a number of improvements to be made around wording, grammar, and specificity of language.
Generally speaking, please consider the following suggestions in content review stage:
:guilabel:'s 😈