-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] account, account_report, l10n_*: Introduce unified reporting en… #2557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content/developer/reference/standard_modules/account/account_report_line.rst
Outdated
Show resolved
Hide resolved
c35df9a to
8e0ca5c
Compare
973f115 to
0f03705
Compare
|
|
||
| * `ir.ui.menu record in l10n_be <{GITHUB_PATH}/addons/l10n_be/data/menuitem_data.xml>`_ | ||
| * `parent_id field in l10n_be_reports (v15) <https://github.com/odoo/enterprise/blob/d4eff9d39469cf3fe18589a1547cb0cdb93f4ae9/l10n_be_reports/data/account_financial_html_report_data.xml#L11>`_ | ||
| * `parent_id field in l10n_be_reports (v16) <https://github.com/odoo/enterprise/blob/a1614d0b1460dc453cbe395efba41573d29e7b7e/l10n_be_reports/data/partner_vat_listing.xml#L55-L65>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this commit really exists on the repo, and that it will get garbage collected at some point
content/developer/reference/standard_modules/account/account_report_line.rst
Outdated
Show resolved
Hide resolved
| .. autofield:: applicability | ||
| .. autofield:: color | ||
| .. autofield:: active | ||
| .. autofield:: tax_report_line_ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have all the models that lead from the reports to the tags
158aa83 to
1075281
Compare
|
A next PR will need to be done to fix the links (and a few other things) |
|
I'm sorry, @william-andre. I'm afraid I can't do that. |
…gine This commit adapts account's model to the new report engine introduced for v16, and updates the data files accordingly. account.report model is now declared in community, together with the other models used by the reporting. This is done so that the tax tags can properly be created by the tax report and used on tax templates. All the actual computation logic stays in enterprise. See enterprise commit for full details. Task 2524389 Signed-off-by: Julien Alardot (jual) <jual@odoo.com>
1075281 to
282da1d
Compare
|
@jcs-odoo @AntoineVDV Congratulations! You are the blocking point in THE merge for accounting. |
|
@jcs-odoo @AntoineVDV He is trying to say: "Can you please recheck this PR. It should be ok now. Many thanks! 😄 " |
|
@jcs-odoo @AntoineVDV Did not I put it like it is of a great honour to you? |
|
Hello @jco-odoo and @smetl Normally, the reviewers in the team account-dev-doc-review should have added odoo/doc-review as the next reviewer of this PR. Here, it would have been a re-request, since Antoine immediately reviewed this PR. Now, if wan approved this pr on behalf of account-dev-doc, forgot to add odoo/doc-review as reviewer and didn't comment anything after robodoo replied that he didn't have r+ privilege at 5.30pm yesterday. Well... I think Antoine and I don't deserve your congratulations 😅 |
|
@jcs-odoo @AntoineVDV Congratulations! You are the blocking point in THE merge for accounting. Hello @jco-odoo, do you really need to behave like an asshole here? Let me remind you that the PR was opened 22 days ago, and I reviewed it only 21 minutes later. Since then, there have been 10 pushes to the PR and no hint whatsoever that it was ready for a new review. I honestly fail to see how I am a "blocking point" in this process, and if I actually am, what gives you the right to use that tone to talk to colleagues? |
|
@AntoineVDV I was trying to mock with the lengths these processes can take even if everyone is trying their best to get things done. Nothing personal. I could have taken more care making that clear. Sorry. |
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
|
@smetl @AntoineVDV linked pull request(s) odoo/enterprise#28648, odoo/odoo#94125, odoo/upgrade#3695 not ready. Linked PRs are not staged until all of them are ready. |
|
@robodoo delegate=oco-odoo |
…tax repartition lines closes #94125 Related: odoo/enterprise#28648 Related: odoo/upgrade#3695 Related: odoo/documentation#2557 Signed-off-by: Laurent Smet <las@odoo.com>
…gine This commit adapts account's model to the new report engine introduced for v16, and updates the data files accordingly. account.report model is now declared in community, together with the other models used by the reporting. This is done so that the tax tags can properly be created by the tax report and used on tax templates. All the actual computation logic stays in enterprise. See enterprise commit for full details. Task 2524389 closes #2557 Related: odoo/odoo#94125 Related: odoo/enterprise#28648 Related: odoo/upgrade#3695 Signed-off-by: Julien Alardot (jual) <jual@odoo.com> Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
…gine
This commit adapts account's model to the new report engine introduced for v16, and updates the data files accordingly.
account.report model is now declared in community, together with the other models used by the reporting. This is done so that the tax tags can properly be created by the tax report and used on tax templates. All the actual computation logic stays in enterprise.
See enterprise commit for full details.
Task 2524389
Signed-off-by: Julien Alardot (jual) jual@odoo.com