[IMP] accounting: updated multicurrency page #2559

toaa-odoo · 2022-08-04T14:15:04Z

Previous page was based on V13, updated for V15 up to V15.2. Deleted files as they contained the exact same content as this .rst file and made it more confusing for readers

task id: 2942040

robodoo · 2022-08-04T14:15:28Z

Pull request status dashboard.

xpl-odoo

You forgot to make html before pushing (that's why you have a "no build found" error with the automated checks)

content/applications/finance/accounting/others/multicurrencies.rst

content/applications/finance/accounting/others/multicurrencies/multicurrency.rst

redirects/15.0.txt

toaa-odoo · 2022-08-08T10:45:32Z

You forgot to make html before pushing (that's why you have a "no build found" error with the automated checks)

The problem is I have a "malformed" redirect in the redirect file, that's the issue :(

xpl-odoo

Nice job! Two small changes and we are good to go :)
But I already approve it.

content/applications/finance/accounting/others/multicurrencies.rst

jcs-odoo

Nice improvement, and good call to put all these docs into a single one! Good job :)
There were some points missing or improbable, so I did them directly on the branch and I pushed the changes. But please have a look at the comments and the commit with my changes, @toaa-odoo @xpl-odoo

jcs-odoo · 2022-09-05T14:19:47Z

redirects/15.0.txt

@@ -1,5 +1,6 @@
 # applications/finance

+applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies/multicurrency.rst


wrong redirection path

missing redirections for other deleted files that were in the toctree

Suggested change

applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies/multicurrency.rst

applications/finance/accounting/others/multicurrencies/exchange.rst applications/finance/accounting/others/multicurrencies.rst # /multicurrencies/* -> multicurrencies

applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies.rst # /multicurrencies/* -> multicurrencies

applications/finance/accounting/others/multicurrencies/invoices_payments.rst applications/finance/accounting/others/multicurrencies.rst # /multicurrencies/* -> multicurrencies

jcs-odoo · 2022-09-05T14:20:51Z

content/applications/finance/accounting/others/multicurrencies.rst

+:menuselection:`Accounting --> Configuration --> Accounting: Journals`, select the journal you want
+to edit, and, leave the :guilabel:`Currency` field empty.
+
+.. image:: multicurrencies/journal-currency.png


not compressed with pngquant yet

jcs-odoo · 2022-09-05T14:31:43Z

content/applications/finance/accounting/others/multicurrencies.rst

+Odoo allows you to emit and receive bills, invoices, and other documents in multiple currencies
+other than the main currency configured for your company. You also set up bank accounts in other
+currencies and run reports on your foreign currency activities.


Suggested change

Odoo allows you to emit and receive bills, invoices, and other documents in multiple currencies

other than the main currency configured for your company. You also set up bank accounts in other

currencies and run reports on your foreign currency activities.

Odoo allows you to issue invoices, receive bills, and record transactions in currencies other than

the main currency configured for your company. You can also set up bank accounts in other currencies

and run reports on your foreign currency activities.

jcs-odoo · 2022-09-06T08:41:32Z

content/applications/finance/accounting/others/multicurrencies.rst

+====================
+Multicurrency system
+====================


I suggest "multi-currency system" as it's how we used to spell it before, how our competitors and blogs write it. it's correct without it as well, but I'd go for the hyphen.
https://dictionary.cambridge.org/dictionary/english/multi-currency

I'll also adapt all the filenames, refs and redirections.

jcs-odoo · 2022-09-06T09:14:45Z

content/applications/finance/accounting/others/multicurrencies.rst

+.. seealso::
+   - :doc:`../bank/setup/foreign_currency`


I'd move the relevant seealso links at the end of the doc's intro, since it's a "global" relevant link, and not specifically to this section of the doc.

jcs-odoo · 2022-09-06T11:20:18Z

content/applications/finance/accounting/others/multicurrencies.rst

+The **Exchange Difference** journal records the differences between the invoiced amount at the
+creation date of the invoice and the amount received at the date of the payment. For example, if a


let's change the sentence to say it's one of the scenarios and not the only scenario.

jcs-odoo · 2022-09-06T11:21:24Z

content/applications/finance/accounting/others/multicurrencies.rst

+payment is received one month after the invoice was issued, the exchange rate has likely changed
+since. This fluctuation therefore implies some profit or loss due to the exchange difference, which
+Odoo automatically records.


we could write an example with numbers and put it in an "example" admonition.

jcs-odoo · 2022-09-06T14:20:31Z

content/applications/finance/accounting/others/multicurrencies.rst

+Exchange rate journal
+---------------------


the default accounts and journal for exchange differences is missing. It's quite important ^^

suggestion of new title
Exchange difference entries

rework a bit this section

jcs-odoo · 2022-09-07T15:35:01Z

content/applications/finance/accounting/others/multicurrencies.rst

+:guilabel:`Register Payment` payment button of your document. In the pop-up window, enter the
+**currency** in the :guilabel:`Amount` field, and select a :guilabel:`Journal`.
+
+.. image:: multicurrencies/register-payment.png


why is the journal not editable?

jcs-odoo · 2022-09-16T14:23:56Z

content/applications/finance/accounting/others/multicurrencies.rst

+currency of your company, click on :guilabel:`Currencies`. From here, enable the currencies you wish
+to use by toggling the :guilabel:`Active` button.
+
+.. image:: multicurrencies/enable-foreign-currencies.png


best to limit the amount of information on a screenshot. Here, the available on eBay is superfluous

jcs-odoo · 2022-09-16T15:23:49Z

@xpl-odoo can you re-review this PR please, since I modified a lot the original commit? And ping doc-review when it's good. Muchas gracias :)

jcs-odoo · 2022-09-20T08:32:42Z

doc-review, I skip Xavier because he's too busy with the release notes at the moment.

content/applications/finance/accounting/others/multi_currency.rst

task id: 2942040 Co-authored-by: Jonathan Castillo (jcs) <jcs@odoo.com>

AntoineVDV

@robodoo r+

toaa-odoo force-pushed the 15.0-multicurrencies-toaa branch from e5fab45 to 20d235f Compare August 4, 2022 14:15

C3POdoo requested review from a team August 4, 2022 14:16

toaa-odoo force-pushed the 15.0-multicurrencies-toaa branch from 20d235f to 3d98924 Compare August 4, 2022 14:19

toaa-odoo requested review from xpl-odoo and removed request for a team August 4, 2022 14:19

toaa-odoo force-pushed the 15.0-multicurrencies-toaa branch from 3d98924 to 6e96a7e Compare August 4, 2022 14:43

xpl-odoo requested changes Aug 8, 2022

View reviewed changes

toaa-odoo force-pushed the 15.0-multicurrencies-toaa branch from 6e96a7e to 0c1d3fb Compare August 9, 2022 12:37

toaa-odoo requested a review from xpl-odoo August 9, 2022 12:39

xpl-odoo approved these changes Aug 11, 2022

View reviewed changes

content/applications/finance/accounting/others/multicurrencies.rst Outdated Show resolved Hide resolved

toaa-odoo force-pushed the 15.0-multicurrencies-toaa branch from 0c1d3fb to 3a78538 Compare August 12, 2022 07:02

toaa-odoo requested a review from jcs-odoo August 12, 2022 07:02

jcs-odoo force-pushed the 15.0-multicurrencies-toaa branch from 3a78538 to 066dbd0 Compare September 16, 2022 15:13

jcs-odoo reviewed Sep 16, 2022

View reviewed changes

jcs-odoo requested a review from xpl-odoo September 16, 2022 15:16

jcs-odoo force-pushed the 15.0-multicurrencies-toaa branch from 066dbd0 to 5862347 Compare September 16, 2022 15:21

jcs-odoo requested a review from a team September 20, 2022 08:31

AntoineVDV requested changes Sep 20, 2022

View reviewed changes

content/applications/finance/accounting/others/multi_currency.rst Outdated Show resolved Hide resolved

AntoineVDV removed the request for review from xpl-odoo September 20, 2022 15:01

[IMP] accounting: update + merge of multiple multi-currency pages

829649e

task id: 2942040 Co-authored-by: Jonathan Castillo (jcs) <jcs@odoo.com>

jcs-odoo force-pushed the 15.0-multicurrencies-toaa branch from 5862347 to 829649e Compare September 20, 2022 15:19

jcs-odoo requested a review from AntoineVDV September 20, 2022 15:19

AntoineVDV approved these changes Sep 20, 2022

View reviewed changes

robodoo closed this in 149353c Sep 20, 2022

robodoo temporarily deployed to merge September 20, 2022 16:27 Inactive

This was referenced Sep 20, 2022

[FW][IMP] accounting: updated multicurrency page #2742

Closed

[FW][IMP] accounting: updated multicurrency page #2743

Closed

[FW][IMP] accounting: updated multicurrency page #2744

Closed

		@@ -1,5 +1,6 @@
		# applications/finance

		applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies/multicurrency.rst

-applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies/multicurrency.rst
+applications/finance/accounting/others/multicurrencies/exchange.rst applications/finance/accounting/others/multicurrencies.rst                      # /multicurrencies/* -> multicurrencies
+applications/finance/accounting/others/multicurrencies/how_it_works.rst applications/finance/accounting/others/multicurrencies.rst                  # /multicurrencies/* -> multicurrencies
+applications/finance/accounting/others/multicurrencies/invoices_payments.rst applications/finance/accounting/others/multicurrencies.rst             # /multicurrencies/* -> multicurrencies

		The Exchange Difference journal records the differences between the invoiced amount at the
		creation date of the invoice and the amount received at the date of the payment. For example, if a

[IMP] accounting: updated multicurrency page #2559

[IMP] accounting: updated multicurrency page #2559

Uh oh!

Conversation

toaa-odoo commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Aug 4, 2022

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toaa-odoo commented Aug 8, 2022

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcs-odoo commented Sep 16, 2022

Uh oh!

jcs-odoo commented Sep 20, 2022

Uh oh!

Uh oh!

AntoineVDV left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

toaa-odoo commented Aug 4, 2022 •

edited

Loading