[IMP] accounting: full documentation of the new report engine #2784

oco-odoo · 2022-10-03T16:06:49Z

[toaa: documentation for the accounting engine report taskid: 3042880 ]

robodoo · 2022-10-03T16:07:01Z

oco-odoo · 2022-10-03T16:08:49Z

@jcs-odoo I still need to go over the helpers in the code, but let me know what you think of this one. I tried not to go too technical and keep explaining what was important for someone creating his own report. Hopefully I was clear enough ! ^^

AntoineVDV

I only checked content/developer/howtos/accounting_localization.rst for which I was pinged but LGTM.

jcs-odoo · 2022-10-04T10:40:37Z

Awesome @oco-odoo :)
It requires a lot of work before we can merge it, though, but it's so great to have such content from you! It's a gold mine :)
Thanks for participating in the user doc. That means a lot!

toaa-odoo · 2022-10-17T15:52:12Z

Accounting doc review was pinged by the bot and the PR is not in draft, but is it finished?

@jcs-odoo's comment seems to suggest otherwise. Let me know :)

LoredanaLrpz

Hello, hello, @toaa-odoo; I hope you're doing great; here's my review
Overall, I think you did great in making all these formulas comprehensible. (Plus, I couldn't find any broken link)

My main suggestions are

to give more explanations on what you describe is (or refer to a doc that explains it) in no more than two lines, but just to help readers understand
and to change the structure to make the creation steps clearer

I haven't read the last part in detail, so I'll check it afterward when the next force push is done :D

Wish you a great day!

The examples have a weird indentation (I suggested using PyCharm, you should be able to copy & paste - didn't change the content :))

content/applications/finance/accounting/reporting/overview/customize.rst

toaa-odoo · 2022-11-04T14:41:36Z

@LoredanaLrpz Don't re-review yet, I still have a few comments to address later :)

toaa-odoo · 2022-11-08T15:05:05Z

@LoredanaLrpz Don't re-review yet, I still have a few comments to address later :)

Done! You can review :)

xpl-odoo

Good job Tom, seems like you had fun with this one 🧠

content/applications/finance/accounting/reporting/overview/customize.rst

xpl-odoo · 2022-11-16T13:36:57Z

content/applications/finance/accounting/reporting/overview/customize.rst

+   To access the accounting report creation interface, the :ref:`developer mode <developer-mode>`
+   has to be activated.


Suggested change

To access the accounting report creation interface, the :ref:`developer mode <developer-mode>`

has to be activated.

Activate the :ref:`developer mode <developer-mode>` to access the accounting report creation interface

Suggestion

@toaa-odoo you resolved this without changing or commenting.

content/applications/finance/accounting/reporting/overview/customize.rst

content/developer/howtos/accounting_localization.rst

jcs-odoo

Just a quick comment here, but I wonder if the use of literal markups wouldn't be more appropriate than bold, when you write values and examples of formulas.
https://www.odoo.com/documentation/master/contributing/documentation/rst_cheat_sheet.html#technical-term-literal

content/applications/finance/accounting/reporting/overview/customize.rst

content/developer/howtos/accounting_localization.rst

xpl-odoo

Let me know if/when you need another review from me.

toaa-odoo · 2022-12-06T07:48:05Z

@oco-odoo You might want to have a look at @william-andre's comments

content/applications/finance/accounting/reporting/overview/customize.rst

content/developer/howtos/accounting_localization.rst

toaa-odoo · 2022-12-19T11:27:46Z

@oco-odoo @william-andre @tsb-odoo @jcs-odoo Should you have any additional comments, let me know now. Otherwise, I'm considering this PR ready for merge @AntoineVDV.

Forward to master.

AntoineVDV

@robodoo delegate+
@robodoo delegate=toaa-odoo

content/applications/finance/accounting/reporting/overview/customize.rst

content/developer/howtos/accounting_localization.rst

jcs-odoo

I'll push a few changes. (Tom, please check them with the "compare" button)

jcs-odoo · 2022-12-21T12:54:09Z

content/applications/finance/accounting/reporting/overview/customize.rst

+Create a report
+===============


This heading is redundant with the main title, especially if it's the sole h2 heading of this doc.
It also puts all the content one level lower.

I'll remove it and put all other headings as h2

jcs-odoo · 2022-12-21T12:58:34Z

content/applications/finance/accounting/reporting/overview/customize.rst

+   To access the accounting report creation interface, the :ref:`developer mode <developer-mode>`
+   has to be activated.


@toaa-odoo you resolved this without changing or commenting.

jcs-odoo · 2022-12-21T13:27:44Z

content/applications/finance/accounting/reporting/overview/customize.rst

+the page and the report is now available under :menuselection:`Accounting --> Reporting`. If a
+report has no root report, it is considered to be a root report itself.


"if a report has..." is a different idea than the rest of the paragraph. I'll move it above.

Engine report for accounting. taskid: 3042880

jcs-odoo · 2022-12-21T15:30:30Z

@robodoo r+

oco-odoo requested a review from jcs-odoo October 3, 2022 16:06

C3POdoo requested a review from a team October 3, 2022 16:08

oco-odoo requested a review from tsb-odoo October 3, 2022 16:08

oco-odoo force-pushed the 16.0-reportalypse-doc-oco branch from 3eafb40 to 5191640 Compare October 4, 2022 09:36

C3POdoo requested a review from a team October 4, 2022 09:37

AntoineVDV reviewed Oct 4, 2022

View reviewed changes

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch 11 times, most recently from ccbf71c to 7617e22 Compare October 25, 2022 11:19

toaa-odoo requested review from LoredanaLrpz and removed request for a team and jcs-odoo October 25, 2022 11:26

LoredanaLrpz requested changes Oct 31, 2022

View reviewed changes

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch from 7617e22 to 275ab09 Compare November 4, 2022 14:39

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch from 275ab09 to 12105a4 Compare November 8, 2022 15:02

toaa-odoo requested a review from LoredanaLrpz November 8, 2022 15:04

LoredanaLrpz approved these changes Nov 15, 2022

View reviewed changes

xpl-odoo requested changes Nov 17, 2022

View reviewed changes

jcs-odoo reviewed Nov 17, 2022

View reviewed changes

content/applications/finance/accounting/reporting/overview/customize.rst Show resolved Hide resolved

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch from f8bf397 to 469e743 Compare November 17, 2022 14:56

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch 5 times, most recently from b4b56ba to 51c55bd Compare November 30, 2022 14:36

oco-odoo force-pushed the 16.0-reportalypse-doc-oco branch from 51c55bd to a1bfa17 Compare December 1, 2022 14:26

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch from a1bfa17 to 48001ea Compare December 2, 2022 07:05

toaa-odoo requested a review from xpl-odoo December 2, 2022 07:06

C3POdoo requested a review from a team December 2, 2022 07:06

william-andre reviewed Dec 2, 2022

View reviewed changes

xpl-odoo removed their request for review December 5, 2022 11:30

xpl-odoo approved these changes Dec 5, 2022

View reviewed changes

oco-odoo commented Dec 9, 2022

View reviewed changes

toaa-odoo force-pushed the 16.0-reportalypse-doc-oco branch 2 times, most recently from 5ed4e30 to a981458 Compare December 19, 2022 11:18

AntoineVDV reviewed Dec 21, 2022

View reviewed changes

content/applications/finance/accounting/reporting/overview/customize.rst Outdated Show resolved Hide resolved

content/developer/howtos/accounting_localization.rst Outdated Show resolved Hide resolved

jcs-odoo reviewed Dec 21, 2022

View reviewed changes

[IMP] accounting: full documentation of the new report engine

3f9e898

Engine report for accounting. taskid: 3042880

jcs-odoo force-pushed the 16.0-reportalypse-doc-oco branch from a981458 to 3f9e898 Compare December 21, 2022 15:21

robodoo closed this in bf2d3d9 Dec 21, 2022

fw-bot mentioned this pull request Dec 21, 2022

[FW][IMP] accounting: full documentation of the new report engine #3226

Closed

robodoo temporarily deployed to merge December 21, 2022 17:02 Inactive

		To access the accounting report creation interface, the :ref:`developer mode <developer-mode>`
		has to be activated.

	To access the accounting report creation interface, the :ref:`developer mode <developer-mode>`
	has to be activated.
	Activate the :ref:`developer mode <developer-mode>` to access the accounting report creation interface

		the page and the report is now available under :menuselection:`Accounting --> Reporting`. If a
		report has no root report, it is considered to be a root report itself.

		Create a report
		===============

[IMP] accounting: full documentation of the new report engine #2784

[IMP] accounting: full documentation of the new report engine #2784

Uh oh!

Conversation

oco-odoo commented Oct 3, 2022 • edited by toaa-odoo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Oct 3, 2022

Uh oh!

oco-odoo commented Oct 3, 2022

Uh oh!

AntoineVDV left a comment

Choose a reason for hiding this comment

Uh oh!

jcs-odoo commented Oct 4, 2022

Uh oh!

toaa-odoo commented Oct 17, 2022

Uh oh!

LoredanaLrpz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toaa-odoo commented Nov 4, 2022

Uh oh!

toaa-odoo commented Nov 8, 2022

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xpl-odoo Nov 16, 2022

Choose a reason for hiding this comment

Uh oh!

jcs-odoo Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xpl-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

toaa-odoo commented Dec 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oco-odoo commented Oct 3, 2022 •

edited by toaa-odoo

Loading