Skip to content

[IMP] accounting: tax return #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] accounting: tax return #2909

wants to merge 1 commit into from

Conversation

@chiaraprattico
Copy link
Contributor

@chiaraprattico chiaraprattico commented Nov 4, 2022

taskid: 3056868

@robodoo
Copy link
Collaborator

robodoo commented Nov 4, 2022

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team November 4, 2022 15:31
@chiaraprattico chiaraprattico force-pushed the 14.0-taxreport-chpr branch 2 times, most recently from d3f2d31 to 9fd1d65 Compare November 7, 2022 15:13
@chiaraprattico chiaraprattico requested review from toaa-odoo and removed request for a team November 7, 2022 15:18
toaa-odoo
toaa-odoo suggested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chiara, shitty work! ;) I made a few suggestions, feel free to decline if you don't agree with them. :)

I'm adding a comment here since I can't do it directly in the diff:

Line 54: To configure your tax grids, go to...

toaa-odoo
toaa-odoo suggested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very few changes left, but I saw a few lines beyond the 100-character limit ? Is that normal ? :)

@toaa-odoo toaa-odoo requested a review from a team November 15, 2022 12:49
xpl-odoo
xpl-odoo requested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there ;)

@chiaraprattico chiaraprattico force-pushed the 14.0-taxreport-chpr branch 4 times, most recently from c731070 to b6f7e11 Compare November 29, 2022 12:47
@chiaraprattico chiaraprattico force-pushed the 14.0-taxreport-chpr branch 2 times, most recently from 470073f to 0c22e56 Compare November 29, 2022 14:40
jcs-odoo
jcs-odoo requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skim-read this and left a few comments.

content/applications/finance/accounting/reporting/declarations/tax_returns.rst
<../../fiscal_localizations/overview/fiscal_localization_packages>` for more information about
Fiscal Localization Packages.

.. _tax_return_lock:
Copy link
Contributor

@jcs-odoo jcs-odoo Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you delete this anchor?

Copy link
Contributor Author

@chiaraprattico chiaraprattico Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the point of it, at this specific point.

@chiaraprattico chiaraprattico requested a review from a team December 5, 2022 13:27
AntoineVDV
AntoineVDV approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 6, 2022
@chiaraprattico
[IMP] accounting: tax return
1db9968 
closes #2909

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo temporarily deployed to merge December 6, 2022 14:51 Inactive
@fw-bot fw-bot mentioned this pull request Dec 6, 2022
Closed
@robodoo robodoo closed this Dec 6, 2022
This was referenced Dec 6, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcs-odoo jcs-odoo jcs-odoo requested changes

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@xpl-odoo xpl-odoo xpl-odoo approved these changes

+1 more reviewer

@toaa-odoo toaa-odoo toaa-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@chiaraprattico @robodoo @AntoineVDV @jcs-odoo @xpl-odoo @toaa-odoo