Skip to content

Conversation

@samueljlieber
Copy link
Contributor

Task: #3164933

Targets: 16.0

This PR adds Ecuador fiscal localization documentation to Odoo user docs.

@samueljlieber samueljlieber self-assigned this Feb 3, 2023
@robodoo
Copy link
Collaborator

robodoo commented Feb 3, 2023

@samueljlieber samueljlieber force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch from f0a8690 to f0e59de Compare February 3, 2023 17:05
@samueljlieber
Copy link
Contributor Author

Hi @vbe-odoo 👋 I've created the PR for the l10n EC doc! Thank you for putting together the RST in the google doc 🙂

Throughout the doc I made adjustments to the RST and document layout, the changes are summarized below along with my reasoning:

  • Moved the Module installation under Configuration heading and removed the steps to install l10n_ec modules since they are covered by the Install reference on line 23 - similar reasoning in [IMP] l10n: update AR documentation #2430 (comment)
  • I did not include the screenshots for the Advanced Settings tab for Customer Invoice, Withholding, & Purchase Liquidations because I felt the notes for these steps were descriptive enough, and it helps keep the image count down.
  • Minor adjustments to sentence structure.

Overall this is a really great start and the doc ready for your review now that the RST & PR is created. Please let me know your thoughts on the changes 🙂

@vbe-odoo vbe-odoo marked this pull request as ready for review February 3, 2023 18:22
@C3POdoo C3POdoo requested a review from a team February 3, 2023 18:23
@vbe-odoo
Copy link
Contributor

vbe-odoo commented Feb 3, 2023

Hello @samueljlieber
Many thanks for creating the PR and improving the EC documentation shared with you.

I've done a review, and I agree with your changes!
It looks good to me!

I've moved this PR to Open by mistake, if you want you can move it back to draft.

IMPORTANT NOTE: But it is good to clarify that the EC localization is not yet released - we are close to it - so if the review keeps moving to another team, please wait for our good-to-go before merging this into the User Doc.

Thanks!

Copy link
Contributor

@vbe-odoo vbe-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your changes and the Documentation Looks Good to me.
cc' @ren-odoo @fvz-odoo

@StraubCreative StraubCreative marked this pull request as draft February 3, 2023 18:29
@StraubCreative
Copy link
Contributor

@vbe-odoo moved back to draft.
While we're waiting for EC release, I can review it before we open the PR and pass to accounting team for merge 👍

@vbe-odoo
Copy link
Contributor

@StraubCreative we've just r+ the modules of the EC localization 🥳
So this is ready to be moved to the accounting team when ready from your side.
Thanks!
cc' @ren-odoo @fvz-odoo

@StraubCreative
Copy link
Contributor

@samueljlieber there's a number of merge conflicts here.
Can you prioritize solving them and publish the PR asap so accounting team can review?
Then work with accounting and VBE on change requests until merge.
TIA/KR 🙏

@samueljlieber samueljlieber force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch from f0e59de to 419edb5 Compare February 15, 2023 14:45
@samueljlieber samueljlieber marked this pull request as ready for review February 15, 2023 15:24
@C3POdoo C3POdoo requested a review from a team February 15, 2023 15:25
@samueljlieber samueljlieber force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch 2 times, most recently from 1458685 to d81207b Compare February 15, 2023 15:37
@samueljlieber
Copy link
Contributor Author

Updates in d81207b:

Thank you @StraubCreative & @vbe-odoo for reviewing the changes! Sending to @odoo/accounting-doc-review!

@ren-odoo
Copy link
Contributor

Hi @odoo/accounting-doc-review

Can you take a look at this PR please? We're waiting on this documanation to be published in order to share the oficial release of the Ecuatorian Localization.

Thank you.

@jcs-odoo jcs-odoo removed the request for review from a team February 17, 2023 08:18
Copy link
Contributor

@Donapi Donapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for this new page, great work :)
I did a high-level review. Here are some general comments based on what we do from our side; feel free to consider them or not:

  • add more links to existing documentation
  • avoid putting too many images, especially screenshots of whole screens. We prefer to add screenshots that focus on parts of the screen that illustrate a specific point of what is described to make it easier to understand.
  • we prefer to write in the present tense than using future.

Introduction
============

Glossary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add a dedicated Glossary paragraph but rather a short introduction explaining what is SRI

EDI --> explain it in the Electronic Documents section
RIMPE --> what is the abbreviation of? I would explain it in the text when you mention it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Donapi for this section, we have recieved feedback from end user and internal staff that's good and practival to have the glosary from the start, that's why we added here. I just did some adjustments for the abreviations.

@samueljlieber samueljlieber force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch from aade209 to 133313c Compare February 17, 2023 19:47
@samueljlieber
Copy link
Contributor Author

@Donapi thank you for the suggestions!

Updates made in 133313c:

  • added links to documentation for EDI, chart of accounts, and credit notes
  • removed an unnecessary chart of accounts image
  • squashed @ren-odoo's revisions into one commit

@ren-odoo thank you for making some of the edits, can you help me with these remaining? 🙏

  1. Short introduction instead of a glossary
  2. Explain where the user has to navigate to for Withholding configuration
  3. Explain where the user has to navigate to for Purchase Liquidation configuration
  4. Explain where the user has to navigate to for configuring withholding code
  5. Confirm report path and take new screenshot that shows where to find both reports

Thank you so much!

@ren-odoo
Copy link
Contributor

Hi @Donapi

All the suggestions and changes requested changes have been addressed.

Is it possible release this first version and then if additional improvements are dectected we handle them in a new PR.

Our EC market and the Sales teams are already waiting for the Content, so it will be ideal if we can release it early next week.

Thank @samueljlieber for the additional changes.

@StraubCreative StraubCreative force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch 2 times, most recently from fade918 to e83dce2 Compare February 18, 2023 00:36
@StraubCreative
Copy link
Contributor

Squashed commits after change requests round + rebased on fade918.

Markup cleaning on e83dce2. Checks pass 👍

@ren-odoo
Copy link
Contributor

Hi @Donapi
Can you help us to check the last changes on this PR please?

We expect to do the offical release of the EC localziation this week, but we depend on this PR to be merged.

Thank you so much.

@samueljlieber samueljlieber force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch from 4975c9a to 0cf7078 Compare February 21, 2023 22:08
@samueljlieber
Copy link
Contributor Author

0cf7078 Updates:

Ready for review 🙂

@vbe-odoo
Copy link
Contributor

Hi @Donapi,
I hope you are doing well!

All changes were done and squashed, can you help us to review this PR?
As it would be ideal to have it for this week so we can do the official announcement with the User DOC ready.

Thanks!
cc' @ren-odoo

@jcs-odoo
Copy link
Contributor

Hi @vbe-odoo and @ren-odoo :)
I see Donatienne's review was a comment (not a change request) and gave a few pieces of advice here and there. So considering that this PR got already a few reviews, that Dona isn't available, and that it's urgent... Let's move forward with this PR ^^
(I haven't checked it)

@jcs-odoo jcs-odoo requested a review from a team February 24, 2023 10:05
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

@jcs-odoo jcs-odoo force-pushed the 16.0-l10n-ec-add-fiscal-doc-sali branch from 0cf7078 to 47a9368 Compare February 24, 2023 10:22
@jcs-odoo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in a1d2c7a Feb 24, 2023
@robodoo robodoo temporarily deployed to merge February 24, 2023 11:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants