-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[ADD] l10n: Ecuador fiscal doc #3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f0a8690 to
f0e59de
Compare
|
Hi @vbe-odoo 👋 I've created the PR for the l10n EC doc! Thank you for putting together the RST in the google doc 🙂 Throughout the doc I made adjustments to the RST and document layout, the changes are summarized below along with my reasoning:
Overall this is a really great start and the doc ready for your review now that the RST & PR is created. Please let me know your thoughts on the changes 🙂 |
|
Hello @samueljlieber I've done a review, and I agree with your changes! I've moved this PR to Open by mistake, if you want you can move it back to draft. IMPORTANT NOTE: But it is good to clarify that the EC localization is not yet released - we are close to it - so if the review keeps moving to another team, please wait for our good-to-go before merging this into the User Doc. Thanks! |
vbe-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@vbe-odoo moved back to draft. |
|
@StraubCreative we've just r+ the modules of the EC localization 🥳 |
|
@samueljlieber there's a number of merge conflicts here. |
f0e59de to
419edb5
Compare
1458685 to
d81207b
Compare
|
Updates in d81207b:
Thank you @StraubCreative & @vbe-odoo for reviewing the changes! Sending to @odoo/accounting-doc-review! |
|
Hi @odoo/accounting-doc-review Can you take a look at this PR please? We're waiting on this documanation to be published in order to share the oficial release of the Ecuatorian Localization. Thank you. |
Donapi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this new page, great work :)
I did a high-level review. Here are some general comments based on what we do from our side; feel free to consider them or not:
- add more links to existing documentation
- avoid putting too many images, especially screenshots of whole screens. We prefer to add screenshots that focus on parts of the screen that illustrate a specific point of what is described to make it easier to understand.
- we prefer to write in the present tense than using future.
| Introduction | ||
| ============ | ||
|
|
||
| Glossary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add a dedicated Glossary paragraph but rather a short introduction explaining what is SRI
EDI --> explain it in the Electronic Documents section
RIMPE --> what is the abbreviation of? I would explain it in the text when you mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Donapi for this section, we have recieved feedback from end user and internal staff that's good and practival to have the glosary from the start, that's why we added here. I just did some adjustments for the abreviations.
aade209 to
133313c
Compare
|
@Donapi thank you for the suggestions! Updates made in 133313c:
@ren-odoo thank you for making some of the edits, can you help me with these remaining? 🙏
Thank you so much! |
|
Hi @Donapi All the suggestions and changes requested changes have been addressed. Is it possible release this first version and then if additional improvements are dectected we handle them in a new PR. Our EC market and the Sales teams are already waiting for the Content, so it will be ideal if we can release it early next week. Thank @samueljlieber for the additional changes. |
fade918 to
e83dce2
Compare
|
Hi @Donapi We expect to do the offical release of the EC localziation this week, but we depend on this PR to be merged. Thank you so much. |
4975c9a to
0cf7078
Compare
|
Hi @vbe-odoo and @ren-odoo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate+
task-3164933
0cf7078 to
47a9368
Compare
|
@robodoo r+ |
Task: #3164933
Targets: 16.0
This PR adds Ecuador fiscal localization documentation to Odoo user docs.