[IMP] inventory: update serial numbers doc #3865

brse-odoo · 2023-03-22T20:06:14Z

This PR is targeting the serial numbers doc in Odoo's Inventory documentation.

Performed complete rewrite to the document for 14.0 to be fwd-ported (targeted revision for 15.0 and 16.0 to follow).

Completely rewrote the .rst file and added example flows
Replaced and updated all screenshots
Doc is more robust and comprehensive than before

robodoo · 2023-03-22T20:07:15Z

brse-odoo · 2023-03-22T20:11:07Z

Hi @jero-odoo and @larm-odoo! Whichever of you two is available to do so, this PR is ready for round one of peer review. Thank you in advance!

jero-odoo

@brse-odoo All set! Let me know if you have any questions.

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

brse-odoo · 2023-03-29T14:25:53Z

@StraubCreative This PR is ready for your final review.

brse-odoo · 2023-04-17T18:38:04Z

Hi @odoo/us-doc-review, this PR is ready for a content review when one of you has a chance. Thank you!

hojo-odoo

Hey Brandon,

Good job on this. Let me know if you would like to discuss any of my suggestions.

Thanks,
hojo

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

ksc-odoo

hey @brse-odoo just finished my peer review of this doc. great work! If you have any questions, don't hesitate to reach out. Thanks!

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

brse-odoo · 2023-05-03T17:55:36Z

@StraubCreative This is ready for final review.

StraubCreative

Hi @brse-odoo
Please fix all of the 100th character line break issues and tag me again.
Reminder after peer/doc review, tag @samueljlieber for technical review.
I shouldn't be seeing these 😉
Thanks.

brse-odoo · 2023-05-11T14:51:25Z

@StraubCreative The 100th character line breaks have been fixed. This is ready for final review

StraubCreative

100th char line breaks
cc: @samueljlieber

brse-odoo · 2023-05-15T19:01:21Z

I found a single 100th character error in this doc, fixed it, and pushed up the changes.

@samueljlieber If you could take a look for me and confirm everything looks good, I'd appreciate it. Thank you!

samueljlieber

Hi @brse-odoo 👋 I have a handful of technical changes throughout this doc, please see my suggestions below. I highlighted some of the 100th char line breaks, as well as adding global doc paths, using menuselections, and icon formatting.

Please let me know if you have any questions, otherwise Im looking forward to taking a second look! Thank you 🙂

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

samueljlieber · 2023-05-15T20:54:45Z

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

+Copy/paste serial numbers from an Excel file
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+To copy and paste serial numbers from an existing *Excel* file, first populate an *Excel*


I don't think we need to italicize Excel, curious on @StraubCreative 's thoughts here 🤔

Why not just say spreadsheet?
Does it have to be Excel (the MS product)?

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

brse-odoo · 2023-05-17T13:25:50Z

@samueljlieber I believe I've addressed all the technical issues in this doc -- if you have the time, I'd appreciate another once-over from you to confirm it looks good. Thanks in advance!

samueljlieber

Hi @brse-odoo thanks for the changes to this PR, on my second look I caught just a couple more items that I missed in my review previously. Overall I think this PR is ready for final review, so I will push the minor changes listed below and then tag this PR for review. Nice job, thank you! 🙂

samueljlieber · 2023-05-17T14:11:42Z

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

Icon formatting - It looks like my previous suggestion may not have formatted correctly in the GitHub suggestion - my appologies, this is the formatting I was proposing:

Suggested change

From here, click the :guilabel:`Additional Options` menu, represented by a `hamburger` icon (four

horizontal lines, located to the right of the :guilabel:`Unit of Measure` column in the

From here, click the :guilabel:`Additional Options` menu, represented by a :guilabel:`hamburger

(four horizontal lines)` icon, located to the right of the :guilabel:`Unit of Measure` column in the

samueljlieber · 2023-05-17T14:12:14Z

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

Remove duplicate paragraphs

Suggested change

Once all product quantities have been assigned a serial number, click the :guilabel:`Confirm` button

to close the pop-up. Then, click :guilabel:`Validate`.

A :guilabel:`Traceability` smart button appears upon validating the receipt. Click the

:guilabel:`Traceability` smart button to see the updated :guilabel:`Traceability Report`, which

includes: a :guilabel:`Reference` document, the :guilabel:`Product` being traced, the

:guilabel:`Lot/Serial #`, and more.

samueljlieber · 2023-05-17T14:12:44Z

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

Icon formatting again :)

Suggested change

From here, click the :guilabel:`Additional Options` menu, represented by a `hamburger` icon (four

horizontal lines, located to the right of the :guilabel:`Unit of Measure` column in the

From here, click the :guilabel:`Additional Options` menu, represented by a :guilabel:`hamburger

(four horizontal lines)` icon, located to the right of the :guilabel:`Unit of Measure` column in the

samueljlieber · 2023-05-17T14:29:54Z

Implemented technical changes in 2aa6463, @StraubCreative this PR is ready for your review 👍

StraubCreative

Hi @brse-odoo
Nice work. Very thorough and descriptive.
I have some suggestions for your consideration below, however, I think we're also good to merge right away, if you prefer.
Either way, passing the baton to you 🔥
Note: you can make Odoo 16 updates (e.g. language around click Save, etc.) on the FWP PRs if you'd like, or can create new PRs manually. Also up to you!

@robodoo delegate+

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst

StraubCreative · 2023-05-19T01:01:26Z

Quick follow-up @brse-odoo
serial-numbers-auto-assign-sn.png and serial-numbers-detailed-operations-popup.png are fine, technically, however the forms, presented as they are with so many line items, take up a lot of real-estate on the page. You could cut those line items down and still communicate the value around the form fields at the top.

brse-odoo · 2023-05-22T13:34:07Z

@robodoo r+

closes #3865 Signed-off-by: Brandon Seltenrich (brse) <brse@odoo.com>

brse-odoo self-assigned this Mar 22, 2023

C3POdoo requested a review from a team March 22, 2023 20:07

brse-odoo requested a review from jero-odoo March 23, 2023 15:08

jero-odoo reviewed Mar 23, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from 7e0eee1 to cd0fa19 Compare March 29, 2023 14:22

brse-odoo requested a review from StraubCreative March 29, 2023 14:25

brse-odoo requested a review from a team April 17, 2023 18:37

hojo-odoo suggested changes Apr 20, 2023

View reviewed changes

ksc-odoo reviewed Apr 21, 2023

View reviewed changes

ksc-odoo reviewed Apr 26, 2023

View reviewed changes

...t/applications/inventory_and_mrp/inventory/management/lots_serial_numbers/serial_numbers.rst Outdated Show resolved Hide resolved

ksc-odoo mentioned this pull request Apr 26, 2023

[IMP] inventory: fix and update lots #3850

Closed

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from cd0fa19 to 7e84934 Compare May 3, 2023 17:51

brse-odoo removed the request for review from StraubCreative May 3, 2023 17:55

brse-odoo requested a review from StraubCreative May 3, 2023 17:55

StraubCreative requested changes May 9, 2023

View reviewed changes

StraubCreative added the repeat designation for PRs worth a second look label May 9, 2023

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from 7e84934 to 30e79de Compare May 10, 2023 13:28

brse-odoo requested a review from StraubCreative May 11, 2023 14:51

StraubCreative requested changes May 15, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from 30e79de to f4260aa Compare May 15, 2023 18:53

samueljlieber requested changes May 15, 2023

View reviewed changes

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from f4260aa to 4cb3641 Compare May 17, 2023 13:22

samueljlieber approved these changes May 17, 2023

View reviewed changes

samueljlieber force-pushed the 14.0-inventory-update-serial-numbers-brse branch from 4cb3641 to 2aa6463 Compare May 17, 2023 14:16

samueljlieber requested a review from StraubCreative May 17, 2023 14:30

StraubCreative approved these changes May 19, 2023

View reviewed changes

[IMP] inventory: update serial numbers doc

0493eb9

brse-odoo force-pushed the 14.0-inventory-update-serial-numbers-brse branch from 2aa6463 to 0493eb9 Compare May 22, 2023 13:25

robodoo pushed a commit that referenced this pull request May 22, 2023

[IMP] inventory: update serial numbers doc

af4ad4c

closes #3865 Signed-off-by: Brandon Seltenrich (brse) <brse@odoo.com>

robodoo temporarily deployed to merge May 22, 2023 14:55 Inactive

robodoo closed this May 22, 2023

-From here, click the :guilabel:`Additional Options` menu, represented by a `hamburger` icon (four
-horizontal lines, located to the right of the :guilabel:`Unit of Measure` column in the
+From here, click the :guilabel:`Additional Options` menu, represented by a :guilabel:`hamburger
+(four horizontal lines)` icon, located to the right of the :guilabel:`Unit of Measure` column in the

-Once all product quantities have been assigned a serial number, click the :guilabel:`Confirm` button
-to close the pop-up. Then, click :guilabel:`Validate`.
-A :guilabel:`Traceability` smart button appears upon validating the receipt. Click the
-:guilabel:`Traceability` smart button to see the updated :guilabel:`Traceability Report`, which
-includes: a :guilabel:`Reference` document, the :guilabel:`Product` being traced, the
-:guilabel:`Lot/Serial #`, and more.

[IMP] inventory: update serial numbers doc #3865

[IMP] inventory: update serial numbers doc #3865

Uh oh!

Conversation

brse-odoo commented Mar 22, 2023

Uh oh!

robodoo commented Mar 22, 2023

Uh oh!

brse-odoo commented Mar 22, 2023

Uh oh!

jero-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brse-odoo commented Mar 29, 2023

Uh oh!

brse-odoo commented Apr 17, 2023

Uh oh!

hojo-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksc-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brse-odoo commented May 3, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

brse-odoo commented May 11, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

brse-odoo commented May 15, 2023

Uh oh!

samueljlieber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samueljlieber May 15, 2023

Choose a reason for hiding this comment

Uh oh!

StraubCreative May 19, 2023

StraubCreative left a comment •

edited

Loading