Skip to content

[IMP] accounting: improve accounting concept #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] accounting: improve accounting concept #4060

wants to merge 1 commit into from

Conversation

@chiaraprattico
Copy link
Contributor

@chiaraprattico chiaraprattico commented Apr 6, 2023 •
edited
Loading

taskid-2846856

@robodoo
Copy link
Collaborator

robodoo commented Apr 6, 2023

Pull request status dashboard.

@chiaraprattico chiaraprattico force-pushed the 15.0-accounting-concepts-chpr branch 6 times, most recently from 6399f86 to 61b8831 Compare April 7, 2023 14:23
@chiaraprattico chiaraprattico marked this pull request as ready for review April 7, 2023 14:24
@chiaraprattico chiaraprattico requested a review from Donapi April 7, 2023 14:24
@C3POdoo C3POdoo requested a review from a team April 7, 2023 14:24
@toaa-odoo toaa-odoo removed the request for review from a team April 11, 2023 09:31
@chiaraprattico chiaraprattico force-pushed the 15.0-accounting-concepts-chpr branch from 61b8831 to 430346b Compare April 13, 2023 07:27
Donapi
Donapi reviewed Apr 14, 2023
View reviewed changes
content/applications/finance/accounting/getting_started/main_concept.rst Outdated
Comment on lines 110 to 113
Odoo bank synchronization system directly connects with your bank institution to automatically
import all bank transactions into your database. This means a daily view about cashflow
will be available without having to log into the online banking system or wait for paper bank
statements.
Copy link
Contributor

@Donapi Donapi Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Odoo bank synchronization system directly connects with your bank institution to automatically
import all bank transactions into your database. This means a daily view about cashflow
will be available without having to log into the online banking system or wait for paper bank
statements.
Odoo bank synchronization system connects with your bank institution to automatically
import your bank transactions into your database, offering an overview of your cash flow without logging into the online banking system or waiting for paper bank statements.

Copy link
Contributor Author

@chiaraprattico chiaraprattico Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the sentence suggested a bit too long for English sentences' structure. I still kept your suggestion but made it in 2 sentences.

Donapi
Donapi requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Donapi Donapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chiara, let's review it together whenever you want :)

@chiaraprattico chiaraprattico force-pushed the 15.0-accounting-concepts-chpr branch 4 times, most recently from d7985c5 to a62bd1b Compare April 24, 2023 07:42
@Donapi
Copy link
Contributor

Donapi commented Apr 24, 2023

Thanks for the changes @chiaraprattico good to go!

@Donapi Donapi requested a review from a team April 24, 2023 07:52
@xpl-odoo xpl-odoo requested review from xpl-odoo and removed request for a team May 8, 2023 12:12
xpl-odoo
xpl-odoo requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hesitate to reach out if you would like to discuss my suggestions :)

@chiaraprattico chiaraprattico force-pushed the 15.0-accounting-concepts-chpr branch from a62bd1b to 8ff290f Compare May 11, 2023 15:05
@chiaraprattico chiaraprattico requested a review from xpl-odoo May 11, 2023 15:06
@chiaraprattico chiaraprattico force-pushed the 15.0-accounting-concepts-chpr branch 2 times, most recently from dda2684 to eed4f40 Compare May 12, 2023 06:36
@chiaraprattico
Copy link
Contributor Author

chiaraprattico commented May 22, 2023

Hi @xpl-odoo , I believe I changed the PR according to your review, let me know if more is needed.

@xpl-odoo xpl-odoo marked this pull request as draft May 23, 2023 09:02
@xpl-odoo xpl-odoo force-pushed the 15.0-accounting-concepts-chpr branch from eed4f40 to 0175382 Compare May 23, 2023 09:02
@xpl-odoo xpl-odoo marked this pull request as ready for review May 23, 2023 09:03
@C3POdoo C3POdoo requested a review from a team May 23, 2023 09:05
@xpl-odoo
Copy link
Contributor

xpl-odoo commented May 23, 2023

Hi @xpl-odoo , I believe I changed the PR according to your review, let me know if more is needed.

Had to rebase first due to #4422 and change the :doc: links accordingly :)

@xpl-odoo xpl-odoo force-pushed the 15.0-accounting-concepts-chpr branch from 0175382 to 41c0c21 Compare May 23, 2023 09:10
@C3POdoo C3POdoo requested a review from a team May 23, 2023 09:21
@xpl-odoo xpl-odoo force-pushed the 15.0-accounting-concepts-chpr branch from 41c0c21 to bdecb94 Compare May 23, 2023 09:29
@xpl-odoo xpl-odoo removed request for a team May 23, 2023 09:30
@xpl-odoo
Copy link
Contributor

xpl-odoo commented May 23, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request May 23, 2023
@chiaraprattico @xpl-odoo
[IMP] accounting: improve accounting concept
4fc2446 
task-2846856

closes #4060

Signed-off-by: Platteau Xavier (xpl) <xpl@odoo.com>
@fw-bot fw-bot mentioned this pull request May 23, 2023
Closed
@robodoo robodoo temporarily deployed to merge May 23, 2023 16:01 Inactive
@robodoo robodoo closed this May 23, 2023
This was referenced May 23, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Donapi Donapi Donapi approved these changes

@xpl-odoo xpl-odoo Awaiting requested review from xpl-odoo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chiaraprattico @robodoo @Donapi @xpl-odoo