Skip to content

[MOV] accounting: restructuration of the accounting documentation #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MOV] accounting: restructuration of the accounting documentation #4422

wants to merge 1 commit into from

Conversation

@jcs-odoo
Copy link
Contributor

@jcs-odoo jcs-odoo commented May 12, 2023

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented May 12, 2023

Pull request status dashboard.

@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch 2 times, most recently from 6613276 to b31be6d Compare May 12, 2023 14:18
@jcs-odoo jcs-odoo changed the title [MOV] accounting: restructuration of the reporting section [MOV] accounting: toc restructuration May 12, 2023
@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch 8 times, most recently from 42cf3bc to f3c5612 Compare May 16, 2023 12:26
jcs-odoo
jcs-odoo commented May 16, 2023
View reviewed changes
content/applications/websites/ecommerce/taxes.rst Outdated
Comment on lines -10 to -13
Copy link
Contributor Author

@jcs-odoo jcs-odoo May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odoo/ecommerce-doc-review

I removed this double indexation from e-commerce. I know @toaa-odoo did the same in 16.0... Ideally, if (when) this goes through, we'd need something to replace this. The best is to add a written paragraph or see also section somewhere else to inform users to check the taxes docs.

jcs-odoo
jcs-odoo commented May 16, 2023
View reviewed changes
content/applications/websites/ecommerce/getting_started/product_page.rst Outdated
Copy link
Contributor Author

@jcs-odoo jcs-odoo May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odoo/ecommerce-doc-review I removed this here too

jcs-odoo
jcs-odoo commented May 16, 2023
View reviewed changes
content/applications/sales/sales/products_prices/taxes.rst Outdated
Comment on lines -10 to -14
Copy link
Contributor Author

@jcs-odoo jcs-odoo May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @odoo/sales-doc-review

If (when) this PR goes through, it will remove this double indexation of the pages about taxes (normally, we shouldn't have the same doc twice in the toc tree, but this was done a long while ago). However, we should replace this with a paragraph somewhere that explain to the sales users that there are docs to read about taxes, with a seealso section.

@jcs-odoo jcs-odoo mentioned this pull request May 16, 2023
Closed
@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch from f3c5612 to 9b2384e Compare May 16, 2023 12:44
@jcs-odoo jcs-odoo marked this pull request as ready for review May 16, 2023 12:45
@jcs-odoo
Copy link
Contributor Author

jcs-odoo commented May 16, 2023

I still have to squash and maybe add cards instead of seealso for the category pages, but this first version is ready :)
We still need the input from the product owners.

@C3POdoo C3POdoo requested review from a team May 16, 2023 12:51
@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch from 9b2384e to 5fcc723 Compare May 16, 2023 13:39
@AntoineVDV AntoineVDV removed the request for review from a team May 16, 2023 14:07
@jcs-odoo jcs-odoo requested review from a team, chiaraprattico and toaa-odoo and removed request for a team May 19, 2023 15:03
@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch 2 times, most recently from 8232bc8 to 568770e Compare May 19, 2023 15:50
@jcs-odoo
Copy link
Contributor Author

jcs-odoo commented May 19, 2023

Hi @ksc-odoo :)
No worries at all! I appreciate that you wanted to help with this section of the documentation. I'm aware some of these pages are in a terrible state, and help is always welcome!

@StraubCreative thanks for the explanation, it's interesting.

@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch from 568770e to 80fb5db Compare May 19, 2023 16:14
jcs-odoo
jcs-odoo commented May 19, 2023
View reviewed changes
Copy link
Contributor Author

@jcs-odoo jcs-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@jcs-odoo jcs-odoo changed the title [MOV] accounting: toc restructuration [MOV] accounting: restructuration of the accounting documentation May 19, 2023
@jcs-odoo
Copy link
Contributor Author

jcs-odoo commented May 19, 2023

@robodoo r-

@jcs-odoo jcs-odoo force-pushed the 15.0-accounting-structurepocalypse-jcs branch from 80fb5db to 9614a85 Compare May 19, 2023 16:44
@jcs-odoo
[MOV] accounting: restructuration of the accounting documentation
9614a85 
This commit improves the structure of the accounting documentation by
- reducing the levels necessary to reach the information
- grouping some docs
- moving content to their parent category page (content in all levels)
- renaming some sections to reflect the structure of the app better

task-3330093
@jcs-odoo
Copy link
Contributor Author

jcs-odoo commented May 19, 2023

@robodoo r+ for real ^^

BoomBombGIF

robodoo pushed a commit that referenced this pull request May 19, 2023
@jcs-odoo
[MOV] accounting: restructuration of the accounting documentation
6f16d7e 
This commit improves the structure of the accounting documentation by
- reducing the levels necessary to reach the information
- grouping some docs
- moving content to their parent category page (content in all levels)
- renaming some sections to reflect the structure of the app better

task-3330093

closes #4422

Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
@robodoo robodoo temporarily deployed to merge May 19, 2023 17:46 Inactive
@robodoo robodoo closed this May 19, 2023
This was referenced May 19, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@xpl-odoo xpl-odoo mentioned this pull request May 23, 2023
Closed
@jcs-odoo jcs-odoo mentioned this pull request Oct 4, 2023
Closed
@StraubCreative StraubCreative mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiaraprattico chiaraprattico Awaiting requested review from chiaraprattico

@toaa-odoo toaa-odoo Awaiting requested review from toaa-odoo

1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcs-odoo @robodoo @StraubCreative @ksc-odoo