Skip to content

Conversation

@gawa-odoo
Copy link
Contributor

Since odoo/odoo#115222, a new line on an invoice won't have the default sales tax put on by default. If there are no taxes on the product, the account or from predictive, the tax will stay empty Its use has been restricted back to the tax put on new products. It is still used in Accounting Firms mode, as we don't want people to have to input the product when quick encoding.

task-3045026

@robodoo
Copy link
Collaborator

robodoo commented May 12, 2023

@gawa-odoo gawa-odoo requested a review from a team May 12, 2023 09:04
Copy link
Contributor

@chiaraprattico chiaraprattico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for this one. I made a few suggestions. You can find more information about adding images to a doc over here https://www.odoo.com/documentation/15.0/contributing/documentation/rst_cheat_sheet.html#images

It is also used to prefill the **Taxes** field with when you add a new line on an invoice in Accounting Firms mode.

.. image:: default_taxes/default-taxes-invoice-line.png
.. image:: default_taxes/default-taxes-product.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a better resolution, please take the screenshot with 110% zoom (or more if needed). Also, the file should always be compressed, if there are any irrelevant parts, it's better to crop them ( for example, here the internal note field at the bottom can be left out so we can focus on what matters).

Comment on lines 5 to 6
**Default Taxes** define which :doc:`taxes <taxes>` are automatically selected when creating a new product.
It is also used to prefill the **Taxes** field with when you add a new line on an invoice in Accounting Firms mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default Taxes define which :doc:taxes <taxes> are automatically selected when creating a new product.
They also used to prefill the :guilabel:Taxes field when adding a new line on an invoice in Accounting Firms mode.

@gawa-odoo gawa-odoo force-pushed the master-account-tax_computed_default_documentation-gawa branch 2 times, most recently from bf61f3d to da71051 Compare May 16, 2023 07:40
@chiaraprattico chiaraprattico requested a review from a team May 16, 2023 07:46
@jcs-odoo
Copy link
Contributor

oh no, this is going one of the many conflicts with the restructure :'(

@gawa-odoo
Copy link
Contributor Author

oh no, this is going one of the many conflicts with the restructure :'(

I don't know what the restructure is about, but I don't mind waiting to rebase and merge it afterwards. I mainly wanted to do it to not forget about this change.

@jcs-odoo
Copy link
Contributor

oh no, this is going one of the many conflicts with the restructure :'(

I don't know what the restructure is about, but I don't mind waiting to rebase and merge it afterwards. I mainly wanted to do it to not forget about this change.

Haha! No, no worries @gawa-odoo go ahead and merge this whenever needed!

Here is our attempt at improving the structure of the accounting documentation.
#4422

@jcs-odoo jcs-odoo marked this pull request as draft May 24, 2023 12:05
@jcs-odoo jcs-odoo changed the base branch from master to saas-16.3 May 24, 2023 12:05
@jcs-odoo jcs-odoo force-pushed the master-account-tax_computed_default_documentation-gawa branch from da71051 to 44159ad Compare May 24, 2023 12:06
@jcs-odoo jcs-odoo marked this pull request as ready for review May 24, 2023 12:06
@jcs-odoo jcs-odoo changed the title [IMP] accounting: default_taxes.rst - Changes on invoices [IMP] accounting: default taxes in taxes.rst May 24, 2023
@C3POdoo C3POdoo requested a review from a team May 24, 2023 12:07
Since odoo/odoo#115222, a new line on an invoice
won't have the default sales tax put on by default. If there are no
taxes on the product, the account or from predictive, the tax will stay
empty. Its use has been restricted back to the tax put on new products.
It is still used in Accounting Firms mode, as we don't want people
to have to input the product when quick encoding.

task-3045026
@jcs-odoo jcs-odoo force-pushed the master-account-tax_computed_default_documentation-gawa branch from 44159ad to 599e7e4 Compare May 24, 2023 13:27
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request May 24, 2023
Since odoo/odoo#115222, a new line on an invoice
won't have the default sales tax put on by default. If there are no
taxes on the product, the account or from predictive, the tax will stay
empty. Its use has been restricted back to the tax put on new products.
It is still used in Accounting Firms mode, as we don't want people
to have to input the product when quick encoding.

task-3045026

closes #4421

Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
robodoo pushed a commit that referenced this pull request May 24, 2023
Since odoo/odoo#115222, a new line on an invoice
won't have the default sales tax put on by default. If there are no
taxes on the product, the account or from predictive, the tax will stay
empty. Its use has been restricted back to the tax put on new products.
It is still used in Accounting Firms mode, as we don't want people
to have to input the product when quick encoding.

task-3045026

closes #4421

Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
@robodoo robodoo temporarily deployed to merge May 24, 2023 19:26 Inactive
@robodoo robodoo closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants